Turn off selection mode when one transaction is left#61478
Conversation
|
Assigning @ishpaul777 since this is a follow up to #61373 |
|
There's a failing jest test: |
…f-selection-mode-when-one-transaction-left
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-06.at.7.55.44.PM.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2025-05-06.at.7.53.48.PM.movScreen.Recording.2025-05-06.at.7.52.06.PM.moviOS: mWeb SafariScreen.Recording.2025-05-06.at.7.19.52.PM.movMacOS: Chrome / SafariScreen.Recording.2025-05-06.at.7.11.56.PM.movMacOS: DesktopScreen.Recording.2025-05-06.at.8.01.42.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…f-selection-mode-when-one-transaction-left (cherry picked from commit 99f2a5a) (cherry-picked to staging by luacmartins)
|
FYI please review my conflict resolution here |
…863766582-1 🍒 Cherry pick PR #61478 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.1.40-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.1.41-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.41-1 🚀
|
Explanation of Change
Fixed Issues
$ #61440
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-05-06.at.13.21.51.mov
MacOS: Desktop