Split expense flow

[ZhenjaHorbach]

Explanation of Change

Implement Split expense flow (Phase 1)

Fixed Issues

$ #61027
PROPOSAL:

Tests

1. Navigate to an eligible expense in your reports or expenses list
2. Open the more menu
3. Click the “Split” button
4. Verify that the split UI appears
5. Click add split button
6. Verify that a new split added with 0 amount
7. Try to change amount in a split item
8. Verify that value has changed
9. Try to save value with greater or lesser amount than default or with a split item with 0 amount
10. Verify that the error has appeared (we can save a lesser total amount than the original amount and don't show the error if it is not isPerDiem or isCard)
11. Try to press a split item
12. Verify that the editing screen is open and you can change the split item data
13. Try to save with correct amount
14. Verify that the split transactions have been created and the original transaction has disappeared

• Verify that no errors appear in the JS console

Offline tests

1. Navigate to an eligible expense in your reports or expenses list
2. Open the more menu
3. Click the “Split” button
4. Verify that the split UI appears
5. Click add split button
6. Verify that a new split added with 0 amount
7. Try to change amount in a split item
8. Verify that value has changed
9. Try to save value with greater or lesser amount than default or with a split item with 0 amount
10. Verify that the error has appeared (we can save a lesser total amount than the original amount and don't show the error if it is not isPerDiem or isCard)
11. Try to press a split item
12. Verify that the editing screen is open and you can change the split item data
13. Try to save with correct amount
14. Verify that the split transactions have been created and the original transaction has disappeared

QA Steps

1. Navigate to an eligible expense in your reports or expenses list
2. Open the more menu
3. Click the “Split” button
4. Verify that the split UI appears
5. Click add split button
6. Verify that a new split added with 0 amount
7. Try to change amount in a split item
8. Verify that value has changed
9. Try to save value with greater or lesser amount than default or with a split item with 0 amount
10. Verify that the error has appeared (we can save a lesser total amount than the original amount and don't show the error if it is not isPerDiem or isCard)
11. Try to press a split item
12. Verify that the editing screen is open and you can change the split item data
13. Try to save with correct amount
14. Verify that the split transactions have been created and the original transaction has disappeared

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[garrettmknight]

Not sure if this is an issue or not, but I'm getting this weird create expense flow when I'm trying to upload a receipt. Tested on staging and I'm not getting it in the flow, but I'm getting some weird auth errors when testing across the ad-hoc build and staging:

Screen.Recording.2025-05-29.at.10.16.16.AM.mov

[garrettmknight]

Ok, another one I'm not sure about. When I 'Mark as cash' and then split, the splits show that they're still awaiting merge until I open one, then it flashes 'Mark as cash' before disappearing:

Screen.Recording.2025-05-29.at.10.23.57.AM.mov

[garrettmknight]

Alright, last one. When an admin splits an expense for a submitter on a draft report, the original expense is still showing in the preview:

1. As the submitter, create an expense (I scanned a receipt)
2. As an admin, open the draft report and attempt to split the expense

Expected: Expense is split, original transaction is hidden
Actual: Expense is split, original transaction shows. All three expenses show errors. Clearing the error on the original transaction does some weird stuff.

Screen.Recording.2025-05-29.at.10.34.17.AM.mov

[lakchote]

Not sure if this is an issue or not, but I'm getting this weird create expense flow when I'm trying to upload a receipt. Tested on staging and I'm not getting it in the flow, but I'm getting some weird auth errors when testing across the ad-hoc build and staging:

It looks like a violation issue because the category is missing. It shouldn't be related to our Splits feature as it's tied to the Create Expense flow.

Ok, another one I'm not sure about. When I 'Mark as cash' and then split, the splits show that they're still awaiting merge until I open one, then it flashes 'Mark as cash' before disappearing:

It looks like an optimistic Onyx issue, hence the briefly appearing Mark as cash before going away. cc @ZhenjaHorbach

Alright, last one. When an admin splits an expense for a submitter on a draft report, the original expense is still showing in the preview

EDIT: I've been able to reproduce with the preconditions. A backend error is thrown which explains why the original transaction is returned.

There's a PR from @rlinoz to handle this particular issue.

There's also a pending Web-E PR to be merged, but tests are failing.

If I'm checking out the Web-E branch of Rodrigo, I don't have the issue.

[garrettmknight]

I've tried to reproduce the issue on the ad-hoc build (where the submitter is an admin) and it does correctly hide the original transaction which confirms it's likely is a frontend issue:

Clarifying the admin is a separate user in this flow.

[ZhenjaHorbach]

Ok, another one I'm not sure about. When I 'Mark as cash' and then split, the splits show that they're still awaiting merge until I open one, then it flashes 'Mark as cash' before disappearing:

Screen.Recording.2025-05-29.at.10.23.57.AM.mov

Actually I can't reproduce this issue
Could you share your receipt, please ?

[garrettmknight]

Here's the receipt I was using.

[lakchote]

I've discussed it with @garrettmknight, and since the third issue is a pretty niche flow that we have a fix for underway, we can proceed with merging the PR.

@ZhenjaHorbach can you fix the conflicts please?

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.54-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.54-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅