Add several UI fixes to MoneyRequestTransaction list by Kicu · Pull Request #61677 · Expensify/App

Kicu · 2025-05-08T10:20:42Z

Explanation of Change

This PR contains some minor UI tweaks that are mostly followups after other PRs.
Done:

mweb & Android - Extra spacing between Select multiple header and dropdown button #61557 - extra space when selection mode header displayed is fixed
fixed unnecessary empty spacing in transactionItemRow: Add Transaction and MoneyRequestReport UI tweaks #61159 (comment)
fixed Help Pane button wrongly displayed in SearchMoneyRequestReport page (see image) - no issue for this bug but its very small

wrong help pane button

Fixed Issues

$ #61557
PROPOSAL:

Tests

go to money request report that has > 1 transactions
verify that transaction rows on small screen have no extra spacing inside when: merchant and or tag/category are missing
verify that transaction rows on small screen have no extra spacing inside when all the data is correct
verify ☝️ the same where there are RBR violations
on mobile longpress to go to mobile selection mode, and verify there is no extra spacing (issue 61557)

Offline tests

QA Steps

Same as Tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

help pane button

MacOS: Desktop

melvin-bot · 2025-05-08T10:50:37Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kicu · 2025-05-08T10:50:47Z

CC @jnowakow @sumo-slonik

jnowakow

🚀

sumo-slonik · 2025-05-08T15:10:01Z

✅

Kicu · 2025-05-09T08:04:25Z

src/components/TransactionItemRow/index.tsx

    isSelected: boolean;
    shouldShowTooltip: boolean;
    dateColumnSize: TableColumnSize;
-    shouldShowChatBubbleComponent?: boolean;


this was only used twice in the app, and always true so I removed it

Kicu · 2025-05-09T08:13:18Z

@Expensify/design please take a look - mostly it fixes the empty spacing in transaction rows which looked bad.

DylanDylann · 2025-05-09T08:35:03Z

src/components/TransactionItemRow/index.tsx

+                                    containerStyles={[styles.mt3]}
+                                />
                            </View>
-                            {shouldShowChatBubbleComponent && <ChatBubbleCell transaction={transactionItem} />}


Please don't remove this check. We should prevent ChatBubbleCell from rendering if shouldShowChatBubbleComponent is false

@DylanDylann can you tell me when it could be false?

DylanDylann · 2025-05-09T08:35:11Z

src/components/TransactionItemRow/index.tsx

                                />
                            </View>
                            <View style={[StyleUtils.getReportTableColumnStyles(CONST.REPORT.TRANSACTION_LIST.COLUMNS.COMMENTS)]}>
-                                {shouldShowChatBubbleComponent && <ChatBubbleCell transaction={transactionItem} />}


DylanDylann · 2025-05-09T09:09:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-12.at.11.17.34.mov

Android: mWeb Chrome

Screen.Recording.2025-05-12.at.11.12.35.mov

iOS: HybridApp

Screen.Recording.2025-05-12.at.11.16.11.mov

iOS: mWeb Safari

Screen.Recording.2025-05-12.at.11.11.20.mov

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-05-09T09:17:30Z

🚧 @trjExpensify has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-09T09:56:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61677-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61677-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61677/NewExpensify.dmg	https://61677.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-05-09T12:18:01Z

I'm having some trouble testing - do we have updated screenshots/videos I can review?

Kicu · 2025-05-09T12:42:54Z

Kicu · 2025-05-09T12:47:59Z

ahh sorry the screenshots were done before merging the other PR that @sumo-slonik did - on the adhoc with newest main the date and total are aligned and centered.
This are simply earlier screenshots

shawnborton · 2025-05-09T12:50:03Z

Let me know when we have up-to-date screenshots to review, thanks!

shawnborton · 2025-05-09T12:50:21Z

@DylanDylann any reason why they are missing from your checklist?

Kicu · 2025-05-09T12:54:15Z

I think it's cos the new code from the 2 PRs merged just came in early today 😅

DylanDylann

@shawnborton All updated

mollfpr

LGTM 👍

Thank you!

mountiny

Just waiting for @shawnborton to give a 🟢

Kicu · 2025-05-12T12:14:16Z

@shawnborton if recently you have noticed any other visual problems around report view (the new) etc. then you can also use this PR to point these out.

shawnborton · 2025-05-12T16:03:28Z

From the screenshots above on mobile, it looks like all of the reports are mossing the From/To line to the left of the action button:

We use the From/To here to balance out the negative space on the left side.

shawnborton · 2025-05-12T16:04:23Z

Unless that is being addressed elsewhere... then we can merge this and follow up with that.

mountiny · 2025-05-12T16:52:00Z

I am not sure about this one actually but since its EOD I think we can just handle this in a follow up too @Kicu

OSBotify · 2025-05-12T17:00:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-13T18:23:41Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-13T19:34:06Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-15T19:01:55Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Kicu force-pushed the kicu/61557-fix-ui branch from de49af9 to 94eb2b0 Compare May 8, 2025 10:34

Kicu marked this pull request as ready for review May 8, 2025 10:50

Kicu requested a review from a team as a code owner May 8, 2025 10:50

melvin-bot bot requested review from DylanDylann and removed request for a team May 8, 2025 10:50

jnowakow approved these changes May 8, 2025

View reviewed changes

sumo-slonik approved these changes May 8, 2025

View reviewed changes

sumo-slonik mentioned this pull request May 8, 2025

Add unreportedExpense to report page #60352

Merged

50 tasks

Kicu added 4 commits May 9, 2025 09:43

Fix bad spacing in selection mode on MoneyRequestReportActionsList

78ce478

Fix spacing in TransactionItemRow

320152e

Stop displaying help button on desktop SearchMoneyRequestReportPage

eeabde3

Fix useOnyx in ChatBubbleCell

7e1e0e7

Kicu force-pushed the kicu/61557-fix-ui branch from 94eb2b0 to 7e1e0e7 Compare May 9, 2025 07:43

Kicu commented May 9, 2025

View reviewed changes

DylanDylann reviewed May 9, 2025

View reviewed changes

trjExpensify requested a review from mountiny May 9, 2025 10:37

DylanDylann approved these changes May 12, 2025

View reviewed changes

melvin-bot bot requested a review from mollfpr May 12, 2025 04:22

mollfpr approved these changes May 12, 2025

View reviewed changes

mountiny assigned Kicu May 12, 2025

mountiny approved these changes May 12, 2025

View reviewed changes

mountiny merged commit 729ee1b into Expensify:main May 12, 2025
19 of 23 checks passed

github-actions bot mentioned this pull request May 13, 2025

Deploy Checklist: New Expensify 2025-05-13 #61917

Closed

Conversation

Kicu commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

wrong help pane button

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

help pane button

Uh oh!

melvin-bot bot commented May 8, 2025

Uh oh!

Kicu commented May 8, 2025

Uh oh!

jnowakow left a comment

Choose a reason for hiding this comment

Uh oh!

sumo-slonik commented May 8, 2025

Uh oh!

Kicu May 9, 2025

Choose a reason for hiding this comment

Uh oh!

Kicu commented May 9, 2025

Uh oh!

DylanDylann May 9, 2025

Choose a reason for hiding this comment

Uh oh!

Kicu May 9, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann May 9, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

shawnborton commented May 9, 2025

Uh oh!

Kicu commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kicu commented May 9, 2025

Uh oh!

shawnborton commented May 9, 2025

Uh oh!

shawnborton commented May 9, 2025

Uh oh!

Kicu commented May 9, 2025

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Kicu commented May 12, 2025

Uh oh!

shawnborton commented May 12, 2025

Uh oh!

shawnborton commented May 12, 2025

Uh oh!

mountiny commented May 12, 2025

Uh oh!

Uh oh!

OSBotify commented May 12, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

Kicu commented May 8, 2025 •

edited

Loading

DylanDylann commented May 9, 2025 •

edited

Loading

Kicu commented May 9, 2025 •

edited

Loading