Fix getting in-wallet card status on iOS by Skalakid · Pull Request #61769 · Expensify/App

Skalakid · 2025-05-09T10:20:20Z

Important

Please merge after #60270

Explanation of Change

Recently the Expensify Cards details were updated and now they are properly linked to the Expensify App. This PR changes the identifier that we are passing to the react-native-wallet library so we can choose the correct card from the wallet and check its state. Previously the assumed that the card's Primary Account Identifier is just a card token returned from the backend (PR). We couldn't test it, since cards weren't linked properly to the App and PassKit always returned an empty array when trying to list all cards. Now everything works, and after checking the expensifyCard_panReferenceID, it is a correct Primary Account Identifier.

Fixed Issues

$ #60112
PROPOSAL:

Tests

Important

This feature fully works only on signed builds on physical devices. Please test it on staging or production builds

Open the App
Go to Settings
Go to Wallet Page
Click on any card
Click the Add Card to Wallet button
Go threw In-App Provisioning flow and add the card to the wallet
Verify if after returning to the E/App, the buton was hidden and Card is already in wallet text appeared

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

ios.MP4

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

github-actions · 2025-05-12T11:27:13Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…fix-getting-card-status-on-ios

github-actions · 2025-05-15T15:48:00Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny · 2025-05-15T15:48:26Z

@brunovjk could you do a quick test of the native apps?

melvin-bot · 2025-05-15T15:49:03Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-05-15T16:28:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61769-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61769-hybrid/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

Skalakid · 2025-05-16T10:45:05Z

It seems like getting card status doesn’t work on ad-hoc builds. The ad-hoc app probably has different properties, and Expensify Cards aren’t linked with it, and we can’t access it through Apple’s PassKit library

dev	ad-hoc

@mountiny, I think it's something that needs to be fixed by Marqeta, but it doesn't block us with this PR, since on dev builds, everything works

mountiny · 2025-05-16T11:38:59Z

Ok yeah I agree, @brunovjk would you be able to complete your testing on this PR ?

brunovjk · 2025-05-16T11:56:27Z

Sure! Im on it now!

zfurtak · 2025-05-16T12:16:35Z

FYI I checked the edge case where Android wasn't working and everything is fine now 🚀 but of course you'd better double check me @brunovjk 😅

brunovjk · 2025-05-16T14:26:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp - Emulator

61769_android_native.mov

Android: HybridApp - Emulator not signed in

61769_android_native_no_signed.mov

Android: HybridApp - Adhoc on physical android

Android: mWeb Chrome

61769_android_web.mov

iOS: HybridApp

61769_ios_native.mov

iOS: mWeb Safari

61769_ios_web.mov

MacOS: Chrome / Safari

61769_web_chrome.mov

MacOS: Desktop

61769_web-desktop.mov

brunovjk · 2025-05-16T14:55:00Z

src/types/onyx/Card.ts


+        /** Card's primary account identifier */
+        // eslint-disable-next-line @typescript-eslint/naming-convention
+        expensifyCard_panReferenceID?: string;


@Skalakid is there still a need for the expensifyCard_panReferenceID field here? I noticed it’s not currently used anywhere outside of nameValuePairs. If there’s no plan to use it at the top level, should we consider removing it to keep the type clean?

I think we need it. In iOS's isCardInWallet wallet function, we are checking either using this value or using the card suffix. The card suffix isn't unique, there can be a situation where 2 cards have the same last 4 numbers. So, checking the state using panReferenceID is better in most situations. However, it's not always present, especially when you add the card manually threw Apple Wallet, so that why we are using the suffix listing too

Great! Thanks for clarifying 🚀 🚀 🚀

brunovjk

I’ve reviewed and tested the PR as much as possible:

On my Android emulator, I can get to the point where I see a not device allowed message, up to this point everything seems fine to me:
On my physical Android device (with the latest adhoc build), I couldn’t get as far—the button doesn’t even show up.
On all other platforms, I also don’t see the button, but the app runs normally in my tests.

Other than this comment, which I don't think would be a blocker, everything else in the code looks fine to me.

Skalakid · 2025-05-16T15:05:06Z

On my physical Android device (with the latest adhoc build), I couldn’t get as far—the button doesn’t even show up.

Yeah, I think we need to whitelist ad-hoc builds to be able to use the Google SDK. Right now every call returns Not verified error, so the button is hidden

zfurtak · 2025-05-19T08:24:08Z

@mountiny as the PR is approved by Bruno, can we go ahead with it? 😊

Skalakid · 2025-05-19T08:38:30Z

Snce this PR fixed mostly the iOS part, and the feature can only be tested on physical devices with signed app builds, I think we can continue testing iOS on prod (since it's behind the beta)

mountiny

Thanks for testing and we can do more checks in staging/ production while this is behind beeta

github-actions · 2025-05-20T10:28:11Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.47-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

arosiclair · 2025-05-20T17:36:31Z

@mountiny this is ready for QA. Checking it off for now though since it's behind beta

github-actions · 2025-05-21T18:06:48Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.47-6 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-21T19:09:14Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.47-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-21T19:45:20Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.47-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Skalakid added 4 commits May 9, 2025 10:09

Fix getting card status on iOS

da0ef17

Update react-native-wallet library

f4ca787

Update Podfile

c247171

Refresh a card list when the card is added to the wallet

869e873

Skalakid added 3 commits May 13, 2025 08:24

Update package-lock.json

dccb887

Merge branch 'main' into @Skalakid/fix-getting-card-status-on-ios

39aa416

Merge branch '@zfurtak/introduce-wallet-to-expensify' into @Skalakid/…

c2000f0

…fix-getting-card-status-on-ios

mountiny assigned Skalakid May 13, 2025

mountiny added the InternalQA This pull request required internal QA label May 13, 2025

mountiny self-requested a review May 13, 2025 09:49

zfurtak and others added 8 commits May 13, 2025 12:36

Improve error handling

d7178f0

Fix iOS handleAddCardToWallet return type

8349d02

Update react-native-wallet library

2d31d49

Merge branch 'main' into @Skalakid/fix-getting-card-status-on-ios

3d3061f

Remove submodule change

54cf6c1

Update react-native-wallet library

9abd03b

Remove Podfile.lock changes

a1d9286

Update package-lock.json

4ec36b9

mountiny requested a review from brunovjk May 15, 2025 15:48

Skalakid marked this pull request as ready for review May 15, 2025 15:48

Skalakid requested a review from a team as a code owner May 15, 2025 15:48

melvin-bot bot requested review from mjasikowski and removed request for a team May 15, 2025 15:49

Remove useless check of wallet availability

6a457ca

brunovjk reviewed May 16, 2025

View reviewed changes

brunovjk approved these changes May 16, 2025

View reviewed changes

mountiny approved these changes May 20, 2025

View reviewed changes

mountiny merged commit 4bad6cd into Expensify:main May 20, 2025
22 checks passed

github-actions bot mentioned this pull request May 20, 2025

Deploy Checklist: New Expensify 2025-05-20 #62353

Closed

90 tasks

melvin-bot bot mentioned this pull request May 21, 2025

[Due for payment 2025-05-28] [Due for payment 2025-05-05] [Wallet] Only show the Add to Wallet button for OPEN state cards #60112

Closed

brunovjk mentioned this pull request Jul 1, 2025

[$1500] Create new library and native module react-native-wallet #36957

Closed

zfurtak deleted the @Skalakid/fix-getting-card-status-on-ios branch September 9, 2025 09:57

Conversation

Skalakid commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

mountiny commented May 15, 2025

Uh oh!

melvin-bot bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

Skalakid commented May 16, 2025

Uh oh!

mountiny commented May 16, 2025

Uh oh!

brunovjk commented May 16, 2025

Uh oh!

zfurtak commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunovjk commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Skalakid May 16, 2025

Choose a reason for hiding this comment

Uh oh!

brunovjk May 16, 2025

Choose a reason for hiding this comment

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

Skalakid commented May 16, 2025

Uh oh!

zfurtak commented May 19, 2025

Uh oh!

Skalakid commented May 19, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

arosiclair commented May 20, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Skalakid commented May 9, 2025 •

edited

Loading

zfurtak commented May 16, 2025 •

edited

Loading

brunovjk commented May 16, 2025 •

edited

Loading