Fix - Show Mark as incomplete button in ReportDetailsPage for non-owner task assignee#61786
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@FitseTLT I noticed that task does not get completed when I take test drive on the reports page. 12.05.2025_18.37.29_REC.mp4 |
Yeah @parasharrajat Unfortunately, there are cases it might not get completed. App/src/pages/Search/EmptySearchView.tsx Line 164 in 62de81e we only complete it if the task exists in onyx as we can only determine if it can be completed from the task report data. But if you clear cache or just signed in and didn't open the task report it will not be available in onyx to be completed. |
|
Android: There is an issue. Can you please fix that? 12.05.2025_20.27.29_REC.mp4 |
|
^ This is exactly the case I explained above. After switching to ND you only opened the concierge chat not the 2-min task report so it ( |
|
Ok, thanks for explaining. Then I see that we need to fix that too, as this isthe main issue and solution on this PR doesn't solve it completely. |
|
Are you working on this issue? @FitseTLT |
|
@carlosmiceli @parasharrajat With the current approach we cannot complete the 2-minute tour task when the taskReport doesn't exist in onyx like the case here where the user has just signed in but not opened the task report. App/src/pages/Search/EmptySearchView.tsx Line 164 in 62de81e but if the viewTourTaskReport doesn't exist we cannot determine that so the task will not be completed.Options to solve this: A. Just like we make tour task report id always available in introSelected?.viewTour we need to make task report data always available in introSelected or any other onyx key by making changes in BE.B. If we can't make BE changes then we can compromise and complete the tour task if it doesn't exist in onyx without checking if the user can complete it. At least we will send the complete tour task request and if the user can't complete it BE will send error like any other task but if the task is available in onyx we will make sure that the current user can complete the task before sending the request. WDYT |
|
I think I'd go with the quick fix for now so we remove the problem for users, and we can follow it up with a BE long term fix with less urgency. |
Yeah makes sense It is a very uncommon scenario and I think there is no much harm in the FE solution. |
|
Great, let's go with that. |
|
Done |
|
@FitseTLT Can you please merge main? |
|
Done |
|
Testing... |
|
After completing the task once, if we uncheck the task and try to complete again with that flag, it does not mark the task completed unless the report is loaded. So I am trying to understand why it works for the first time while report is still not loaded. Also, should it also be marked completed second time? |
|
What do you think about ti @FitseTLT ? |
How would you complete it again? We don't display the 2-min tour button if you have seen the tour App/src/pages/Search/EmptySearchView.tsx Line 154 in e5bac6e |
|
Yes, you are correct the Button hides but I was testing something. I want to understand how it works for the first time, I noticed that second time, the condition is not true. App/src/pages/Search/EmptySearchView.tsx Line 166 in e5bac6e Do you know what could be causing it to become false on second attempt? |
I don't know. |
|
@FitseTLT Please merge main to resolve conflicts. |
|
@parasharrajat This pr has removed the canAction and canModify conditions so our previous changes for two-minute tour is no more necessary only the report details change is needed. |
FitseTLT
changed the title
FitseTLT
changed the title
|
Sure, I will complete the testing shortly in few hours. |
Screenshots🔲 iOS / native28.05.2025_01.47.53_REC.mp428.05.2025_01.28.41_REC.mp4🔲 iOS / Safari28.05.2025_01.30.07_REC.mp4🔲 MacOS / Desktop28.05.2025_01.16.36_REC.mp4🔲 MacOS / Chrome15.05.2025_16.21.51_REC.mp4🔲 Android / Chrome28.05.2025_01.53.16_REC.mp4🔲 Android / native28.05.2025_01.49.52_REC.mp428.05.2025_01.51.27_REC.mp4 |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
@FitseTLT Can you please update the test steps to also cover original issue as we want QA to test that as well? |
|
done |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.53-0 🚀
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.53-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.1.53-7 🚀
|
4 participants
Details
Fixed Issues
$ #60402
PROPOSAL: #60402 (comment)
Tests
Create a new account and choose manage my expense flow
Select manage team flow
Click Reports
Click Take a test drive
Redirect to app and the Take a test-Drive task should be completed
As User A create a task and assign User B
As user B complete the task
Click on the task report header to open report details page
Verify Mark as incomplete button exists as User B on report details page.
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-05-09.17-26-43.mp4
Android: mWeb Chrome
2025-05-09.17-30-23.mp4
iOS: Native
2025-05-09.17-20-34.mp4
iOS: mWeb Safari
2025-05-09.17-22-20.mp4
MacOS: Chrome / Safari
2025-05-09.16-55-47.mp4
MacOS: Desktop
2025-05-09.16-58-05.mp4