[CP Staging] fix: search bar performance followup by daledah · Pull Request #61844 · Expensify/App

daledah · 2025-05-12T09:25:55Z

Explanation of Change

Fixed Issues

$ #61820
$ #61821
$ #61833
PROPOSAL:

Also improves performance for #61822, but it still needs more improvements

Tests

Test 1:
Precondition: Workspace has at least 16 members.

Go to staging.new.expensify.com
Go to workspace settings > Members.
Tap on the search field.
Enter any term that will not return any result.
Verify that: The intro text "Directory of all workspace members" does not disappear

Test 2:

Precondition: Workspace has imported a few per diem rates (5 per diem rates) (as long as per diem page is not scrollable).

Go to workspace settings.
Go to Per diem.
Verify that: There is no space between table header and content when there are a few per diem rates.

Test 3:

Go to workspace settings > Categories.
Long tap on any category.
Tap Select.
Tap on the search field.
Search for term that will not return any result.
Verify that: the selection mode is not turned off even if there's no search result

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test 1:
Precondition: Workspace has at least 16 members.

Go to staging.new.expensify.com
Go to workspace settings > Members.
Tap on the search field.
Enter any term that will not return any result.
Verify that: The intro text "Directory of all workspace members" does not disappear

Test 2:

Precondition: Workspace has imported a few per diem rates (5 per diem rates) (as long as per diem page is not scrollable).

Go to workspace settings.
Go to Per diem.
Verify that: There is no space between table header and content when there are a few per diem rates.

Test 3:

Go to workspace settings > Categories.
Long tap on any category.
Tap Select.
Tap on the search field.
Search for term that will not return any result.
Verify that: the selection mode is not turned off even if there's no search result

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-13.at.09.53.20.mov

Android: mWeb Chrome

Screen.Recording.2025-05-13.at.10.13.53.mov

iOS: Native

Screen.Recording.2025-05-13.at.10.16.57.mov

iOS: mWeb Safari

Screen.Recording.2025-05-13.at.10.18.38.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-13.at.10.19.11.mov

MacOS: Desktop

Screen.Recording.2025-05-13.at.10.20.07.mov

melvin-bot · 2025-05-13T02:37:59Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2025-05-13T02:38:02Z

@thesahindia PR is ready for review.

francoisl · 2025-05-13T02:41:17Z

Small note – I'm going to edit the OP to remove issue 61822 because it sounds like it still needs some further improvements based on #61822 (comment)

s77rt · 2025-05-13T03:13:31Z

👋 It's late here and I won't be able to give this a proper review now. Please reassign for urgency. Otherwise I'd review this tomorrow. Thanks!

daledah · 2025-05-13T03:21:12Z

@francoisl Please help assign @thesahindia, thanks!

thesahindia · 2025-05-13T06:52:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

https://github.com/user-attachments/assets/757d31b1-da0a-4bb5-8d2f-524f7c2b3784

Screen.Recording.2025-05-13.at.11.53.04.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-05-13.at.11.48.29.AM.mov

iOS: HybridApp

Screen.Recording.2025-05-13.at.12.16.11.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-05-13.at.11.45.51.AM.mov

MacOS: Desktop

Screen.Recording.2025-05-13.at.12.09.46.PM.mov

mountiny

One question for the useMemo removal - isnt that potentially going to cause worse performance?

mountiny · 2025-05-13T07:37:28Z

src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

    }, []);
    const sortRates = useCallback((rates: RateForList[]) => rates.sort((a, b) => (a.rate ?? 0) - (b.rate ?? 0)), []);
    const [inputValue, setInputValue, filteredDistanceRatesList] = useSearchResults(distanceRatesList, filterRate, sortRates);
-    const sections = useMemo(() => [{data: filteredDistanceRatesList, key: 'distanceRatesList'}], [filteredDistanceRatesList]);


Why should the useMemo not be used anymore?

It causes an extra rerender and caused a bug that I found when implementing #61656.

mountiny · 2025-05-13T07:42:02Z

Moving this ahead as we are quite far back with deploys

(cherry picked from commit 9268603) (cherry-picked to staging by mountiny)

github-actions · 2025-05-13T08:30:42Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.44-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-05-13T17:54:30Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-05-13T18:25:25Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-05-13T19:35:39Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-05-15T19:03:16Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: search bar performance followup

accc332

daledah mentioned this pull request May 12, 2025

[Due for payment 2025-05-20] [$250] Workspace - Intro text "Directory of all workspace members" disappears when there is no result #61820

Closed

8 tasks

This comment was marked as outdated.

Sign in to view

pecanoro mentioned this pull request May 12, 2025

[Due for payment 2025-06-09] [$125] Per diem - Degraded performance in Per diem page #61822

Closed

8 tasks

fix: slightly improve useSearchResult performance

711b9f1

pecanoro self-requested a review May 12, 2025 12:12

luacmartins mentioned this pull request May 12, 2025

[Due for payment 2025-05-20] Per diem - Huge space between table header and content when there are a few per diem rates #61821

Closed

8 tasks

daledah added 2 commits May 12, 2025 21:24

Merge branch 'main' into fix/61821

b4afdfc

fix: incorrect per diem sort

42eade5

francoisl mentioned this pull request May 13, 2025

Deploy Checklist: New Expensify 2025-05-07 #61626

Closed

90 tasks

daledah marked this pull request as ready for review May 13, 2025 02:37

daledah requested a review from a team as a code owner May 13, 2025 02:37

melvin-bot bot requested a review from s77rt May 13, 2025 02:37

melvin-bot bot removed the request for review from a team May 13, 2025 02:37

fix: typo

239405e

fix: app crash on native

13bc508

francoisl requested review from thesahindia and removed request for s77rt May 13, 2025 04:11

thesahindia approved these changes May 13, 2025

View reviewed changes

melvin-bot bot requested a review from yuwenmemon May 13, 2025 06:53

mountiny changed the title ~~fix: search bar performance followup~~ [CP Staging] fix: search bar performance followup May 13, 2025

mountiny approved these changes May 13, 2025

View reviewed changes

mountiny merged commit 9268603 into Expensify:main May 13, 2025
22 checks passed

OSBotify pushed a commit that referenced this pull request May 13, 2025

Merge pull request #61844 from daledah/fix/61821

bd6cbfa

(cherry picked from commit 9268603) (cherry-picked to staging by mountiny)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 13, 2025

github-actions bot mentioned this pull request May 13, 2025

Investigate workflow job failing on main: test / test (job 1) #61890

Closed

mountiny assigned daledah May 13, 2025

melvin-bot bot mentioned this pull request May 13, 2025

Categories - Selection mode exits when there is no search result #61833

Closed

8 tasks

mountiny mentioned this pull request May 14, 2025

Deploy Checklist: New Expensify 2025-05-13 #61917

Closed

Conversation

daledah commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment was marked as outdated.

melvin-bot bot commented May 13, 2025

Uh oh!

daledah commented May 13, 2025

Uh oh!

francoisl commented May 13, 2025

Uh oh!

s77rt commented May 13, 2025

Uh oh!

daledah commented May 13, 2025

Uh oh!

thesahindia commented May 13, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny May 13, 2025

Choose a reason for hiding this comment

Uh oh!

daledah May 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

daledah commented May 12, 2025 •

edited

Loading