[CP Staging] Update submodule to 6becb99cfb to unblock deploy#61896
Merged
[CP Staging] Update submodule to 6becb99cfb to unblock deploy#61896
Conversation
cristipaval
approved these changes
May 13, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
mountiny
added a commit
that referenced
this pull request
May 13, 2025
…994503759-1 🍒 Cherry pick PR #61896 to staging 🍒
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.45-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.45-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
We had some version mismatch for the App and udpated that manually but now the staging oldApp submodule points to old version of the code which leads to an issue with testflight
This is the diff from the existing staging version https://github.com/Expensify/Mobile-Expensify/compare/db762c467f06423f3e466c99cc30f815e777f5f3...6becb99cfb1288066f9cfa6a792ccc7520e1ef72
Seems like mainly just version bumps and noqa changes
Fixed Issues
$ https://expensify.slack.com/archives/C03V9A4TB/p1747124970829129
PROPOSAL:
Tests
Make sure the build works fine
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop