Fixed datepicker position on resize correctly by shubham1206agra · Pull Request #62354 · Expensify/App

shubham1206agra · 2025-05-20T10:19:06Z

Explanation of Change

Fixed Issues

$ #60241
PROPOSAL: #60241 (comment)

Tests

Open App
Log in with any account
Go to Setting > Profile
Click on Date of birth
Resize the window several times
Verify that the datepicker position is always correct.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-20.at.3.41.21.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-05-20.at.3.00.18.PM.mov

iOS: Native

Screen.Recording.2025-05-20.at.3.22.03.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-05-20.at.2.58.47.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-20.at.2.56.55.PM.mov

MacOS: Desktop

Screen.Recording.2025-05-20.at.3.03.37.PM.mov

melvin-bot · 2025-05-20T10:19:11Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-05-20T10:19:12Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-05-21T10:16:03Z

@shubham1206agra Could you take a look on failed github actions?

DylanDylann · 2025-05-21T10:18:07Z

src/components/DatePicker/index.tsx

+        InteractionManager.runAfterInteractions(() => {
+            calculatePopoverPosition();
+        });


Why don't we remove it as your proposal?

Actually, I noticed another bug when we removed this useEffect. Steps

Go to the narrow layout to open the datepicker.

Open the datepicker.

Go to the wider layout and notice the wrong position of the datepicker.

DylanDylann · 2025-05-27T04:10:50Z

@shubham1206agra Kindly bump

shubham1206agra · 2025-05-27T04:18:11Z

@DylanDylann Answered

DylanDylann · 2025-05-27T10:46:50Z

I see that the resizing has a significant delay when using runAfterInteractions function. @Expensify/design Tag the design team to hear their thoughts about this, is this acceptable?

Screen.Recording.2025-05-27.at.17.39.49.mov

dannymcclain · 2025-05-27T13:36:37Z

It's not great... Though I do think this is a pretty edge case interaction. Curious what the rest of the team thinks, but ideally it wouldn't be delayed so badly.

shubham1206agra · 2025-05-27T14:48:10Z

@dannymcclain If we don't delay changing the layout, it would pick the wrong values of anchor position, which was causing the bug.

shawnborton · 2025-05-27T16:20:49Z

Definitely don't love the delay, but agree that this is something we could live with given it's a bit edge-casey. Is there anything we can do to fix it though?

DylanDylann · 2025-05-28T05:19:07Z

@shubham1206agra Is there any update?

shubham1206agra · 2025-05-28T05:48:56Z

@shawnborton There is no fix to this. It is happening because too much is happening in the background, and we need to optimise the performance of the background to mitigate this lag, which is out of scope for this issue.

shawnborton · 2025-05-28T07:37:38Z

Got it, I think we'll just have to live with it then.

DylanDylann · 2025-05-28T08:12:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-05-28.at.15.06.05.mov

MacOS: Desktop

Screen.Recording.2025-05-28.at.15.06.05.mov

OSBotify · 2025-05-28T12:21:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-29T16:42:41Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.1.54-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-02T19:29:46Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.54-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Fixed datepicker position on resize correctly

558bf3a

shubham1206agra requested a review from a team as a code owner May 20, 2025 10:19

melvin-bot bot requested a review from DylanDylann May 20, 2025 10:19

melvin-bot bot removed the request for review from a team May 20, 2025 10:19

DylanDylann reviewed May 21, 2025

View reviewed changes

Merge branch 'Expensify:main' into fix-datepicker-resize

589b11c

DylanDylann approved these changes May 28, 2025

View reviewed changes

melvin-bot bot requested a review from techievivek May 28, 2025 08:12

techievivek assigned shubham1206agra May 28, 2025

techievivek approved these changes May 28, 2025

View reviewed changes

techievivek merged commit 7f840a5 into Expensify:main May 28, 2025
17 checks passed

This was referenced May 28, 2025

Investigate workflow job failing on main: prettier / Prettier check #62949

Closed

Deploy Checklist: New Expensify 2025-05-29 #63061

Closed

melvin-bot bot mentioned this pull request Jun 2, 2025

[Due for payment 2025-06-09] [$250] Web-The date picker pops out of its container when the window is resized #60241

Closed

8 tasks

shubham1206agra deleted the fix-datepicker-resize branch January 24, 2026 13:47

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 9] Needs more investigation/remaining usage of InteractionManager #83070

Open

Conversation

shubham1206agra commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 20, 2025

Uh oh!

melvin-bot bot commented May 20, 2025

Uh oh!

DylanDylann commented May 21, 2025

Uh oh!

DylanDylann May 21, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra May 27, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented May 27, 2025

Uh oh!

shubham1206agra commented May 27, 2025

Uh oh!

DylanDylann commented May 27, 2025

Uh oh!

dannymcclain commented May 27, 2025

Uh oh!

shubham1206agra commented May 27, 2025

Uh oh!

shawnborton commented May 27, 2025

Uh oh!

DylanDylann commented May 28, 2025

Uh oh!

shubham1206agra commented May 28, 2025

Uh oh!

shawnborton commented May 28, 2025

Uh oh!

DylanDylann commented May 28, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented May 28, 2025

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shubham1206agra commented May 20, 2025 •

edited

Loading