Fix - WS chat - "Remove hold" in details page #62665

FitseTLT · 2025-05-23T19:15:02Z

Details

Fixed Issues

$ #62394
PROPOSAL: #62394 (comment)

Tests

Create a workspace and connect it to an accounting (QBO), then go to WS chat
Create a manual expense
Press on the expense report header to open the details page
Verify that hold button doesn't exist in details page
Hold the report from the more button
Verify that unhold button doesn't exist in details page
Unhold the report from the more button
Approve it
Again check unapproved button doesn't exist in details page
Pay it
Check cancel payment, download as csv, and export buttons do not exist in details page (only in More button options)

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-05-23T19:15:07Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

This reverts commit 3a02dba.

hoangzinh · 2025-05-24T23:33:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-29.at.21.06.55.android.mov

Android: mWeb Chrome

Screen.Recording.2025-05-29.at.21.09.05.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-05-29.at.21.45.01.ios.mov

iOS: mWeb Safari

Screen.Recording.2025-05-29.at.21.12.26.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-29.at.20.48.19.web.mov

MacOS: Desktop

Screen.Recording.2025-05-29.at.21.00.27.desktop.mov

hoangzinh · 2025-05-25T08:20:20Z

@FitseTLT in step 6, should we clarify it to:

Verify that unhold button doesn't exist in report details page

hoangzinh · 2025-05-25T08:33:03Z

@FitseTLT can we clean up ConfirmModal as well?

App/src/pages/ReportDetailsPage.tsx

Lines 1069 to 1081 in 526a0e4

    
           {!canUseTableReportView && ( 
        
               <ConfirmModal 
        
                   title={translate('iou.cancelPayment')} 
        
                   isVisible={isConfirmModalVisible} 
        
                   onConfirm={cancelPayment} 
        
                   onCancel={() => setIsConfirmModalVisible(false)} 
        
                   prompt={translate('iou.cancelPaymentConfirmation')} 
        
                   confirmText={translate('iou.cancelPayment')} 
        
                   cancelText={translate('common.dismiss')} 
        
                   danger 
        
                   shouldEnableNewFocusManagement 
        
               /> 
        
           )}

…ls-page

FitseTLT · 2025-05-27T12:38:17Z

Proceed, Nice catch BTW

luacmartins

LGTM

hoangzinh · 2025-05-28T23:48:03Z

Ooops @FitseTLT Can you help resolve the conflict here? I can complete the checklist right after that

hoangzinh · 2025-05-28T23:54:25Z

@luacmartins will we also remove "Delete" expense in report details page?

luacmartins · 2025-05-28T23:55:32Z

Yes

…ls-page

FitseTLT · 2025-05-29T12:29:18Z

Delete option in more button doesn't occur in all cases the delele expense in details page exists (especially in non-beta). I think it is a bit out of scope.

2025-05-29.15-28-19.mp4

hoangzinh · 2025-05-29T14:47:37Z

Oops, there is another conflict @FitseTLT

…ls-page

FitseTLT · 2025-05-29T15:04:51Z

resolved

hoangzinh

LGTM

luacmartins · 2025-05-29T17:20:16Z

This looks good, but we should also remove the delete option. we can do that in a separate PR though, maybe after we merge this one #62997 so the conditions are correct.

OSBotify · 2025-05-29T17:30:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-02T19:56:28Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.55-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T12:51:19Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.56-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T20:03:44Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.58-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

hoangzinh · 2025-06-04T09:46:36Z

@FitseTLT ~~It looks like we should not remove "Export" option in the Report details page. This option is not in the "More" button yet~~ => false alarm, sorry 😮‍💨

cc @luacmartins

github-actions · 2025-06-04T16:19:58Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

removed duplicte actions

77d1b95

FitseTLT requested a review from a team as a code owner May 23, 2025 19:15

melvin-bot bot requested review from hoangzinh and removed request for a team May 23, 2025 19:15

FitseTLT added 3 commits May 23, 2025 23:17

fix errors

3a02dba

Revert "fix errors"

d7d4c9e

This reverts commit 3a02dba.

fix ts

83e3a44

FitseTLT added 2 commits May 27, 2025 15:27

Merge branch 'main' into fix-remove-duplicate-actions-in-report-detai…

b1f1e5e

…ls-page

Removed unnecessary code

d262d19

luacmartins previously approved these changes May 27, 2025

View reviewed changes

FitseTLT mentioned this pull request May 28, 2025

Expense - Logo next to cancel payment, is different on report and on details page #62939

Closed

8 tasks

Merge branch 'main' into fix-remove-duplicate-actions-in-report-detai…

a52cc49

…ls-page

FitseTLT dismissed luacmartins’s stale review via a52cc49 May 29, 2025 12:24

Merge branch 'main' into fix-remove-duplicate-actions-in-report-detai…

7ec4aec

…ls-page

hoangzinh approved these changes May 29, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins May 29, 2025 15:20

luacmartins approved these changes May 29, 2025

View reviewed changes

luacmartins merged commit 755e2ab into Expensify:main May 29, 2025
17 checks passed

github-actions bot mentioned this pull request Jun 2, 2025

Deploy Checklist: New Expensify 2025-06-02 #63263

Closed

BlameGPT mentioned this pull request Jun 3, 2025

[Due for payment 2025-06-12] [Due for payment 2025-06-11] Reports - "Approve" is not shown in LHN when user is second approver of a policy #63286

Closed

8 tasks

BlameGPT mentioned this pull request Jun 3, 2025

[Due for payment 2025-06-12] [Due for payment 2025-06-11] Reports - "Approve" button doesn´t disappear from expense preview of a held expense #63380

Closed

8 tasks

BlameGPT mentioned this pull request Jun 4, 2025

To-do-"Export" option is missing in Search LHN when the user is a prefferred exporter #63406

Closed

8 tasks

hoangzinh mentioned this pull request Jun 4, 2025

[Due for payment 2025-11-03] [$250] Accounting - Export option displays on Report header even when connection fails #62451

Closed

8 tasks

melvin-bot bot mentioned this pull request Jun 4, 2025

[Due for payment 2025-06-11] [$250] [Simplified actions] "Remove hold" button appearing in details of one expense report. #62394

Closed

8 tasks

Fix - WS chat - "Remove hold" in details page #62665

Fix - WS chat - "Remove hold" in details page #62665

Uh oh!

Conversation

FitseTLT commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 23, 2025

Uh oh!

hoangzinh commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented May 25, 2025

Uh oh!

hoangzinh commented May 25, 2025

Uh oh!

FitseTLT commented May 27, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented May 28, 2025

Uh oh!

hoangzinh commented May 28, 2025

Uh oh!

luacmartins commented May 28, 2025

Uh oh!

FitseTLT commented May 29, 2025

Uh oh!

hoangzinh commented May 29, 2025

Uh oh!

FitseTLT commented May 29, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented May 29, 2025

Uh oh!

Uh oh!

OSBotify commented May 29, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

hoangzinh commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FitseTLT commented May 23, 2025 •

edited

Loading

hoangzinh commented May 24, 2025 •

edited

Loading

hoangzinh commented Jun 4, 2025 •

edited

Loading