Fix test drive modal not moving when keyboard openes

[jmusial]

Explanation of Change

This PR reverts workaround from #62701 and implements fix in the new bottom docked modal. The root cause of this issue was how keyframe animations work in reanimated (they add a fixed height container for the Animated.View, and it was not adapting when keyboard was appearing in mWeb Chrome)

Fixed Issues

$ #62682
$ #49354

PROPOSAL:

N/A

Tests

1. Log in with a new Gmail account.
2. Tap Skip on work email page.
3. Select Track and budget expenses.
4. Enter name > Continue.
5. On "Take us for a test drive" modal, tap on the email field.
6. Verify the email field is visible after the keyboard is opened

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

fix_trainig_android_native.mov

Android: mWeb Chrome

fix_training_andorid_chrome.mov

iOS: Native

fix_training_ios_native.mp4

iOS: mWeb Safari

fix_training_ios_safari.mp4

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@shawnborton @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shawnborton]

cc @Expensify/design - I think this is fine, though I could have sworn we have a pattern where bottom-docked modals leave a little bit of space above them (for the status bar, etc), and then the modal content itself would scroll down. Does that sound right?

[dannymcclain]

I think this is fine, though I could have sworn we have a pattern where bottom-docked modals leave a little bit of space above them (for the status bar, etc), and then the modal content itself would scroll down. Does that sound right?

Yeah I definitely remember that as well. It's not terrible as is, but I'd love for all these to behave the same.

[shawnborton]

Can you take a look at that @jmusial? I think you can make a lot of saved searches on the mobile Reports page, and then you should see the bottom-docked scrolling behavior I am referencing. We might have it elsewhere too for other onboarding flows for all I know!

[ZhenjaHorbach]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-05-29.10.16.51.mov

Android: mWeb Chrome

2025-05-29.10.17.46.mov

iOS: HybridApp

2025-06-05.19.12.35.mov

iOS: mWeb Safari

2025-06-05.19.13.56.mov

MacOS: Chrome / Safari

2025-05-29.09.17.38.mov

MacOS: Desktop

2025-05-29.09.17.38.mov

[dubielzyk-expensify]

I think this is fine, though I could have sworn we have a pattern where bottom-docked modals leave a little bit of space above them (for the status bar, etc), and then the modal content itself would scroll down. Does that sound right?

Yeah I definitely remember that as well. It's not terrible as is, but I'd love for all these to behave the same.

Agreed. IOS looks a bit broken as is with the button being covered by the keyboard

[jmusial]

hey @shawnborton sure, I'll take a look

[ZhenjaHorbach]

@jmusial
We have prettier issues

[ZhenjaHorbach]

Android apps work good !

But on ios web noticed that
that we have an empty space under the modal that we can scroll
But I'm not sure if that it's a critical

2025-05-29.09.22.59.mov

And on ios we don't have modal animation when we open a keyboard
But it looks a bit jerky

2025-05-29.10.10.13.mov

[shawnborton]

that we have an empty space under the modal that we can scroll. But I'm not sure if that it's a critical

That seems like something we should fix. Same with the other feedback.

[jmusial]

I checked with the old modal and it seems the behaviour is the same there. Lack of modal animation is an issue for Android Native as well.

The empty space on IOS web is likely due to the difference of how keyboard is added on andorid web vs ios web.

But nontheless I'll try to fix those issues.

[ZhenjaHorbach]

@jmusial
We have prettier issue
And I suppose this PR is ready to review ?

[jmusial]

hey @ZhenjaHorbach, sorry got sidetracked on other issues.
Still need to figure out the empty space below keyboard on Safari on IOS, should be able to look @ that tomorrow

[jmusial]

@ZhenjaHorbach update on this PR - still trying to resolve ios/safari scroll bug. Some context

The problem

Safari overscrolls the content when keyboard is present. The blank space is not part of the html :( . Seems the issue is not fresh (and common enough to have medium articles written about it.

The cause

I managed to trace the problem and it's safari not supporting interactive-widget=resizes-content - prop that is responsible for adapting the viewport when keyboard is present. developer.chrome.com, SO

Unexpected find

Seems like staging build behaves different from dev -.-' @mountiny could you run ad hoc web build for me on this pr? I'd like to check if it's reproducible then. EDIT: OK seems, like this may be connected to the safari top bar coloring (white on staging, grey on dev). Hence the area below the modal seems gray on the videos @ZhenjaHorbach @shawnborton is the white space on ios safari ok ?

[jmusial]

Can you take a look at that @jmusial? I think you can make a lot of saved searches on the mobile Reports page, and then you should see the bottom-docked scrolling behavior I am referencing. We might have it elsewhere too for other onboarding flows for all I know!

Hey @shawnborton I was trying to identify the behaviour you're mentioning. Can it be that you're referring to modal behaving differently on other platforms ? Please see attached vids (none affected by this PRs' changes)

AFAIK the test drive modal is probably the only bottom docked modal with input (apart from emoji modal, but this one is smaller) causing the keyboard to show.

Test drive IOS native

ios_native_test_drive.mp4

Test drive IOS safari

ios_safari_test_drive.mp4

Saved searches IOS native

ios_native_saved_searches.mp4

Saved searches IOS safari

ios_safari_saved_searches.mp4

[shawnborton]

This is what I would expect in terms of scrolling, etc - let me know if this helps, and if this is possible!

CleanShot.2025-06-05.at.11.34.22.mp4

cc @Expensify/design to see if you agree as well.

[dubielzyk-expensify]

Great video to illustrate. Agree that the modal/sheet content itself should scroll.

[jmusial]

@shawnborton do you mind if I do it as a separate issue ? Changes in this brand do not introduce any regressions vs what is on prod

[shawnborton]

I am cool with that 👍

[dannymcclain]

100% agree with you Shawn!

[jmusial]

Cool, thx! @ZhenjaHorbach can you complete the review of the rest when you have time please ?
Can I create the issue myself or do you have to do it @shawnborton ?

[shawnborton]

Created an issue for you here: #63569

[ZhenjaHorbach]

Cool, thx! @ZhenjaHorbach can you complete the review of the rest when you have time please ?

Can I create the issue myself or do you have to do it @shawnborton ?

Nice
I will complete today !

[ZhenjaHorbach]

Okay
Everything looks good
Except this
But I suppose it will be fixed later !

LGTM !

[mountiny]

Thanks! Lets fix that issue in a follow up

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.63-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.63-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅