Name and message aligned in iOS + Focus Mode - Issue 6096 by sidferreira · Pull Request #6289 · Expensify/App

sidferreira · 2021-11-12T23:34:13Z

Details

On iOS + Focus Mode the message would not be aligned properly with the name if there was an emoji in the message.

Fixed Issues

$ #6096

Tests

Go to Preferences
Change to Focus mode
Be sure there's an emoji in the most recent message of the chat

QA Steps

...

Tested On

Screenshots

Platform	Focus Mode	Non Focus Mode
iOS
Android
Desktop
Web
MWeb

sidferreira · 2021-11-12T23:35:20Z

I have read the CLA Document and I hereby sign the CLA

tgolen · 2021-11-15T16:25:39Z

The original issue is still on hold, so I will wait on merging this until the hold is lifted.

sidferreira · 2021-11-15T16:56:30Z

@tgolen still not hired on upwork as well :D

sidferreira · 2021-11-15T16:56:51Z

closed by mistake (jumping ui)

parasharrajat · 2021-11-15T20:55:28Z

I think the message is not correctly vertically aligned.

Cc @shawnborton .

shawnborton · 2021-11-16T14:48:52Z

Agree, I think we want the baseline of each font to be aligned.

sidferreira · 2021-11-16T17:39:41Z

@shawnborton I'll look into it, but may be a bit trickier because of the emoji thing. Will update asap

parasharrajat · 2021-11-18T15:53:13Z

@sidferreira Please sign your commits. Unfortunately, it can't be merged without signing them.

sidferreira · 2021-11-18T23:08:55Z

@parasharrajat I think now it is working alright :)

parasharrajat · 2021-11-18T23:55:30Z

Will check later? AFK

sidferreira · 2021-11-25T04:07:23Z

@parasharrajat had the time to check this one?

parasharrajat · 2021-11-25T05:48:20Z

Sorry, I am not actively tracking this one as this one is not on my checklist. But I will do a review today.

src/styles/optionAlternateTextCompact/base.js

src/styles/styles.js

src/styles/optionAlternateTextCompact/index.ios.js

src/styles/optionAlternateTextCompact/base.js

src/styles/optionAlternateTextCompact/index.js

src/styles/styles.js

src/styles/optionAlternateTextCompact/index.ios.js

src/styles/optionAlternateTextPlatformStyles/index.js

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

tgolen

Oh, I like this solution much better!

sidferreira · 2021-12-03T02:58:02Z

@tgolen are we waiting for anything?

tgolen · 2021-12-03T16:50:50Z

I was waiting for @parasharrajat to approve since he also reviewed the code.

parasharrajat

Not tested on the platform but the code looks good. Sorry for keeping you waiting, I just reviewed to suggest improvement in the code.

parasharrajat · 2021-12-10T17:42:55Z

@toglen. If you feel this is good. I think we can merge this.

OSBotify · 2021-12-10T17:45:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-12-10T22:00:38Z

🚀 Deployed to staging by @tgolen in version: 1.1.19-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-12-20T12:09:22Z

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sidferreira requested a review from a team as a code owner November 12, 2021 23:34

MelvinBot requested review from tgolen and removed request for a team November 12, 2021 23:34

tgolen previously approved these changes Nov 15, 2021

View reviewed changes

sidferreira closed this Nov 15, 2021

sidferreira reopened this Nov 15, 2021

sidferreira dismissed tgolen’s stale review via a7543de November 18, 2021 17:34

sidferreira force-pushed the sidferreira/issue_6096 branch from c37873b to a7543de Compare November 18, 2021 17:34

Fix 6096 - Name and message aligned in iOS + Focus Mode

8f3028e

sidferreira force-pushed the sidferreira/issue_6096 branch from a7543de to 8f3028e Compare November 18, 2021 18:03

sidferreira added 2 commits November 18, 2021 14:53

Name + Focus Alignment: fine tune

269d19d

Name + Focus Alignment

40cef2f

sidferreira mentioned this pull request Nov 22, 2021

[HOLD for payment 2021-12-28] iOS - Emoji top is cut in LHN message preview #6390

Closed

sidferreira requested a review from tgolen November 28, 2021 03:11

tgolen approved these changes Nov 30, 2021

View reviewed changes

tgolen requested changes Nov 30, 2021

View reviewed changes

src/styles/optionAlternateTextCompact/base.js Outdated Show resolved Hide resolved

parasharrajat suggested changes Nov 30, 2021

View reviewed changes

src/styles/optionAlternateTextCompact/index.ios.js Outdated Show resolved Hide resolved

Inline Icons - review 6

447e0eb

sidferreira force-pushed the sidferreira/issue_6096 branch from 03d466e to 447e0eb Compare November 30, 2021 17:30

sidferreira requested review from parasharrajat and tgolen November 30, 2021 17:30

parasharrajat suggested changes Nov 30, 2021

View reviewed changes

src/styles/optionAlternateTextPlatformStyles/index.js Outdated Show resolved Hide resolved

Update src/styles/optionAlternateTextPlatformStyles/index.js

ee21d13

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

tgolen approved these changes Nov 30, 2021

View reviewed changes

parasharrajat approved these changes Dec 3, 2021

View reviewed changes

tgolen merged commit cc5e2d3 into Expensify:main Dec 10, 2021

sidferreira deleted the sidferreira/issue_6096 branch December 10, 2021 18:45

OSBotify mentioned this pull request Dec 10, 2021

Deploy Checklist: New Expensify 2021-12-10 #6703

Closed

38 tasks

sidferreira mentioned this pull request Dec 15, 2021

Issue 6390 - Fixes emoji positioning #6766

Merged

5 tasks

NicMendonca mentioned this pull request Dec 16, 2021

[HOLD for payment 2021-12-27] [$500] Message preview in focus mode is not aligned with user name #6096

Closed

Conversation

sidferreira commented Nov 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Uh oh!

sidferreira commented Nov 12, 2021

Uh oh!

tgolen commented Nov 15, 2021

Uh oh!

sidferreira commented Nov 15, 2021

Uh oh!

sidferreira commented Nov 15, 2021

Uh oh!

parasharrajat commented Nov 15, 2021

Uh oh!

shawnborton commented Nov 16, 2021

Uh oh!

sidferreira commented Nov 16, 2021

Uh oh!

parasharrajat commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidferreira commented Nov 18, 2021

Uh oh!

parasharrajat commented Nov 18, 2021

Uh oh!

sidferreira commented Nov 25, 2021

Uh oh!

parasharrajat commented Nov 25, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

sidferreira commented Dec 3, 2021

Uh oh!

tgolen commented Dec 3, 2021

Uh oh!

parasharrajat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Dec 10, 2021

Uh oh!

OSBotify commented Dec 10, 2021

Uh oh!

OSBotify commented Dec 10, 2021

Uh oh!

OSBotify commented Dec 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sidferreira commented Nov 12, 2021 •

edited

Loading

parasharrajat commented Nov 18, 2021 •

edited

Loading

parasharrajat left a comment •

edited

Loading