Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/CONST.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5178,12 +5178,10 @@ const CONST = {
REPLACE: 'REPLACE',
PUSH: 'PUSH',
NAVIGATE: 'NAVIGATE',
SET_PARAMS: 'SET_PARAMS',

/** These action types are custom for RootNavigator */
DISMISS_MODAL: 'DISMISS_MODAL',
OPEN_WORKSPACE_SPLIT: 'OPEN_WORKSPACE_SPLIT',
SET_HISTORY_PARAM: 'SET_HISTORY_PARAM',
},
},
TIME_PERIOD: {
Expand Down

This file was deleted.

2 changes: 0 additions & 2 deletions src/libs/Navigation/AppNavigator/customHistory/index.ts

This file was deleted.

18 changes: 0 additions & 18 deletions src/libs/Navigation/AppNavigator/customHistory/types.ts

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {StackRouter, useNavigationBuilder} from '@react-navigation/native';
import {NativeStackView} from '@react-navigation/native-stack';
import type {NativeStackNavigationEventMap, NativeStackNavigationOptions} from '@react-navigation/native-stack';
import React, {useMemo} from 'react';
import {addCustomHistoryRouterExtension} from '@libs/Navigation/AppNavigator/customHistory';
import convertToNativeNavigationOptions from '@libs/Navigation/PlatformStackNavigation/navigationOptions/convertToNativeNavigationOptions';
import type {
CreatePlatformStackNavigatorComponentOptions,
Expand All @@ -19,7 +18,7 @@ function createPlatformStackNavigatorComponent<RouterOptions extends PlatformSta
displayName: string,
options?: CreatePlatformStackNavigatorComponentOptions<RouterOptions>,
) {
const createRouter = addCustomHistoryRouterExtension(options?.createRouter ?? StackRouter);
const createRouter = options?.createRouter ?? StackRouter;
const defaultScreenOptions = options?.defaultScreenOptions;
const useCustomState = options?.useCustomState ?? (() => undefined);
const useCustomEffects = options?.useCustomEffects ?? (() => undefined);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {StackRouter, useNavigationBuilder} from '@react-navigation/native';
import type {StackNavigationEventMap, StackNavigationOptions} from '@react-navigation/stack';
import {StackView} from '@react-navigation/stack';
import React, {useMemo} from 'react';
import {addCustomHistoryRouterExtension} from '@libs/Navigation/AppNavigator/customHistory';
import convertToWebNavigationOptions from '@libs/Navigation/PlatformStackNavigation/navigationOptions/convertToWebNavigationOptions';
import type {
CreatePlatformStackNavigatorComponentOptions,
Expand All @@ -19,7 +18,7 @@ function createPlatformStackNavigatorComponent<RouterOptions extends PlatformSta
displayName: string,
options?: CreatePlatformStackNavigatorComponentOptions<RouterOptions>,
) {
const createRouter = addCustomHistoryRouterExtension(options?.createRouter ?? StackRouter);
const createRouter = options?.createRouter ?? StackRouter;
const useCustomState = options?.useCustomState ?? (() => undefined);
const defaultScreenOptions = options?.defaultScreenOptions;
const ExtraContent = options?.ExtraContent;
Expand Down
5 changes: 0 additions & 5 deletions src/libs/Navigation/linkingConfig/HISTORY_PARAM.ts

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions src/libs/Navigation/linkingConfig/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import NAVIGATORS from '@src/NAVIGATORS';
import ROUTES from '@src/ROUTES';
import type {Screen} from '@src/SCREENS';
import SCREENS from '@src/SCREENS';
import getHistoryParamParse from './helpers/getHistoryParamParse';
import HISTORY_PARAM from './HISTORY_PARAM';

// Moved to a separate file to avoid cyclic dependencies.
const config: LinkingOptions<RootNavigatorParamList>['config'] = {
Expand Down Expand Up @@ -323,7 +321,6 @@ const config: LinkingOptions<RootNavigatorParamList>['config'] = {
path: ROUTES.SETTINGS_DELEGATE_CONFIRM.route,
parse: {
login: (login: string) => decodeURIComponent(login),
...getHistoryParamParse(HISTORY_PARAM.SHOW_VALIDATE_CODE_ACTION_MODAL),
},
},
[SCREENS.SETTINGS.PROFILE.STATUS]: {
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion src/libs/Navigation/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2143,6 +2143,5 @@ export type {
TestDriveModalNavigatorParamList,
WorkspaceScreenName,
TestDriveDemoNavigatorParamList,
SetParamsAction,
WorkspacesTabNavigatorName,
};
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useState} from 'react';
import React, {useEffect, useState} from 'react';
import type {ValueOf} from 'type-fest';
import Button from '@components/Button';
import DelegateNoAccessWrapper from '@components/DelegateNoAccessWrapper';
Expand All @@ -13,7 +13,6 @@ import useLocalize from '@hooks/useLocalize';
import useNetwork from '@hooks/useNetwork';
import useThemeStyles from '@hooks/useThemeStyles';
import {formatPhoneNumber} from '@libs/LocalePhoneNumber';
import {useCustomHistoryParam} from '@libs/Navigation/AppNavigator/customHistory';
import Navigation from '@libs/Navigation/Navigation';
import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
import type {SettingsNavigatorParamList} from '@libs/Navigation/types';
Expand All @@ -25,17 +24,21 @@ import DelegateMagicCodeModal from './DelegateMagicCodeModal';

type ConfirmDelegatePageProps = PlatformStackScreenProps<SettingsNavigatorParamList, typeof SCREENS.SETTINGS.DELEGATE.DELEGATE_CONFIRM>;

function ConfirmDelegatePage({route}: ConfirmDelegatePageProps) {
function ConfirmDelegatePage({route, navigation}: ConfirmDelegatePageProps) {
const {translate} = useLocalize();

const styles = useThemeStyles();
const login = route.params.login;
const role = route.params.role as ValueOf<typeof CONST.DELEGATE_ROLE>;
const showValidateActionModal = route.params.showValidateActionModal === 'true';
const {isOffline} = useNetwork();
const [shouldDisableModalAnimation, setShouldDisableModalAnimation] = useState(true);
const [shouldShowLoading, setShouldShowLoading] = useState(showValidateActionModal ?? false);

const [isValidateCodeActionModalVisible, setIsValidateCodeActionModalVisible] = useCustomHistoryParam();
const [shouldShowLoading, setShouldShowLoading] = useState(isValidateCodeActionModalVisible ?? false);
const [isValidateCodeActionModalVisible, setIsValidateCodeActionModalVisible] = useState(showValidateActionModal ?? false);
useEffect(() => {
navigation.setParams({showValidateActionModal: String(isValidateCodeActionModalVisible)});
}, [isValidateCodeActionModalVisible, navigation]);

const personalDetails = getPersonalDetailByEmail(login);
const avatarIcon = personalDetails?.avatar ?? FallbackAvatar;
Expand Down Expand Up @@ -90,6 +93,7 @@ function ConfirmDelegatePage({route}: ConfirmDelegatePageProps) {
// We should disable the animation initially and only enable it when the user manually opens the modal
// to ensure it appears immediately when refreshing the page.
disableAnimation={shouldDisableModalAnimation}
shouldHandleNavigationBack
login={login}
role={role}
onClose={() => {
Expand Down
Loading