Skip to content

[CP Staging] Revert "Bulk hold"#63615

Merged
roryabraham merged 4 commits intomainfrom
revert-62329-BulkHold
Jun 6, 2025
Merged

[CP Staging] Revert "Bulk hold"#63615
roryabraham merged 4 commits intomainfrom
revert-62329-BulkHold

Conversation

@aldo-expensify
Copy link
Contributor

Reverts #62329

Fixes: #63614

@aldo-expensify aldo-expensify self-assigned this Jun 6, 2025
@aldo-expensify aldo-expensify requested a review from a team as a code owner June 6, 2025 02:24
@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team June 6, 2025 02:24
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2025

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@arosiclair arosiclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to fix conflicts first

@aldo-expensify
Copy link
Contributor Author

Lol, why is Jack the author of that revert commit? 🤷

image

I'm going to close this for now since we won't deploy today and ask Tony if they are planning to fix this today.

@aldo-expensify aldo-expensify reopened this Jun 6, 2025
@aldo-expensify
Copy link
Contributor Author

Resolved the conflict, it was easy this time

@aldo-expensify aldo-expensify requested a review from arosiclair June 6, 2025 17:59
@aldo-expensify
Copy link
Contributor Author

@arosiclair now you can review :)

@aldo-expensify aldo-expensify changed the title Revert "Bulk hold" [CP Staging] Revert "Bulk hold" Jun 6, 2025
@aldo-expensify aldo-expensify added the CP Staging marks PRs that have been CP'd to staging label Jun 6, 2025
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping checklists for revert

@roryabraham roryabraham merged commit cdca29f into main Jun 6, 2025
19 of 23 checks passed
@roryabraham roryabraham deleted the revert-62329-BulkHold branch June 6, 2025 19:32
@melvin-bot melvin-bot bot added the Emergency label Jun 6, 2025
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2025

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Jun 6, 2025
[CP Staging] Revert "Bulk hold"

(cherry picked from commit cdca29f)

(cherry-picked to staging by roryabraham)
@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@aldo-expensify
Copy link
Contributor Author

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.1.60-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.61-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.1.62-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.62-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging Emergency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expense - App crashes when holding expenses after taking test drive in Reports

5 participants