open Expensify Travel inside webview on native app by dukenv0307 · Pull Request #63625 · Expensify/App

dukenv0307 · 2025-06-06T08:54:16Z

Explanation of Change

Fixed Issues

$ #61733
PROPOSAL: #61733 (comment)

Tests

On an account that has travel enabled, click "Manage travel"

On mobile apps:
You should be brought to travel.expensify.com inside of a webview in the New Expensify app
On other platforms:
You should be brought to travel.expensify.com in a new browser tab

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-06-09.at.14.51.56.mov

Android: mWeb Chrome

Screen.Recording.2025-06-09.at.15.00.21.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-06-09.at.14.59.06.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-09.at.14.55.57.mov

MacOS: Desktop

Screen.Recording.2025-06-09.at.15.02.58.mov

melvin-bot · 2025-06-06T08:54:49Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable · 2025-06-06T16:35:42Z

How does this look on web/desktop?

AndrewGable · 2025-06-06T16:38:40Z

src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx


    const openTravel = useCallback(() => {
        if (isTravelEnabled) {
+            if (getPlatform() === CONST.PLATFORM.IOS || getPlatform() === CONST.PLATFORM.ANDROID) {


I think we want to avoid these type of checks

We did the same here:

App/src/pages/home/HeaderView.tsx

Line 130 in 10a7040

const isNativePlatform = getPlatform() === CONST.PLATFORM.IOS || getPlatform() === CONST.PLATFORM.ANDROID;

so I think that's fine

Please see the section titled Cross Platform 99.9999% in the README.md

BlameGPT · 2025-06-09T08:24:13Z

Suggested HelpDot changes for this PR

Details

The articles currently do not mention the new behavior of the Expensify Travel site opening inside the app on mobile devices, which is important for users to understand the updated user experience.

Article: new-expensify/travel/Book-with-Expensify-Travel

Edit 1:
Before:

Tap Book or manage travel.

After:

Tap Book or manage travel. On mobile devices, the Expensify Travel site will now open inside the app in a webview, keeping you within the Expensify app environment instead of opening an external browser.

Article: new-expensify/travel/Track-Travel-Analytics

Edit 2:
Before:

Click the + icon in the bottom left menu and select Book travel.

Click Book Travel.

Click the Analytics tab at the top of the screen.

After:

On mobile devices with travel enabled, tap Manage travel to open the Expensify Travel site within the app. On other platforms, clicking Manage travel will open the site in a new browser tab.

Click the Analytics tab at the top of the screen.

Article: new-expensify/travel/Edit-or-cancel-travel-arrangements

Edit 3:
Before:

You can review your travel arrangements any time by opening the Trip chat in your inbox. For example, if you booked a flight to San Francisco, a “Trip to San Francisco” chat will be automatically added to your chat inbox.

After:

You can review your travel arrangements any time by opening the Trip chat in your inbox. For example, if you booked a flight to San Francisco, a “Trip to San Francisco” chat will be automatically added to your chat inbox. On mobile devices, when you tap 'Manage travel', the Expensify Travel site will open within the app itself, providing a seamless experience without leaving Expensify.

Article: new-expensify/travel/Approve-travel-expenses

Edit 4:
Before:

Click the + icon in the bottom left menu and select Book travel.

Click Book or manage travel.

Click the Program tab at the top and select Policies.

Under General, select approval methods for Flights, Hotels, Cars and Rail.

After:

Click the + icon in the bottom left menu and select Book travel.

Click Book or manage travel. On mobile devices, this will now open the Expensify Travel site inside the app instead of an external browser.

Click the Program tab at the top and select Policies.

Under General, select approval methods for Flights, Hotels, Cars and Rail.

Please review the suggested changes and apply them if necessary.

dukenv0307 · 2025-06-10T09:14:10Z

It's ready for review again @c3024 @AndrewGable

AndrewGable · 2025-06-10T15:54:39Z

Thanks for applying feedback! Let me know when this is ready for our review @c3024

c3024 · 2025-06-11T14:51:08Z

src/libs/openTravelDotLink/index.native.ts

+            Navigation.navigate(ROUTES.TRAVEL_MY_TRIPS);
+        })
+        ?.catch(() => {
+            Navigation.navigate(ROUTES.TRAVEL_MY_TRIPS);


We have error messages in the rejections of the Promise of getTravelDotLink. Perhaps, we can log them here.

@dukenv0307 - Thoughts here? Would they be helpful to log here?

Thank you @c3024 @AndrewGable. I updated

c3024 · 2025-06-11T14:55:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

spontanaAndroid.mov

Android: mWeb Chrome

spontanaAndroidmWeb.mov

iOS: HybridApp

spontanaiOS.mov

iOS: mWeb Safari

spontanaiOSmWeb.mov

MacOS: Chrome / Safari

spontanaChrome.mov

MacOS: Desktop

spontanaDesktop.mov

c3024

LGTM!

OSBotify · 2025-06-12T23:25:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-16T11:10:22Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.1.67-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

github-actions · 2025-06-17T17:16:44Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.67-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

open Expensify Travel inside webview on native app

d0f45cb

dukenv0307 marked this pull request as ready for review June 6, 2025 08:54

dukenv0307 requested a review from a team as a code owner June 6, 2025 08:54

melvin-bot bot requested a review from c3024 June 6, 2025 08:54

melvin-bot bot removed the request for review from a team June 6, 2025 08:54

AndrewGable reviewed Jun 6, 2025

View reviewed changes

stitesExpensify self-requested a review June 9, 2025 21:20

dukenv0307 added 3 commits June 10, 2025 15:43

Merge branch 'main' into fix/61733

90c8541

refactor

33709e0

lint fix

1b50f8d

c3024 reviewed Jun 11, 2025

View reviewed changes

c3024 approved these changes Jun 11, 2025

View reviewed changes

dukenv0307 added 3 commits June 12, 2025 09:39

Merge branch 'main' into fix/61733

5c9dee6

log error message

2059ea1

log error

8063c06

AndrewGable approved these changes Jun 12, 2025

View reviewed changes

AndrewGable merged commit 36fde9a into Expensify:main Jun 12, 2025
17 checks passed

github-actions bot mentioned this pull request Jun 16, 2025

Deploy Checklist: New Expensify 2025-06-16 #64227

Closed

48 tasks

melvin-bot bot mentioned this pull request Jun 17, 2025

[Due for payment 2025-07-22] [Due for payment 2025-06-24] [$250] Open Expensify Travel inside of a webview instead of a browser tab on mobile only #61733

Closed

16 tasks

rlinoz mentioned this pull request Jun 24, 2025

[CP Staging+Prod] Revert "open Expensify Travel inside webview on native app" #64809

Merged

49 tasks

Conversation

dukenv0307 commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 6, 2025

Uh oh!

AndrewGable commented Jun 6, 2025

Uh oh!

AndrewGable Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

AndrewGable Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

AndrewGable Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

BlameGPT commented Jun 9, 2025

Suggested HelpDot changes for this PR

Article: new-expensify/travel/Book-with-Expensify-Travel

Article: new-expensify/travel/Track-Travel-Analytics

Article: new-expensify/travel/Edit-or-cancel-travel-arrangements

Article: new-expensify/travel/Approve-travel-expenses

Uh oh!

dukenv0307 commented Jun 10, 2025

Uh oh!

AndrewGable commented Jun 10, 2025

Uh oh!

c3024 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

AndrewGable Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dukenv0307 commented Jun 6, 2025 •

edited

Loading

AndrewGable Jun 9, 2025 •

edited

Loading

c3024 commented Jun 11, 2025 •

edited

Loading