Simplify react-native-web fork usage#6363
Closed
kidroca wants to merge 4 commits intoExpensify:mainfrom
Closed
Conversation
Contributor
Author
|
Results:
|
Contributor
Author
|
It was decided against using patch-package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Instead of installing all
react-native-webdependencies and then build the whole package every timenpm installruns we can just apply the patch witch the changes throughpatch-packageRelated to this slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1636047163494200
Fixed Issues
$ N/A
Tests
The same steps listed in this PR: #6268
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android