Migrate ReportAttachments screen to AttachmentModalScreen

[chrispader]

@mountiny @parasharrajat

Explanation of Change

This PR builds on #56219 and migrates the ReportAttachments screen which uses AttachmentModal component to use AttachmentModalScreen instead.

The screen handles the different appearance on web vs. native. For each of the different modal types ("report attachment", "profile avatar", "workspace avatar", ...) there is a specific content component.

Fixed Issues

$ #53493
PROPOSAL: #56219 (comment)

Tests

• Verify that no errors appear in the JS console

Go to all flows that show attachments and and check if

• on web the attachment is visible in the "overlay"-style modal,
• on native platforms, there is a regular screen animation with the attachment on a new screen.

Following flows to test:

• Report attachment: Open an image/attachment from a chat
• Workspace avatar: Open the workspace avatar image
• Profile avatar: Open the profile avatar image
• Transaction Receipt: Open the receipt of a transaction
• Send attachment: Upload a new attachment to the chat and check if the preview works

Offline tests

Not needed.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

Same as in Tests.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen_Recording_20250207_004027_New.Expensify.Dev.mp4

Screen_Recording_20250207_004044_New.Expensify.Dev.mp4

Screen_Recording_20250207_003937_New.Expensify.Dev.mp4

Screen_Recording_20250207_004006_New.Expensify.Dev.2.mp4

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-06.at.16.32.44.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-06.at.16.32.30.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-03.at.11.26.24.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-06.at.16.32.17.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-06.at.16.33.13.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-02-06.at.16.38.14.mov

Screen.Recording.2025-02-06.at.16.37.58.mov

Screen.Recording.2025-02-06.at.16.37.32.mov

Screen.Recording.2025-02-06.at.16.37.47.mov

Screen.Recording.2025-02-06.at.16.36.50.mov

MacOS: Desktop

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

@chrispader instead of doing all the modals at once, could we just migrate one modal and see if QA will find issues that we could address on that modal and check if it will happen for others?

I think it would be safer to do it more peacemeal

[chrispader]

@parasharrajat @mountiny just merged main and the base PR. Once we've tested this PR, it should be ready to merge! 🙌🏼

[chrispader]

@chrispader instead of doing all the modals at once, could we just migrate one modal and see if QA will find issues that we could address on that modal and check if it will happen for others?

I think it would be safer to do it more peacemeal

@Expensify/marketing yes, i can reduce the scope of the PR to just the ReportAttachments attachment modal? And then open up another PR with the remaining/current changes. Do you want me to do that?

[mountiny]

Yes Lets just the the report attachment for now, I am sure marketting team agrees! Thanks

@parasharrajat @chrispader can you make sure to test videos properly in the attachment modal too?

[chrispader]

@parasharrajat @mountiny this PR should be ready

[chrispader]

So the PR changes looks good but I don't see exit animation for attachments on Mobile chrome and iOS Safari mobile. @chrispader

@parasharrajat this should be fixed now!

[mountiny]

More conflicts

[chrispader]

More conflicts

@mountiny @parasharrajat merge conflicts resolved!

[chrispader]

@mountiny @parasharrajat i'm going to be mostly OOO from 06/29-08/01 with ~5-10h availability per week, so it would be great if we could get this merged until then! 🙌🏼

[parasharrajat]

Sure, I am reviewing it now.

[parasharrajat]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

[parasharrajat]

Screenshots

🔲 iOS / native

20.06.2025_19.50.14_REC.mp4

🔲 iOS / Safari

20.06.2025_20.17.31_REC.mp4

🔲 MacOS / Desktop

20.06.2025_20.19.15_REC.mp4

🔲 MacOS / Chrome

20.06.2025_19.08.28_REC.mp4

🔲 Android / Chrome

20.06.2025_20.14.32_REC.mp4

🔲 Android / native

20.06.2025_20.12.10_REC.mp4

[chrispader]

@parasharrajat great thanks for the review! @mountiny is this ready to merge? 🙌🏼

[mountiny]

Busy at the company event, we merged quite big changes just now so I would prefer to wait with this one until monday

[chrispader]

Busy at the company event, we merged quite big changes just now so I would prefer to wait with this one until monday

@mountiny sure! I'll be available for final merge and potential merge conflicts. Happy #F1Shore! 🏎️

[mountiny]

changes are looking good to me, thank you!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[IuliiaHerets]

@chrispader @parasharrajat @mountiny Can you please add QA steps here?

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.73-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[mountiny]

Following flows to test:

Report attachment: Open an image/attachment from a chat

1. Open a report with attachment
2. Open the attachment
3. Make sure the modal shows as overlay same as on production
4. On native, make sure the modal navigates in same as any other screen and the image is showing without issues

Workspace avatar: Open the workspace avatar image

1. Go to Workspaces
2. Select a workspace with avatar
3. Go to Overview
4. Open the workspace avatar
5. Ensure the modal with the avatar shows the same as in production

Profile avatar: Open the profile avatar image

1. Go to account settings
2. Profile
3. View your profile avatar
4. Make sure the modal shows on your screen same as in production
5. On native the modal screen with the profile avatar image should animate in same as any other screen

Transaction Receipt: Open the receipt of a transaction

1. Create an expense with a receipt
2. Navigate to the transaction thread for that expense
3. Open the receipt image
4. Make sure the image shows in the modal on desktop same as in production
5. On native, make sure the screen with the modal navigates in

Send attachment: Upload a new attachment to the chat and check if the preview works

1. Go to some report
2. Choose send the attachement
3. Choose some image from gallery
4. Make sure the modal with the image shows the same as in production
5. On native, the modal should show up same as any other screen with push animation

[github-actions]

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.73-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[mountiny]

Noted in Slack, but noting here https://expensify.slack.com/archives/C01GTK53T8Q/p1751389124554439?thread_ts=1751388254.561569&cid=C01GTK53T8Q as well

The receipt and workspace avatars animations are not working for the native