[No QA] Update botify workflows to use new signing key #6374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
AndrewGable
reviewed
Nov 19, 2021
| - name: Set up git for Botify | ||
| if: github.actor == 'OSBotify' | ||
| run: | | ||
| git config user.signingkey DBF63700F60F5530 |
Contributor
There was a problem hiding this comment.
Does this signingkey need to be stored as an environment variable?
Contributor
There was a problem hiding this comment.
Nope, it's a public key ID and exposed by the GitHub UI when you click on Verified
Co-authored-by: Andrew Gable <andrew@expensify.com>
AndrewGable
approved these changes
Nov 19, 2021
Contributor
|
Skipping E2E tests to unblock CPs. |
|
@AndrewGable looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Contributor
Contributor
|
🚀 Deployed to staging by @AndrewGable in version: 1.1.15-18 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
#6371 fixed the issue with the createNewVersion workflow, but the cherry-pick workflow failed. This PR updates all botify flows that push to git to use the updated signing key.
A future improvement here would be to create a separate workflow to handle setting up the git config for botify to reduce duplicate code, so once CPs are fixed we can create a follow-up issue to do that.
Fixed Issues
Fixes broken GH action
Tests
Merge and CP this, confirm the workflow is successful and that the commits are signed.
QA Steps
None
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android