[No QA] Update Create-a-company-workspace.md#63890
Conversation
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @NicMendonca |
|
@grgia @NicMendonca One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://c2f00aef.helpdot.pages.dev ⚡️ |
|
@adelekennedy you need to do this: #63890 (comment) |
|
Weird: |
|
@twisterdotcom looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
This is just a help page that I reviewed. Test failed because I did the PR reviewer checklist instead of Nicole. |
|
@adelekennedy @grgia @twisterdotcom Do we have any QA steps here? |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.1.65-0 🚀
|
|
No QA needed, sorry. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.65-1 🚀
|
Explanation of Change
a candidate actually noticed here that we had a typo on our helpsite, we had an extra /b>
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined