feat: Add Auto-Submit educational modal and add beta for auto-submit feature by ishpaul777 · Pull Request #63893 · Expensify/App

ishpaul777 · 2025-06-10T22:48:44Z

Explanation of Change

Fixed Issues

$ #63195
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Navigate to/auto-submit verify this modal appears, without "do not show again" checkbox

Navigate again to/auto-submit verify this modal appears, with "do not show again" checkbox
click on do not show checkbox and click dismiss it.
Navigate again to /auto-submit verify this modal appears without checkbox

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Header	Header

Screen.Recording.2025-06-11.at.9.51.58.PM.mov

MacOS: Desktop

Screen.Recording.2025-06-12.at.1.49.52.AM.mov

- Add AutoSubmitModal component with proper styling and structure - Update navigation to use FeatureTrainingModalNavigator - Add translations for English and Spanish - Add necessary constants and keys - Update permissions - Clean up unused files and types - Fix modal styling to match design specs

melvin-bot · 2025-06-11T15:53:31Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-06-11T15:55:25Z

@akinwale this is ready for review just demo videos remaining i'll finish it in sometime but that should not block your review. you can start, Thanks!

garrettmknight · 2025-06-11T17:17:31Z

cc @Beamanator

src/ONYXKEYS.ts

src/components/AutoSubmitModal.tsx

ishpaul777 · 2025-06-11T22:32:17Z

src/languages/es.ts

+    autoSubmitModal: {
+        title: 'Envío Automático de Gastos',
+        description: 'Envío Automático de Gastos ayuda a ahorrar tiempo enviando tus gastos por ti.',
+        submittedExpensesTitle: 'Gastos Enviados',
+        submittedExpensesDescription: 'Gastos que han sido enviados automáticamente por ti.',
+        pendingExpensesTitle: 'Gastos Pendientes',
+        pendingExpensesDescription: 'Gastos en espera de ser enviados automáticamente.',
+    },


asked confimation on slack

akinwale · 2025-06-12T05:54:26Z

@ishpaul777 Code looks good so far. Please fix the lint errors.

ishpaul777 · 2025-06-12T10:14:41Z

typescript failing on main also, rest all done! @akinwale

akinwale · 2025-06-12T11:23:36Z

@ishpaul777 When I click on the Got it button with the checkbox not displayed initially, the checkbox flickers for a brief moment before the modal is dismissed. This shouldn't be happening.

63893-web.mp4

akinwale · 2025-06-12T12:19:31Z

@ishpaul777 The TypeScript error has been fixed on the latest main, so please merge with that as well.

ishpaul777 · 2025-06-12T13:24:08Z

@ishpaul777 When I click on the Got it button with the checkbox not displayed initially, the checkbox flickers for a brief moment before the modal is dismissed. This shouldn't be happening.

fixed

Screen.Recording.2025-06-12.at.6.51.37.PM.mov

akinwale · 2025-06-12T16:43:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

63893-web.mp4

MacOS: Desktop

63893-desktop.mp4

akinwale

LGTM.

Beamanator

Looking great except the comment styles above NVP_DISMISSED_INSTANT_SUBMIT_EXPLANATION 🙏

ishpaul777 · 2025-06-12T19:49:34Z

@Beamanator done!

Beamanator

LGTM!

OSBotify · 2025-06-13T02:53:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

parasharrajat · 2025-06-13T21:42:42Z

src/libs/Permissions.ts

    canUseLinkPreviews,
    isBlockedFromSpotnanaTravel,
    isBetaEnabled,
+    canUseAutoSubmit,


This is the wrong way to add beta. We should be using isBetaEnabled for this. Can you please create a followup pr to fix it.

Thanks for catching that, i'll include fix in a incoming PR for project, its currently unused and will be till the next PR

github-actions · 2025-06-16T11:10:55Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.1.67-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

github-actions · 2025-06-17T17:17:16Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.67-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ishpaul777 and others added 9 commits June 11, 2025 04:07

remove unnecessary file

30301bc

formatting

ec9c8d0

remove navigator

e48e8ab

remove unnecessary file

5811816

design changes

9092dee

Merge branch 'Expensify:main' into auto-submit-modal

980ca77

design minor changes

6a10ad6

fix line height

5918a4b

ishpaul777 marked this pull request as ready for review June 11, 2025 15:53

ishpaul777 requested review from a team as code owners June 11, 2025 15:53

melvin-bot bot requested review from akinwale and removed request for a team June 11, 2025 15:53

fix native device image dimensions

c22ce71

Beamanator reviewed Jun 11, 2025

View reviewed changes

src/ONYXKEYS.ts Outdated Show resolved Hide resolved

Beamanator reviewed Jun 11, 2025

View reviewed changes

src/components/AutoSubmitModal.tsx Outdated Show resolved Hide resolved

ishpaul777 added 3 commits June 12, 2025 00:26

fix lint

d6412d2

review changes

4ab4774

spanish translation (not confirmed)

377279a

ishpaul777 commented Jun 11, 2025

View reviewed changes

chnages as per review

c841e99

Merge branch 'Expensify:main' into auto-submit-modal

772ab5b

fix flickering bug

0565d8e

akinwale approved these changes Jun 12, 2025

View reviewed changes

melvin-bot bot requested a review from Beamanator June 12, 2025 16:43

Beamanator reviewed Jun 12, 2025

View reviewed changes

fix comment

a7d6a4c

ishpaul777 requested a review from Beamanator June 12, 2025 20:03

Beamanator approved these changes Jun 13, 2025

View reviewed changes

Beamanator merged commit ff974c6 into Expensify:main Jun 13, 2025
19 checks passed

parasharrajat reviewed Jun 13, 2025

View reviewed changes

github-actions bot mentioned this pull request Jun 16, 2025

Deploy Checklist: New Expensify 2025-06-16 #64227

Closed

48 tasks

melvin-bot bot mentioned this pull request Jun 17, 2025

[Due for payment 2025-06-24] [Auto-Submit] Create the new Beta, NVP and Modal #63195

Closed

blazejkustra mentioned this pull request Feb 20, 2026

[$250] [BATCH 1] Migrate ConfirmModals & ReanimatedModals #83061

Open

Conversation

ishpaul777 commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 11, 2025

Uh oh!

ishpaul777 commented Jun 11, 2025

Uh oh!

garrettmknight commented Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

ishpaul777 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

akinwale commented Jun 12, 2025

Uh oh!

ishpaul777 commented Jun 12, 2025

Uh oh!

akinwale commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akinwale commented Jun 12, 2025

Uh oh!

ishpaul777 commented Jun 12, 2025

Uh oh!

akinwale commented Jun 12, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Jun 12, 2025

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 13, 2025

Uh oh!

parasharrajat Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ishpaul777 commented Jun 10, 2025 •

edited

Loading

akinwale commented Jun 12, 2025 •

edited

Loading

ishpaul777 Jun 13, 2025 •

edited

Loading