Skip to content

Fix - Remove "Try a test receipt" tooltip for migrated users #64084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 4 commits into from
Jun 19, 2025
Merged

Fix - Remove "Try a test receipt" tooltip for migrated users #64084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
816dc69
hide scan test tooltip for migrated users
FitseTLT Jun 12, 2025
b5ba747
Merge branch 'main' into fix-avoid-scan-test-tooltip-for-migrated-users
FitseTLT Jun 12, 2025
d269048
Merge branch 'main' into fix-avoid-scan-test-tooltip-for-migrated-users
FitseTLT Jun 13, 2025
18bfea7
resolve conflict
FitseTLT Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/ProductTrainingContext/TOOLTIPS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const TOOLTIPS: Record<ProductTrainingTooltipName, TooltipData> = {
onHideTooltip: () => dismissProductTraining(SCAN_TEST_TOOLTIP),
name: SCAN_TEST_TOOLTIP,
priority: 900,
shouldShow: () => true,
shouldShow: ({hasBeenAddedToNudgeMigration}) => !hasBeenAddedToNudgeMigration,
shouldRenderActionButtons: true,
},
[SCAN_TEST_TOOLTIP_MANAGER]: {
Expand All @@ -150,7 +150,7 @@ const TOOLTIPS: Record<ProductTrainingTooltipName, TooltipData> = {
onHideTooltip: (isDismissedUsingCloseButton = false) => dismissProductTraining(SCAN_TEST_TOOLTIP_MANAGER, isDismissedUsingCloseButton),
name: SCAN_TEST_TOOLTIP_MANAGER,
priority: 1000,
shouldShow: () => true,
shouldShow: ({hasBeenAddedToNudgeMigration}) => !hasBeenAddedToNudgeMigration,
},
[SCAN_TEST_CONFIRMATION]: {
content: [
Expand All @@ -161,7 +161,7 @@ const TOOLTIPS: Record<ProductTrainingTooltipName, TooltipData> = {
onHideTooltip: (isDismissedUsingCloseButton = false) => dismissProductTraining(SCAN_TEST_CONFIRMATION, isDismissedUsingCloseButton),
name: SCAN_TEST_CONFIRMATION,
priority: 1100,
shouldShow: () => true,
shouldShow: ({hasBeenAddedToNudgeMigration}) => !hasBeenAddedToNudgeMigration,
},
[OUTSTANDING_FILTER]: {
content: [
Expand Down
5 changes: 4 additions & 1 deletion src/pages/iou/request/MoneyRequestParticipantsSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ function MoneyRequestParticipantsSelector({
const isPaidGroupPolicy = useMemo(() => isPaidGroupPolicyUtil(policy), [policy]);
const isIOUSplit = iouType === CONST.IOU.TYPE.SPLIT;
const isCategorizeOrShareAction = [CONST.IOU.ACTION.CATEGORIZE, CONST.IOU.ACTION.SHARE].some((option) => option === action);
const [tryNewDot] = useOnyx(ONYXKEYS.NVP_TRY_NEW_DOT, {canBeMissing: true});
const hasBeenAddedToNudgeMigration = !!tryNewDot?.nudgeMigration?.timestamp;

const importAndSaveContacts = useCallback(() => {
contactImport().then(({contactList, permissionStatus}: ContactImportResult) => {
Expand Down Expand Up @@ -179,7 +181,7 @@ function MoneyRequestParticipantsSelector({
shouldSeparateSelfDMChat: iouType !== CONST.IOU.TYPE.INVOICE,
shouldSeparateWorkspaceChat: true,
includeSelfDM: !isMovingTransactionFromTrackExpense(action) && iouType !== CONST.IOU.TYPE.INVOICE,
canShowManagerMcTest: action !== CONST.IOU.ACTION.SUBMIT,
canShowManagerMcTest: !hasBeenAddedToNudgeMigration && action !== CONST.IOU.ACTION.SUBMIT,
isPerDiemRequest,
},
);
Expand All @@ -202,6 +204,7 @@ function MoneyRequestParticipantsSelector({
options.reports,
participants,
isPerDiemRequest,
hasBeenAddedToNudgeMigration,
]);

const chatOptions = useMemo(() => {
Expand Down
1 change: 0 additions & 1 deletion tests/ui/components/ProductTrainingContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ describe('ProductTrainingContextProvider', () => {
it('should hide tooltip when hideProductTrainingTooltip is called', async () => {
// When migrated user has dismissed welcome modal
Onyx.merge(ONYXKEYS.NVP_ONBOARDING, {hasCompletedGuidedSetupFlow: true});
Onyx.merge(ONYXKEYS.NVP_TRY_NEW_DOT, {nudgeMigration: {timestamp: new Date()}});
const date = new Date();
Onyx.set(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, {
migratedUserWelcomeModal: {
Expand Down
Loading