Skip to content

Fix moved expense report title display in LHN #64137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mollfpr merged 1 commit into from
Jun 13, 2025
Merged

Fix moved expense report title display in LHN #64137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libs/OptionsListUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ import {
isMarkAsClosedAction,
isModifiedExpenseAction,
isMoneyRequestAction,
isMovedTransactionAction,
isOldDotReportAction,
isPendingRemove,
isReimbursementDeQueuedOrCanceledAction,
Expand All @@ -97,6 +98,7 @@ import {
getDowngradeWorkspaceMessage,
getIcons,
getMoneyRequestSpendBreakdown,
getMovedTransactionMessage,
getParticipantsAccountIDsForDisplay,
getPolicyChangeMessage,
getPolicyName,
Expand Down Expand Up @@ -776,6 +778,8 @@ function getLastMessageTextForReport(
} else if (isModifiedExpenseAction(lastReportAction)) {
const properSchemaForModifiedExpenseMessage = ModifiedExpenseMessage.getForReportAction({reportOrID: report?.reportID, reportAction: lastReportAction});
lastMessageTextFromReport = formatReportLastMessageText(properSchemaForModifiedExpenseMessage, true);
} else if (isMovedTransactionAction(lastReportAction)) {
lastMessageTextFromReport = getMovedTransactionMessage(lastReportAction);
} else if (isTaskAction(lastReportAction)) {
lastMessageTextFromReport = formatReportLastMessageText(getTaskReportActionMessage(lastReportAction).text);
} else if (isCreatedTaskReportAction(lastReportAction)) {
Expand Down
5 changes: 5 additions & 0 deletions src/libs/ReportActionsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ function isModifiedExpenseAction(reportAction: OnyxInputOrEntry<ReportAction>):
return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.MODIFIED_EXPENSE);
}

function isMovedTransactionAction(reportAction: OnyxInputOrEntry<ReportAction>): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION> {
return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION);
}

function isPolicyChangeLogAction(reportAction: OnyxInputOrEntry<ReportAction>): reportAction is ReportAction<ValueOf<typeof CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG>> {
return reportAction?.actionName ? POLICY_CHANGE_LOG_ARRAY.has(reportAction.actionName) : false;
}
Expand Down Expand Up @@ -2992,6 +2996,7 @@ export {
isMessageDeleted,
useNewTableReportViewActionRenderConditionals,
isModifiedExpenseAction,
isMovedTransactionAction,
isMoneyRequestAction,
isNotifiableReportAction,
isOldDotReportAction,
Expand Down