Bump: @react-navigation and react-native-screens to the newest versions#64155
Conversation
|
The conflicts have been resolved! |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
Kicked of the builds for fresh tests @allgandalf |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
lemme give it a test! @staszekscp have you also tested on the latest adhocs ? |
|
@allgandalf I tested all with the newest main locally, and apart from that iOS and web on the generated adhocs |
|
All the adhoc build seem to be working just fine! Waiting for a move 😄 |
|
all yours @mountiny |
|
Hey @mountiny! Since we're all set could I ask for the magical merge press? 😄 |
mountiny
left a comment
There was a problem hiding this comment.
Thanks for your patience given the company event, lets be on a look out for regressions from this. If there would be many we will have to revert
|
Merging together with https://github.com/Expensify/Mobile-Expensify/pull/13597 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@staszekscp @mountiny Could you provide little more details on QA steps? |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀
|
|
@staszekscp @mountiny in the future, let's be more explicit with our QA steps on what the expected behavior instead of just saying "as expected". Let's not assume that the person testing knows what the expected behavior is and instead write it out explicitly. Thanks! |
|
Got it, there was no behaviour change here though, so I think we could have just marked this as NoQA as existing navigation-focused regression tests cover it. Might have been cleaner than the tests written out now |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀
|
cc: @mountiny
Co-authored with @sumo-slonik
Explanation of Change
The PR bumps
@react-navigationfrom v6 to v7 alongside withreact-native-screenswhich is one of its peer dependencies.https://github.com/Expensify/Mobile-Expensify/pull/13597
Fixed Issues
$ #62850
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1748867222446199
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-06-13.at.09.59.06.mov
Android: mWeb Chrome
android.mobile.web.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-12.at.12.11.40.mp4
iOS: mWeb Safari
ios.mobile.web.mov
MacOS: Chrome / Safari
web.desktop.mov
MacOS: Desktop
desktop.mov