Skip to content

Bump: @react-navigation and react-native-screens to the newest versions#64155

Merged
mountiny merged 80 commits intoExpensify:mainfrom
software-mansion-labs:bump/react-navigation-7
Jun 27, 2025
Merged

Bump: @react-navigation and react-native-screens to the newest versions#64155
mountiny merged 80 commits intoExpensify:mainfrom
software-mansion-labs:bump/react-navigation-7

Conversation

@staszekscp
Copy link
Contributor

@staszekscp staszekscp commented Jun 13, 2025

cc: @mountiny
Co-authored with @sumo-slonik

Explanation of Change

The PR bumps @react-navigation from v6 to v7 alongside with react-native-screens which is one of its peer dependencies.

https://github.com/Expensify/Mobile-Expensify/pull/13597

Fixed Issues

$ #62850
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1748867222446199

Tests

  • Whether the RHP works as expected
  • Whether the back button behaves correctly (both in-app and browser back)
  • Whether deep links and shortcuts function properly
  • Whether standard navigation between views behaves correctly

Offline tests

QA Steps

  • Whether the RHP works as expected
  • Whether the back button behaves correctly (both in-app and browser back)
  • Whether deep links and shortcuts function properly
  • Whether standard navigation between views behaves correctly

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-06-13.at.09.59.06.mov
Android: mWeb Chrome
android.mobile.web.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-12.at.12.11.40.mp4
iOS: mWeb Safari
ios.mobile.web.mov
MacOS: Chrome / Safari
web.desktop.mov
MacOS: Desktop
desktop.mov

@staszekscp
Copy link
Contributor Author

The conflicts have been resolved!

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@mountiny
Copy link
Contributor

Kicked of the builds for fresh tests @allgandalf

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #64155 Mobile-Expensify PR Expensify/Mobile-Expensify#13597.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/64155/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/64155/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/64155/NewExpensify.dmg https://64155.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@allgandalf
Copy link
Contributor

Kicked of the builds for fresh tests @allgandalf

lemme give it a test! @staszekscp have you also tested on the latest adhocs ?

@staszekscp
Copy link
Contributor Author

@allgandalf I tested all with the newest main locally, and apart from that iOS and web on the generated adhocs

@staszekscp
Copy link
Contributor Author

All the adhoc build seem to be working just fine! Waiting for a move 😄

@allgandalf
Copy link
Contributor

all yours @mountiny

@staszekscp
Copy link
Contributor Author

Hey @mountiny! Since we're all set could I ask for the magical merge press? 😄

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience given the company event, lets be on a look out for regressions from this. If there would be many we will have to revert

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@mountiny
Copy link
Contributor

@mountiny mountiny merged commit 573e824 into Expensify:main Jun 27, 2025
29 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@kavimuru
Copy link

@staszekscp @mountiny Could you provide little more details on QA steps?

@github-actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

1 similar comment
@github-actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@puneetlath
Copy link
Contributor

@staszekscp @mountiny in the future, let's be more explicit with our QA steps on what the expected behavior instead of just saying "as expected". Let's not assume that the person testing knows what the expected behavior is and instead write it out explicitly. Thanks!

@mountiny
Copy link
Contributor

Got it, there was no behaviour change here though, so I think we could have just marked this as NoQA as existing navigation-focused regression tests cover it.

Might have been cleaner than the tests written out now

@github-actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants