Skip to content

Fix: Remove extra bottom padding on accounting connection page #64182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 2 commits into from
Jun 19, 2025
Merged

Fix: Remove extra bottom padding on accounting connection page #64182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4445a86
Fix: Remove extra bottom padding on accounting connection page
ryntgh Jun 13, 2025
89fcf47
ESLint fix
ryntgh Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/pages/workspace/accounting/intacct/EnterSageIntacctCredentialsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import useAutoFocusInput from '@hooks/useAutoFocusInput';
import useLocalize from '@hooks/useLocalize';
import useThemeStyles from '@hooks/useThemeStyles';
import {connectToSageIntacct} from '@libs/actions/connections/SageIntacct';
import * as ErrorUtils from '@libs/ErrorUtils';
import {addErrorMessage} from '@libs/ErrorUtils';
import Navigation from '@libs/Navigation/Navigation';
import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
import type {SettingsNavigatorParamList} from '@libs/Navigation/types';
Expand Down Expand Up @@ -45,7 +45,7 @@ function EnterSageIntacctCredentialsPage({route}: SageIntacctPrerequisitesPagePr
if (values[formItem]) {
return;
}
ErrorUtils.addErrorMessage(errors, formItem, translate('common.error.fieldRequired'));
addErrorMessage(errors, formItem, translate('common.error.fieldRequired'));
});
return errors;
},
Expand All @@ -55,6 +55,7 @@ function EnterSageIntacctCredentialsPage({route}: SageIntacctPrerequisitesPagePr
<ScreenWrapper
shouldEnableMaxHeight
testID={EnterSageIntacctCredentialsPage.displayName}
enableEdgeToEdgeBottomSafeAreaPadding
>
<HeaderWithBackButton
title={translate('workspace.intacct.sageIntacctSetup')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/accounting/intacct/SageIntacctPrerequisitesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ function SageIntacctPrerequisitesPage({route}: SageIntacctPrerequisitesPageProps
shouldEnablePickerAvoiding={false}
shouldShowOfflineIndicatorInWideScreen
testID={SageIntacctPrerequisitesPage.displayName}
enableEdgeToEdgeBottomSafeAreaPadding
>
<HeaderWithBackButton
title={translate('workspace.intacct.sageIntacctSetup')}
Expand Down
1 change: 1 addition & 0 deletions ...ages/workspace/accounting/netsuite/NetSuiteTokenInput/substeps/NetSuiteTokenInputForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ function NetSuiteTokenInputForm({onNext, policyID}: SubStepWithPolicy) {
submitButtonText={translate('common.confirm')}
shouldValidateOnBlur
shouldValidateOnChange
addBottomSafeAreaPadding={false}
>
{formInputs.map((formInput, index) => (
<View
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/accounting/qbd/RequireQuickBooksDesktopPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ function RequireQuickBooksDesktopModal({route}: RequireQuickBooksDesktopModalPro
shouldEnablePickerAvoiding={false}
shouldShowOfflineIndicatorInWideScreen
testID={RequireQuickBooksDesktopModal.displayName}
enableEdgeToEdgeBottomSafeAreaPadding
>
<HeaderWithBackButton
title={translate('workspace.qbd.qbdSetup')}
Expand Down