feat: 64054 Docusign powerforms#64223
Conversation
…54-docusign-powerforms
…54-docusign-powerforms
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hey @hungvu193, in general this is ready for review. The only thing that needs to be sorted out are translations. Im still waiting on copy for subheader on docusign step and then I'll request approval on translations and add them here. From implementation point of view all should be sorted out for now. |
|
Sure. Thanks @MrMuzyk |
src/pages/ReimbursementAccount/NonUSD/utils/requiresDocusignStep.ts
Outdated
Show resolved
Hide resolved
src/pages/ReimbursementAccount/NonUSD/utils/getOwnerDetailsAndOwnerFilesForBeneficialOwners.ts
Show resolved
Hide resolved
|
I'm still waiting for the remaining texts. |
|
Hey @hungvu193, Im waiting for confirmation of the translations and in the meantime I wanted to ask you if there is anything left here that I have to address? If you don't have any more comments then maybe we can start thinking about merging it soon (once translations are confirmed ofc) 👀 |
All good from my end. I'm only waiting for translation to complete the checklist here 😄 |
|
@MrMuzyk One thing I noticed was that I couldn't submit successfully because of the BE error. Is this something that we are aware of? Screen.Recording.2025-07-10.at.09.59.41.mov |
|
Yes, Corpay doesn't accept email addresses with a |
Oh I see 🤦 . Sorry I forgot it |
|
@hungvu193 Got a confirmation on translations so PR is all yours now. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromemChrome.moviOS: HybridAppiOS: mWeb Safarisafari.movMacOS: Chrome / SafariChrome.movMacOS: DesktopDesk.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.1.81-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀
|
Explanation of Change
Implemented an additional step (Step 7) for CAD and AUD accounts that includes upload of docusign powerform signed by user. Other currencies should still have only 6 steps. Values from Step 6 and 7 are saved in BE together.
Fixed Issues
$ #64054
PROPOSAL:
Tests
Same as QA steps
Offline tests
QA Steps
Precondition:
Be on account that has globalReimbursementsOnND beta enabled and doesnt have a
+in it's login emailPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4