Feat: Add ability to unreport transactions v2

[waterim]

Details

Fixed Issues

$ #60288
$ #63946
PROPOSAL: N/A

Tests

1. Open app
2. Create a workspace
3. Submit an expense
4. Go to the transaction thread.
5. Open the Report field
6. Observe new design with unreport transaction

Also go through all these tickets: #63946

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Details

Screen.Recording.2025-05-09.at.00.29.24.mov

[luacmartins]

@waterim how's this one coming along?

[waterim]

Hey @luacmartins I will push my changes tomorrow, actively worked yesterday, today we have an official day off in Callstack and Im not working today

[waterim]

Fixed issues:

1. Expense - "Duplicate" label doesn´t disappear when removing one of the expenses from report. #63926 ✅
2. Report - "x selected" not cleared after removing expense from report #63927 ✅
3. Reports - App crashes when trying to open expense after removing it from report on "Submit" #63930 ✅
4. Expense - Infinite loading when deleting an expense that was moved to Self DM offline. #63918 ✅
5. Expense - Expense that was removed from report, doesn´t disappear on member´s side. #63915 - BE issue
6. Report -"Waiting for you to submit expense" still seen on empty report when removing expense #63909 ✅
7. Expense - Self DM doesn´t display the moved expense when removing it from WS while offline #63908 ✅
8. Expense - After removing expense from report, LHN shows Hidden report with fallback avatar #63902 ✅
9. Expense - "Remove from report" option is shown in Report list of a track distance expense #63901 ✅
10. Reports - No "Remove from report" option when moving expense in Reports #63899 ✅
11. Expense - Self DM in LHN shows "submitted x for y" after moving expense to self DM #63897 ✅
12. Expense - Empty message appears in self DM after moving expense to a report from self DM #63904 ✅
13. Expense - App crashes when trying to move expense to workspace report #63903 ✅
14. Expense-Remove from report option is present for IOU and invoice but expense cannot be removed #63905 ✅

[luacmartins]

@waterim are all other bugs resolved? I don't think we need to hold this PR on #63915

[waterim]

@luacmartins not all of them for now, working on that to open a PR today

[waterim]

Had issues with fixing offline mode which is causing most of the left issues, will try to progress on this today

[luacmartins]

@waterim what are the next steps on this one?

[waterim]

Continuing with offline mode after the download option is done, have a progress with offline, tomorrow will catch on this

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[chuckdries]

@waterim this PR introduced a crash when moving an expense between reports, see #66156. I'm going to attempt to revert it

[luacmartins]

@waterim @sosek108 this PR was reverted because it introduced the following issues:

• Expense - App crashes after moving expense, RHP does not close on web #66156
  • Fix here
• [Due for payment 2025-07-25] Expense - Report field opens not here page,unable to remove report when Workflows are disabled #66104
  • Fix here
• [Due for payment 2025-07-25] Expense - Missing "Waiting for you to add expense(s)" message in empty report #66123
  • Fix here
• [Due for payment 2025-07-25] Expense - Remove from report is still shown when the expense is unreported in offline mode #66200
  • Fix here
• [Due for payment 2025-07-25] Expense - Report selector field is disabled after removing an expense from a report #66163
• [Due for payment 2025-07-25] Report - "Select Multiple" still seen on top of report, after selecting and removing expense #66111
  • Fix here
• [Due for payment 2025-07-25] [$250] Report - "Remove from report" option appears briefly when moving track expense to WS chat. #66122

I had fixes for some of them, but didn't want to risk CPing that amount of code for a tricky flow. So let's work on v3 of this PR taking the issues above into account please

[github-actions]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.82-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.82-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅