Multi file attachments by koko57 · Pull Request #64323 · Expensify/App

koko57 · 2025-06-17T13:01:42Z

Explanation of Change

🚨 IMPORTANT NOTE 🚨

This PR introduces the ability to send multiple file attachments in a single message.

Key Changes

Multiple File Selection: Users can now select and send multiple files as attachments in one message
Preview Limitation: While all files are sent successfully, only one file appears in the preview due to missing AttachmentCarousel support
Backward Compatibility: Single-attachment functionality remains unchanged and fully functional

Fixed Issues

$ #59443
PROPOSAL:

Tests

PREREQUISITES: all betas / newDotMultiFilesDragAndDrop beta enabled

[WEB / DESKTOP]

Go to any chat
Drag and drop several files onto the Add attachment dropzone
Verify that only the first attachment is shown in the modal (It'll be changed for attachment carousel later)
Click Send
Verify that all the files you dropped are sent
Now instead of dropping files click "+" in the composer
Select Add Attachment
Verify that you're able to select several attachments
Repeat steps 3.-5.

[MOBILE]

Go to any chat
click "+" in the composer
Select Add Attachment
Choose either Photo Library (Choose from Gallery) / Choose Files (Choose file) option
Verify that you're able to select several attachments
Verify that only the first attachment is shown in the modal (It'll be changed for attachment carousel later)
Click Send
Verify that all the files you dropped are sent

[CHECK THE ERROR HANDLING]

Try to drag and drop or attach via composer several files with one that will throw an error (MAX_SIZE > 24 MB, MIN_SIZE < 240 bytes, corrupted image) or try to attach more than 30 files
Verify that the error modal appears with the attachment modal underneath
Verify that the modal has 2 options: Continue and Cancel
Verify that after clicking Continue the modal is closed and you can click Send in the attachment modal
Verify that the valid attachments are sent
Repeat steps 1.-3., this time click Cancel
Verify that both modals - the error modal and the attachment modal close and the attachment flow is discontinued.

[CHECK THE SINGLE FILE FLOW]

Verify that sending attachment via dropping or sending the attachment from the attachment menu works the same like before.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Uploading Simulator Screen Recording - iPhone 15 Pro - 2025-06-17 at 15.04.24.mp4…

iOS: mWeb Safari

Uploading Simulator Screen Recording - iPhone 15 Pro - 2025-06-17 at 14.58.05.mp4…

MacOS: Chrome / Safari

Screen.Recording.2025-06-17.at.17.26.33.mp4

Screen.Recording.2025-06-17.at.17.25.18.mp4

MacOS: Desktop

Screen.Recording.2025-06-17.at.17.32.54.mp4

Screen.Recording.2025-06-17.at.17.32.16.mp4

melvin-bot · 2025-06-18T08:47:32Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2025-06-23T12:26:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-26.at.6.40.52.in.the.evening.mov

Android: mWeb Chrome

Screen.Recording.2025-06-26.at.6.48.51.in.the.evening.mov

iOS: HybridApp

Screen.Recording.2025-06-26.at.9.03.05.at.night.mov

iOS: mWeb Safari

screen-recording-2025-06-26-at-64950-in-the-evening_zUYlFvlR.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-06-25.at.4.06.20.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2025-06-26.at.6.55.54.in.the.evening.online-video-cutter.com.mp4

getusha · 2025-06-23T17:58:32Z

src/components/AttachmentModal.tsx

        [],
    );

    const isDirectoryCheck = useCallback((data: FileObject) => {


Out of scope but either the name is misleading or is not working as expected.
Doesn't prevent folder upload.

yeah, I also noticed that - but as you mentioned - out of scope

getusha · 2025-06-23T18:02:15Z

src/languages/en.ts

        tooManyFiles: ({fileLimit}: FileLimitParams) => `You can only upload up to ${fileLimit} files at a time.`,
        sizeExceededWithValue: ({maxUploadSizeInMB}: SizeExceededParams) => `Files exceeds ${maxUploadSizeInMB} MB. Please try again.`,
+        someFilesCantBeUploaded: "Some files can't be uploaded",
+        sizeLimitExceeded: "Files must be under 10 MB. Any larger files won't be uploaded.",


Isn't the limit 24 MB?

it's a limit for the receipts, it will be used later

getusha · 2025-06-23T18:05:41Z

src/languages/en.ts

+        maxFileLimitExceeded: "You can upload up to 30 receipts at a time. Any extras won't be uploaded.",
+        unsupportedFileType: ({fileType}: FileTypeParams) => `${fileType} files aren't supported. Only supported file types will be uploaded.`,
+        learnMoreAboutSupportedFiles: 'Learn more about supported formats.',
+        passwordProtected: "Password-protected PDFs aren't supported. Only supported files will be uploaded.",


Looks like we don't use this. plus password-protected PDFs are supported.

We will use it for the receipts

getusha · 2025-06-23T18:42:16Z

src/components/AttachmentModal.tsx

+                    confirmText={translate(validFilesToUpload.length ? 'common.continue' : 'common.close')}
+                    shouldShowCancelButton={!!validFilesToUpload.length}
+                    cancelText={translate('common.cancel')}
                    onModalHide={() => {


Lets reset fileError state here, since if we rely on useEffect to show the modal.

I will check it - but probably I made it this way, because when you clear the file error too early, the text will disappear before the modal closes (because modal closing is animated). Same reason the text appears a bit longer and the cancel button disappears earlier here #64323 (comment)

getusha · 2025-06-23T18:43:00Z

src/components/AttachmentModal.tsx

        setFile(originalFileName ? {name: originalFileName} : undefined);
    }, [originalFileName]);

+    useEffect(() => {


Why are we using useEffect? Can't we just set it where we set fileError?

@getusha - same as above #64323 (comment)

getusha · 2025-06-23T20:01:56Z

BUG: File size limit exceeded error appears when uploading a file under 24MB

getusha · 2025-06-23T20:02:38Z

It'd be nice if we can have a different copy when every file exceeds the limit.

getusha · 2025-06-23T20:02:52Z

Bug: A file size limit error briefly appears after pressing "Continue."

Select two files, with one exceeding the file size limit.
Press "Continue" on the "Some files can't be uploaded" error modal.

Screen.Recording.2025-06-23.at.10.58.04.at.night.mov

koko57 · 2025-06-24T05:33:44Z

It'd be nice if we can have a different copy when every file exceeds the limit.

@getusha You mean when all the files dropped are larger than 10MB? (should be 24MB for attachments, I know) I think this copy is descriptive enough for this case, we don't really care how much of the files are exceeding the limit, but I wonder what @Expensify/design Team think?

shawnborton · 2025-06-24T08:56:36Z

Personally I think it's probably fine as-is. I think this copy already went through our design doc process, right?

koko57 · 2025-06-24T10:06:58Z

Personally I think it's probably fine as-is. I think this copy already went through our design doc process, right?

yep, the copy is from the design doc

koko57 · 2025-06-27T16:35:42Z

@getusha I've made fix for ios, can you check it?

getusha · 2025-06-27T20:25:32Z

I am still able to reproduce @koko57

Screen.Recording.2025-06-27.at.11.24.18.at.night.mov

LMK if you need the assets

koko57 · 2025-06-30T06:52:01Z

@getusha yes, please, can you send me the assets?

koko57 · 2025-06-30T08:38:02Z

@getusha I've changed the limit of max size to make it easier to throw an error - I cannot reproduce

Simulator.Screen.Recording.-.iPhone.15.-.2025-06-30.at.10.35.07.mp4

lakchote · 2025-07-01T07:05:22Z

Since it looks to be asset dependent, and @koko57 can't reproduce, I don't think this should block the merge of this PR it seems an edge-case, and it can always be done as a follow-up.

cc @getusha

getusha · 2025-07-01T08:42:58Z

Can't upload multiple file attachments after a multi file error

Pick two attachments with one being invalid
Cancel
Pick two valid attachments

Screen.Recording.2025-07-01.at.10.45.29.in.the.morning.mov

Doesn't have to be a blocker

getusha · 2025-07-01T08:43:27Z

For the iOS issue there is a noticeable delay that could be relevant

Screen.Recording.2025-07-01.at.11.40.42.in.the.morning.mov

Will again test it after the refactor

koko57 · 2025-07-01T08:56:10Z

yeah, for the ios, I think we should add a loader (like it's for selecting receipts in the IOU flow), it could be done later, now I will fix the issue with the modal on the web

koko57 · 2025-07-01T08:57:08Z

@getusha can you check once again #64323 (comment) and send me the attachments if it's still reproducible?

koko57 · 2025-07-01T09:15:14Z

@getusha also please retest this one: #64323 (comment) (fixed)

getusha · 2025-07-01T10:24:10Z

@getusha can you check once again #64323 (comment) and send me the attachments if it's still reproducible?

Couldn't reproduce but i think it's a potential race condition which boils down to the delay

Screen.Recording.2025-07-01.at.1.03.53.in.the.afternoon.mov

You can replicate the freeze by trying to open the create popover before the error modal appears

OSBotify · 2025-07-01T12:41:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-02T00:03:02Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.74-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mountiny · 2025-07-02T23:18:34Z

We have reverted to fix this blocker #65317, please add those QA steps to the next attempt 🙌 Thank you!

github-actions · 2025-07-03T19:43:16Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

koko57 added 7 commits June 17, 2025 10:37

feat: enable multiple attachments

f8548eb

fix: minor fix

9771d80

fix: search page, code improvements

80280b1

feat: minor improvements

e8728db

fix: minor fix

5aa656a

fix: eslint

824517a

fix: prettier

1675dbc

koko57 changed the title ~~Multi file attachments~~ [NoQA] Multi file attachments Jun 17, 2025

koko57 mentioned this pull request Jun 17, 2025

[Due for payment 2025-07-17] [Multi-Files Drag-and-Drop] (Stage 5) Update the Attach zone to accept multiple documents #59443

Closed

koko57 added 4 commits June 18, 2025 09:22

fix: add missing translations

e08b70e

fix: resolve conflicts

fa7ca56

fix: remove unicodes

d2153f9

fix: prettier

e16b05f

koko57 marked this pull request as ready for review June 18, 2025 08:47

koko57 requested a review from a team as a code owner June 18, 2025 08:47

melvin-bot bot requested review from getusha and removed request for a team June 18, 2025 08:47

fix: resolve conflicts

4092928

Merge branch 'main' into feat/59443-multi-file-attachments-clean

302d330

getusha reviewed Jun 23, 2025

View reviewed changes

koko57 added 2 commits June 24, 2025 13:03

Merge branch 'main' into feat/59443-multi-file-attachments-clean

6a64150

fix: fix size limit error problem

e497eb5

Merge branch 'main' into feat/59443-multi-file-attachments-clean

2384bf6

koko57 added 2 commits June 30, 2025 11:47

Merge branch 'main' into feat/59443-multi-file-attachments-clean

56e08be

Merge branch 'main' into feat/59443-multi-file-attachments-clean

c795354

fix: clear error onCancel

c6fbbbe

getusha approved these changes Jul 1, 2025

View reviewed changes

lakchote changed the title ~~[NoQA] Multi file attachments~~ Multi file attachments Jul 1, 2025

lakchote approved these changes Jul 1, 2025

View reviewed changes

lakchote merged commit ec2e890 into Expensify:main Jul 1, 2025
20 checks passed

github-actions bot mentioned this pull request Jul 1, 2025

Deploy Checklist: New Expensify 2025-07-01 #65287

Closed

57 tasks

This was referenced Jul 2, 2025

Expense - Not here page opens when launching app via app shortcut #65295

Closed

[Due for payment 2025-07-30] [$250] Android- Attachment- Unable to attach any document from clipboard #65317

Closed

mitarachim mentioned this pull request Jul 2, 2025

[$250] Attachment- Corrupted PDF isn't triggering the error modal if sent with drag & drop #65319

Closed

8 tasks

nlemma mentioned this pull request Jul 2, 2025

[Multi-Files Drag-and-Drop] Attachment - Old error modal appears when uploading corrupted image #65333

Closed

8 tasks

mountiny mentioned this pull request Jul 2, 2025

[CP Staging] Revert "Multi file attachments" #65354

Merged

koko57 mentioned this pull request Jul 9, 2025

[Due for payment 2025-08-05] [Due for payment 2025-07-30] [Due for payment 2025-07-25] [Due for payment 2025-07-22] [Multi-Files Drag-and-Drop] Follow-ups and code cleanup #65722

Closed

10 tasks

Conversation

koko57 commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 18, 2025

Uh oh!

getusha commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

getusha commented Jun 23, 2025

Uh oh!

getusha commented Jun 23, 2025

Uh oh!

getusha commented Jun 23, 2025

Uh oh!

koko57 commented Jun 24, 2025

Uh oh!

shawnborton commented Jun 24, 2025

Uh oh!

koko57 commented Jun 24, 2025

Uh oh!

koko57 commented Jun 27, 2025

Uh oh!

getusha commented Jun 27, 2025

Uh oh!

koko57 commented Jun 30, 2025

Uh oh!

koko57 commented Jun 30, 2025

Uh oh!

lakchote commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

getusha commented Jul 1, 2025

Uh oh!

getusha commented Jul 1, 2025

Uh oh!

koko57 commented Jul 1, 2025

Uh oh!

koko57 commented Jul 1, 2025

Uh oh!

koko57 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

getusha commented Jul 1, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

mountiny commented Jul 2, 2025

koko57 commented Jun 17, 2025 •

edited

Loading

getusha commented Jun 23, 2025 •

edited

Loading

lakchote commented Jul 1, 2025 •

edited

Loading

koko57 commented Jul 1, 2025 •

edited

Loading