fix: Update Expensify Help version badges to look like badges by daledah · Pull Request #64567 · Expensify/App

daledah · 2025-06-19T14:52:23Z

Explanation of Change

Fixed Issues

$ #64093
PROPOSAL: #64093 (comment)

Tests

Go to Expensify Help
Go to New Expensify > Wallet & Payments > Connect a Business Bank Account
Verify the styles of Expensify Help version badge

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Expensify Help
Go to New Expensify > Wallet & Payments > Connect a Business Bank Account
Verify the styles of Expensify Help version badge

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

iOS: Native

N/A

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

N/A

melvin-bot · 2025-06-19T20:05:31Z

melvin-bot · 2025-06-19T20:05:33Z

@rojiphil @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2025-06-19T20:20:50Z

Can you double-check the styles used for the badges? They don't look quite right to me:

(Correct on the left, current on the right)

Ideally these should match our in-product badge styles exactly:

Border radius: 4px
Border size: 1px
Text color: Text (#002E22)
Height: 28px
Padding (left/right): 12px

daledah · 2025-06-22T16:32:26Z

@dannymcclain I updated.

shawnborton · 2025-06-23T07:26:24Z

@daledah do you have updated screenshots/videos too?

shawnborton · 2025-06-23T07:27:02Z

docs/_sass/_main.scss

    line-height: 16px;
 }

+#platform-tabs > .badge{


Can we just make this a more generic class? Like even just a simple .badge with no specificity before it.

Also, why aren't we setting a font-size on these badges? Please see Danny's guidance.

We already have the font size here:

App/docs/_sass/_main.scss

Line 1115 in bc12ce0

font-size: 13px;

Hmm yes but let's not make the CSS so specific. Please DRY this up into a clean .badge class, where we'll need to include a font size. We don't want super specific selectors in our CSS files. Thanks!

rojiphil

@daledah Thanks for the PR. Code LGTM except for one comment which I have left in review comments. Please have a look.
And I also think a clean .badge class as mentioned here would help us remain DRY.

docs/assets/js/platform-tabs.js

shawnborton · 2025-06-30T09:18:13Z

What's the latest on this one?

rojiphil · 2025-06-30T09:31:57Z

What's the latest on this one?

Review feedback has to be worked upon.
@daledah What's the status on the feedback thus far? Please let us know.

daledah · 2025-06-30T10:47:29Z

@rojiphil I updated.

shawnborton · 2025-06-30T12:38:03Z

CSS feels better to me, thanks for hearing me out!

Let us know when we have updated screenshots/videos.

rojiphil · 2025-06-30T13:02:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

NA

Android: mWeb Chrome

64567-mweb-chrome-002.mp4

iOS: HybridApp

NA

iOS: mWeb Safari

64567-mweb-safari-002.mp4

MacOS: Chrome / Safari

64567-web-chrome-002.mp4

MacOS: Desktop

NA

rojiphil · 2025-06-30T13:03:46Z

Let us know when we have updated screenshots/videos.

@shawnborton Here are the test videos

MacOS: Chrome / Safari

64567-web-chrome-002.mp4

iOS: mWeb Safari

64567-mweb-safari-002.mp4

Android: mWeb Chrome

64567-mweb-chrome-002.mp4

rojiphil

Thanks @daledah for the update.

@srikarparsi Code changes LGTM. Approving for your review.

shawnborton · 2025-06-30T13:10:43Z

On mobile, I think it would be nice if the badge felt closer to the headline than the content below it. Basically swap the top/bottom spacing around:

Thoughts @Expensify/design ?

Also, can you verify the height of these badges? Thanks!

dannymcclain · 2025-06-30T13:16:25Z

On mobile, I think it would be nice if the badge felt closer to the headline than the content below it.

Agree! The badges also feel a little wide to me, can we double-check that the horizontal padding is 12px?

rojiphil · 2025-06-30T13:18:33Z

can you verify the height of these badges?

Height is 36px

dannymcclain · 2025-06-30T13:24:38Z

@rojiphil can you try to match the specs outlined in this comment?

The height should be 28px, and the font-size should be 11px (realized I didn't include font-size in my original comment)

rojiphil · 2025-06-30T14:32:31Z

The height should be 28px, and the font-size should be 11px (realized I didn't include font-size in my original comment)

Ah! Sorry. I didn't notice that.
@daledah Please make these changes and also the horizontal padding to 12 px as mentioned here. Currently, the horizontal padding is 20px within the badge. Also, there is a nice-to-have request to bring the badge closer to the headline. Thanks.

daledah · 2025-06-30T14:39:54Z

@shawnborton @rojiphil Is this good?

Or some more spaces like this one:

shawnborton · 2025-06-30T14:57:31Z

That does look better, again we just need to confirm a height of 28px and font size of 11px.

rojiphil · 2025-06-30T15:30:22Z

@daledah Based on this comment, swapping the top/bottom spacing was preferred. As such, the second one seems better.
Please commit the changes and I can verify the specs again.

daledah · 2025-06-30T15:41:25Z

@rojiphil I updated.

rojiphil · 2025-06-30T17:09:10Z

Thanks @daledah for making the changes.

@shawnborton @dannymcclain Here are the updated test videos. LGTM. Please confirm if this is fine.

MacOS: Chrome / Safari

64567-web-chrome-003.mp4

Android: mWeb Chrome

64567-mweb-chrome-003.mp4

iOS: mWeb Safari

64567-mweb-safari-003.mp4

shawnborton · 2025-06-30T17:45:52Z

Nice, I think that's feeling good to me.

dannymcclain · 2025-06-30T19:07:16Z

Same!

rojiphil

Thanks @shawnborton @dannymcclain for the confirmation.

@srikarparsi Changes LGTM. Approving again for your review.

srikarparsi · 2025-07-01T06:20:11Z

docs/assets/js/main.js


 function selectNewExpensify(newExpensifyTab, newExpensifyContent, expensifyClassicTab, expensifyClassicContent) {
-    newExpensifyTab.classList.add('active');
+    newExpensifyTab.classList.add(!expensifyClassicTab && !expensifyClassicContent ? 'badge' : 'active');


What are these changes needed for?

If the page can be switched via buttons between New Expensify and Classic, we do not want to change the button style.

These changes are to ensure that we display badge only when either New Expensify or Expensify Classic page is displayed. Otherwise, if the page content is applicable for both, use active. But I am wondering now if there is a use case where the page content is applicable for both as I could not find one. @srikarparsi Can you please point out to one such usage? Thanks.

Yeah I'm actually not sure which is why I asked. @maddylewis do you know the answer to this question? Basically, are there any pages which are applicable for both New Expensify and Expensify Classic?

there shouldn't be, no! i was thinking pricing, but even the breadcrumb paths are slightly different in these two resources:

https://help.expensify.com/articles/expensify-classic/expensify-billing/Billing-Overview

https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Billing-Overview

that said, each article is under the expensify-classic or new-expensify path. so even if content was applicable to both, there would be two separate articles (in today's setup at least).

sounds good thank you! Then in that case, we should be able to remove this extra code and just use the badge class right @rojiphil?

Yeah. Agree.
@daledah We only need badge class here. Let us remove the extra code related to active. Thanks.

srikarparsi · 2025-07-01T06:20:48Z

docs/assets/js/platform-tabs.js

    tab.innerHTML = 'Expensify Classic';
    tab.id = 'platform-tab-expensify-classic';
-    tab.classList.add('active');
+    if (!newExpensifyContent) {


Same for these changes. And why not write it the same as the ternary above?

srikarparsi

Just have two questions before merging

srikarparsi · 2025-07-08T04:55:49Z

Hey @daledah, any update on this one?

daledah · 2025-07-08T23:14:03Z

@srikarparsi Sorry for the delay 🙏, I updated.

srikarparsi · 2025-07-09T07:21:46Z

Can you please merge main? It looks like a test is failing

srikarparsi · 2025-07-09T17:00:39Z

checks passed now after re-running

github-actions · 2025-07-10T07:25:39Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.1.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-11T17:37:42Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

daledah added 2 commits June 19, 2025 21:52

fix: Update Expensify Help version badges to look like badges

841d11c

refactor: remove unsused codes

efbe612

daledah marked this pull request as ready for review June 19, 2025 20:05

daledah requested review from a team as code owners June 19, 2025 20:05

melvin-bot bot requested review from CortneyOfstad and rojiphil June 19, 2025 20:05

melvin-bot bot removed the request for review from a team June 19, 2025 20:05

daledah added 2 commits June 22, 2025 23:28

Merge branch 'main' into fix/64093

d59c7e6

fix: adjust styles

9d3f1b1

shawnborton reviewed Jun 23, 2025

View reviewed changes

rojiphil reviewed Jun 26, 2025

View reviewed changes

docs/assets/js/platform-tabs.js Outdated Show resolved Hide resolved

fix: styles

f4528ff

rojiphil approved these changes Jun 30, 2025

View reviewed changes

melvin-bot bot requested a review from srikarparsi June 30, 2025 13:04

update styles

8c0afb9

fix padding

d49d569

rojiphil approved these changes Jun 30, 2025

View reviewed changes

srikarparsi reviewed Jul 1, 2025

View reviewed changes

srikarparsi requested changes Jul 1, 2025

View reviewed changes

daledah added 2 commits July 9, 2025 06:11

Merge branch 'main' into fix/64093

68f0e00

refactor: remove unused active class

f250e34

srikarparsi approved these changes Jul 9, 2025

View reviewed changes

srikarparsi merged commit 3789f0b into Expensify:main Jul 9, 2025
22 of 23 checks passed

github-actions bot mentioned this pull request Jul 10, 2025

Deploy Checklist: New Expensify 2025-07-10 #65809

Closed

77 tasks

melvin-bot bot mentioned this pull request Jul 11, 2025

[C+ Checklist Needs Completion] [$250] Update Expensify Help version badges to look like badges #64093

Closed

Conversation

daledah commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 19, 2025

Concierge reviewer checklist:

Uh oh!

melvin-bot bot commented Jun 19, 2025

Uh oh!

dannymcclain commented Jun 19, 2025

Uh oh!

daledah commented Jun 22, 2025

Uh oh!

shawnborton commented Jun 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shawnborton commented Jun 30, 2025

Uh oh!

rojiphil commented Jun 30, 2025

Uh oh!

daledah commented Jun 30, 2025

Uh oh!

shawnborton commented Jun 30, 2025

Uh oh!

rojiphil commented Jun 30, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil commented Jun 30, 2025

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Jun 30, 2025

Uh oh!

dannymcclain commented Jun 30, 2025

Uh oh!

rojiphil commented Jun 30, 2025

Uh oh!

dannymcclain commented Jun 30, 2025

Uh oh!

rojiphil commented Jun 30, 2025

Uh oh!

daledah commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Jun 30, 2025

Uh oh!

rojiphil commented Jun 30, 2025

Uh oh!

daledah commented Jun 30, 2025

Uh oh!

rojiphil commented Jun 30, 2025

Uh oh!

shawnborton commented Jun 30, 2025

Uh oh!

dannymcclain commented Jun 30, 2025

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

daledah commented Jun 19, 2025 •

edited

Loading

daledah commented Jun 30, 2025 •

edited

Loading

srikarparsi commented Jul 9, 2025 •

edited

Loading