Fix: Unable to scroll troubleshoot panel by nyomanjyotisa · Pull Request #64717 · Expensify/App

nyomanjyotisa · 2025-06-23T05:46:53Z

Explanation of Change

This PR addresses several issues related to the Test Tools modal

Fixed Issues

$ #64550
#64431
PROPOSAL: N/A

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Log in with any account
Open the test tools modal by performing a four-finger tap on mobile or CMD+D on desktop
Verify that the troubleshoot panel is scrollable
Enable “Record Troubleshoot Data”
Click on “View console” button
Verify the test tools modal closed and console page displayed correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

melvin-bot · 2025-06-25T07:43:41Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nyomanjyotisa · 2025-06-30T07:12:10Z

Here is the summary of the changes in the PR:

Fixed scrolling issue on native platforms by wrapping the TestToolMenu with PressableWithoutFeedback
Fixed debug console issue on iOS native by dismissing the test tool modal before opening the console page
Fixed navigation for the test tool modal and debug console page
Updated the height of the test tool modal to a fixed number

cc @hungvu193

hungvu193 · 2025-06-30T07:13:36Z

Oh, thanks for the tag here @nyomanjyotisa. This PR is totally slipped from my list 🤦

hungvu193 · 2025-06-30T09:07:48Z

src/styles/index.ts

-            const height = isAuthenticated ? defaultHeight : '55%';
+            const defaultHeight = shouldUseNarrowLayout ? '78%' : 654;
+            const height = isAuthenticated ? defaultHeight : 400;



I wonder, what's the issue with using percent? And what's the reason for 654 and 400 number?

Since the Use profiling and Client side logging menu items have been removed and replaced with Record Troubleshoot Data, the default content in the modal is no longer enough to fill 75% of the screen height. This results in an empty gap at the bottom of the modal

Before After

We chose 654 and 400 (should have been 398) as the fixed height values because the default content height of the test tools modal is 654 when the user is authenticated

and 398 when the user is not authenticated

We also kept the 78% height for narrow layouts because on mWeb Safari, setting the modal height to 654px causes it to take up the entire screen

Thanks. Let me double check.

Also I'm facing issue on Android app, the splash screen is stuck and I couldn't verify the bugs. I'll try again for a while.

Is there a Slack convo you can link for posterity where the 654 and 400 numbers were discussed/chosen?

Could you also add comments in code briefly explaining the reasoning for each number?

There isn’t a specific Slack conversation where 654 and 400 were discussed—these numbers were derived by visually inspecting the modal content height after the removal of the Use profiling and Client side logging menu items

I’ll add comments to explain this for reference

hungvu193 · 2025-07-01T10:42:50Z

I think this can be a bug. When I press back from Console page on Android, I'm navigated to Troubleshoot screen.

Screen.Recording.2025-07-01.at.17.41.39.mov

here's on the web, which looks expected to me:

Screen.Recording.2025-07-01.at.17.43.38.mov

nyomanjyotisa · 2025-07-02T06:47:53Z

When I press back from Console page on Android, I'm navigated to Troubleshoot screen

I think this happens because when we access the test tools modal directly via link (/test-tools) instead of CMD + D or four finger tap, we don't have backTo param so it went to troubleshoot page stack
We can use ROUTES.HOME as a default backTo value when none is provided

Android-Native.mp4

hungvu193 · 2025-07-03T08:51:40Z

Thanks. Looks much better!

hungvu193 · 2025-07-03T08:55:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mChrome.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2025-07-03.at.15.55.10.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-03.at.15.52.25.mov

MacOS: Desktop

Desk.mov

melvin-bot · 2025-07-03T09:34:09Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #64550 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

melvin-bot · 2025-07-03T21:19:49Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-07-03T21:20:45Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2025-07-03T21:22:10Z

I have not been able to get to this pull request review yet. The past two weeks have been very busy and I've been focusing on internal PR reviews.

I'm going to be out of office July 4th through 16th. Working 0%. Therefore, I have reassigned this to another internal engineer who can move it forward while I'm gone. Thank you 🙇

amyevans

One small request, thanks!

amyevans · 2025-07-10T17:23:15Z

src/styles/index.ts

-            const height = isAuthenticated ? defaultHeight : '55%';
+            const defaultHeight = shouldUseNarrowLayout ? '78%' : 654;
+            const height = isAuthenticated ? defaultHeight : 400;



Is there a Slack convo you can link for posterity where the 654 and 400 numbers were discussed/chosen?

Could you also add comments in code briefly explaining the reasoning for each number?

github-actions · 2025-07-11T18:06:24Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.1.80-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-15T03:00:13Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.80-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nyomanjyotisa added 3 commits June 23, 2025 13:41

Fix: Unable to scroll troubleshoot panel

b600491

Merge branch 'main' into issue-64550

343973b

navigation fix

a12e1b7

nyomanjyotisa marked this pull request as ready for review June 25, 2025 07:43

nyomanjyotisa requested a review from a team as a code owner June 25, 2025 07:43

melvin-bot bot requested review from QichenZhu and removed request for a team June 25, 2025 07:43

nyomanjyotisa mentioned this pull request Jun 25, 2025

[Due for payment 2025-07-22] [$250] Android- Troubleshoot- Unable to scroll troubleshoot panel #64550

Closed

8 tasks

truph01 mentioned this pull request Jun 25, 2025

[HOLD on pull/64717] On mobile if you try to open the debug console it opens behind the pop up so you can’t read or interact with it #64431

Closed

16 tasks

nyomanjyotisa added 4 commits June 26, 2025 09:42

minor fix

bd0663d

Merge branch 'main' into issue-64550

afa5195

change test tools modal default height

7a028f9

fix: console navigation issue

788c8c7

nyomanjyotisa requested a review from a team as a code owner June 26, 2025 08:20

nyomanjyotisa added 5 commits June 27, 2025 07:11

Merge branch 'main' into issue-64550

6676a98

Merge branch 'main' into issue-64550

32ccd72

test tools modal animation

35d574e

fix navigation issue

208c5e2

fix navigation issue

a336681

hungvu193 reviewed Jun 30, 2025

View reviewed changes

nyomanjyotisa mentioned this pull request Jul 1, 2025

[$250] Inbox - A second LHN appears when going back from debug menu #65185

Closed

8 tasks

Merge branch 'main' into issue-64550

2b021fc

add default backTo param value

ffaca66

hungvu193 approved these changes Jul 3, 2025

View reviewed changes

melvin-bot bot requested a review from neil-marcellini July 3, 2025 09:34

neil-marcellini requested a review from a team July 3, 2025 21:19

melvin-bot bot requested review from amyevans and removed request for a team July 3, 2025 21:19

neil-marcellini requested review from a team and removed request for neil-marcellini July 3, 2025 21:20

melvin-bot bot requested a review from neil-marcellini July 3, 2025 21:20

melvin-bot bot removed the request for review from a team July 3, 2025 21:20

neil-marcellini removed their request for review July 3, 2025 21:22

amyevans requested changes Jul 10, 2025

View reviewed changes

add comments for fixed modal height values

e5f97b0

Eskalifer1 mentioned this pull request Jul 11, 2025

[HOLD for payment 2025-07-20] Incorrect animation for the debug modal #65932

Closed

amyevans approved these changes Jul 11, 2025

View reviewed changes

amyevans merged commit 684e45f into Expensify:main Jul 11, 2025
17 checks passed

This was referenced Jul 11, 2025

Investigate workflow job failing on main: test / test (job 1) #65935

Closed

Deploy Checklist: New Expensify 2025-07-11 #65958

Closed

BlameGPT mentioned this pull request Jul 13, 2025

Expense - Unable to scroll the bottom modal More section on the Expense that needs approval #66008

Closed

8 tasks

chrispader mentioned this pull request Jul 15, 2025

Fix: TestToolsModal is not fading in on web #65535

Closed

51 tasks

Julesssss mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-04-29 Expensify/App-Test-Fork#56

Closed

68 tasks

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 3] Migrate Navigation usage v2 #83064

Open

Conversation

nyomanjyotisa commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 25, 2025

Uh oh!

nyomanjyotisa commented Jun 30, 2025

Uh oh!

hungvu193 commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

amyevans Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nyomanjyotisa commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Jul 3, 2025

Uh oh!

hungvu193 commented Jul 3, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 3, 2025

Uh oh!

melvin-bot bot commented Jul 3, 2025

Uh oh!

melvin-bot bot commented Jul 3, 2025

Uh oh!

neil-marcellini commented Jul 3, 2025

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

amyevans Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nyomanjyotisa commented Jun 23, 2025 •

edited

Loading

hungvu193 commented Jun 30, 2025 •

edited

Loading

hungvu193 commented Jul 1, 2025 •

edited

Loading

nyomanjyotisa commented Jul 2, 2025 •

edited

Loading