[Internal QA]: More Plaid import follow ups by narefyev91 · Pull Request #64741 · Expensify/App

narefyev91 · 2025-06-23T13:13:29Z

Explanation of Change

More Plaid import follow ups

Fixed Issues

$ #64659, #63516
PROPOSAL:

Tests

Bug 1: Plaid import card icons are too hard to see in light mode

Create a workspace
Connect a Plaid import feed.

Bug 2: Missing card feed name and custom icons on card filer on reports page

Create a workspace.
Connect a Plaid feed.
Assign a card with transactions.
Go to the Reports page > Expenses.
Open filters and select card.

Bug 3: Card filter on reports page not working to filter transactions

Create a workspace.
Connect a Plaid feed.
Assign a card with transactions.
Go to the Reports page > Expenses.
Open filters and select card with transactions.
Tap Save.
Tap View results.

Bug 4: Missing last 4 digits for some cards on card feed

Create a workspace.
Connect a wells fargo feed.
Assign a card.

Verify that no errors appear in the JS console

Offline tests

No changes

QA Steps

Bug 1: Plaid import card icons are too hard to see in light mode

Create a workspace
Connect a Plaid import feed.

Bug 2: Missing card feed name and custom icons on card filer on reports page

Create a workspace.
Connect a Plaid feed.
Assign a card with transactions.
Go to the Reports page > Expenses.
Open filters and select card.

Bug 3: Card filter on reports page not working to filter transactions

Create a workspace.
Connect a Plaid feed.
Assign a card with transactions.
Go to the Reports page > Expenses.
Open filters and select card with transactions.
Tap Save.
Tap View results.

Bug 4: Missing last 4 digits for some cards on card feed

Create a workspace.
Connect a wells fargo feed.
Assign a card.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Bug 2:

Android: mWeb Chrome

Bug 2:

iOS: Native

Bug 2:

iOS: mWeb Safari

Bug 2:

MacOS: Chrome / Safari

Bug 2:

MacOS: Desktop

Bug 2:

narefyev91 · 2025-06-25T12:59:23Z

Bug 1 Fixed:

Bug 2 Fixed (all videos in attached section)

Bug 3 Fixed:

Screen.Recording.2025-06-25.at.15.51.24.mov

Bug 4: Not able to reproduce:

melvin-bot · 2025-06-25T13:10:18Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-06-26T10:38:18Z

@narefyev91 Could you kindly merge main?

dominictb · 2025-06-26T10:53:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

dominictb · 2025-06-26T11:08:22Z

BUG: In card filter page, individual card avatar is missing bank icon:

dominictb · 2025-06-26T11:29:56Z

@joekaufmanexpensify One small question: If I was assigned a card by another workspace which belongs to another feed, should I show that feed option in card filters page (i.e., the All Credit Card 3333 option in the below image)? Ignore the bank icon style, this is just for reference purpose.

dominictb · 2025-06-26T11:42:57Z

@joekaufmanexpensify One small suggestion is that we could show the card name and card feed name following the same format with Expensify card:

narefyev91 · 2025-06-26T11:47:29Z

@dominictb fixed:

dominictb · 2025-06-26T12:32:33Z

Code looks good and tests well for now.

joekaufmanexpensify · 2025-06-26T17:14:37Z

@joekaufmanexpensify One small question: If I was assigned a card by another workspace which belongs to another feed, should I show that feed option in card filters page (i.e., the All Credit Card 3333 option in the below image)? Ignore the bank icon style, this is just for reference purpose.

Is there a reason we wouldn't? Doesn't the filter show the feed in the "Card feeds" section whenever you're assigned at least one card on a feed? And tapping it selects all your assigned cards from that feed (which can be just one)?

joekaufmanexpensify · 2025-06-26T17:27:02Z

@joekaufmanexpensify One small suggestion is that we could show the card name and card feed name following the same format with Expensify card:

I'm not opposed to putting the card name there for third party cards. Though, we'd probably need to truncate if it is long. There are some situations where we don't use card name for Expensify Cards, like for domain cards from OldDot. But we do always seem to for workspace Expensify Cards. So adding that here would be consistent. WDYT @Expensify/design ?

The second item you're referencing for Expensify Cards is not the feed name. It looks like it is the card type, ie if it's virtual or physical. That is N/A for third party cards.

joekaufmanexpensify · 2025-06-26T17:27:32Z

Also, once this one is reviewed, let's test it on an ad-hoc build before we merge 👍

shawnborton · 2025-06-27T05:52:46Z

So adding that here would be consistent.

Always down for consistency!

joekaufmanexpensify · 2025-06-27T15:11:54Z

Cool cool. @narefyev91 @dominictb could we go ahead and add the card name for third party cards here then?

narefyev91 · 2025-06-30T06:24:05Z

Cool cool. @narefyev91 @dominictb could we go ahead and add the card name for third party cards here then?

Yeah will add today

narefyev91 · 2025-06-30T06:54:08Z

dominictb · 2025-06-30T10:16:38Z

BUG: Card feed assigned by another workspace that I am not the owner of does not appear in filter list:

As user B, go to his workspace (he is the owner)
Assign a company card to user A
As user A, observe in card filters page, the assigned card (3333 · Plaid Credit Card 3333 in the below screenshot) does appear but the card feed (e.g., `All Plaid Credit Card 3333) does not

joekaufmanexpensify · 2025-07-16T13:32:17Z

@joekaufmanexpensify @dominictb is it ok that we display other feeds in the search query like this?

@koko57 Ideally, no. In what context are we showing the feed name like that?

joekaufmanexpensify · 2025-07-16T13:33:25Z

I don't think we'll be able to test this on an ad-hoc. Ad-hoc builds (and staging) use the Plaid sandbox. Fixing a broken Plaid connection requires actually being able to connect to the bank on production. So I think we'll need to wait until this is deployed to test that piece.

Circling back to this, I chatted with @nkuoch and confirmed there is actually a way to test broken connection on staging/ad-hoc. So once the PR is otherwise ready to go, let me know and I'll spin up an ad-hoc build to test this.

koko57 · 2025-07-16T13:41:06Z

@joekaufmanexpensify @dominictb is it ok that we display other feeds in the search query like this?

@koko57 Ideally, no. In what context are we showing the feed name like that?

@joekaufmanexpensify after choosing All Visa Cards in the search filter. Now after my fix the feed name will be displayed correctly for all the feeds

joekaufmanexpensify · 2025-07-16T14:52:39Z

Sounds good! So we're just displaying the feed name (I assume for the second example, the feed name is simply Visa)?

koko57 · 2025-07-16T15:01:07Z

@joekaufmanexpensify yep, exactly!

dominictb · 2025-07-16T17:22:26Z

@koko57 About this bug #64741 (comment), steps to reproduce:

Go to workspace company cards page
Connect to a feed if you don't have any
Refresh the workspace company cards page (important)
Press Assign card
Complete the assign card flow
App crashes

This is happening on staging and production as well and seems like something broken with react-native-reanimated. I'm not 100% sure but can you help to verify if this bug is not related to our Plaid flow? If it is, we need to fix in this PR. Otherwise I'll report it and continue to proceed this PR.

joekaufmanexpensify · 2025-07-16T18:02:37Z

Discussing more here

koko57 · 2025-07-17T08:14:03Z

@dominictb still, couldn't repro locally. Could repro on staging. @joekaufmanexpensify I saw the discussion - so should we fix it here or it will be handled separately? Is it still a blocker for this PR?

dominictb

That bug is handled separately.

joekaufmanexpensify · 2025-07-17T13:59:55Z

Initiated adhoc build to try and test broken connection fix there 👍

github-actions · 2025-07-17T14:01:06Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-07-17T14:43:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #64741.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/64741/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/64741/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/64741/NewExpensify.dmg	https://64741.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2025-07-17T15:35:53Z

Talked with Nathalie more and we're not sure that the broken connection can be simulated in staging/adhoc after all. So we're just going to test that piece on prod 👍

github-actions · 2025-07-18T05:13:11Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.1.83-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

joekaufmanexpensify · 2025-07-18T14:31:46Z

Tested everything I could on staging, looks good 👍

joekaufmanexpensify · 2025-07-18T14:31:59Z

I will test the Wells Fargo fix and broken connection fix on Prod

joekaufmanexpensify · 2025-07-18T14:32:57Z

One very minor piece of feedback, did we add the new card border to the feed selector? I am not seeing it there. Comparison with card feed below.

joekaufmanexpensify · 2025-07-18T14:33:12Z

Checked off as that is very minor 👍

koko57 · 2025-07-18T15:18:04Z

@joekaufmanexpensify the svg added for the card has a border - but as it's the same/very similar color it's not noticeable for the highlighted item

dannymcclain · 2025-07-18T15:20:24Z

@joekaufmanexpensify Yep, what Agata said—the highlight background uses our same border color, so it doesn't "show up" on the selected row. I think it's totally fine! And I think the @Expensify/design is proposing a change to that selected state soon anyways.

shawnborton · 2025-07-18T15:22:29Z

Yup, what Danny said!

joekaufmanexpensify · 2025-07-18T15:27:27Z

Sweet, thank you all for confirming!

github-actions · 2025-07-21T16:37:03Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.83-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

joekaufmanexpensify · 2025-07-22T14:10:18Z

A few issues when testing in prod. Discussing here.

blazejkustra · 2026-02-17T19:15:33Z

src/pages/workspace/companyCards/addNew/PlaidConnectionStep.tsx

+                                    getDomainNameForPolicy(policyID),
+                                    JSON.stringify(metadata?.accounts),
+                                );
+                                InteractionManager.runAfterInteractions(() => {


@narefyev91 why was this InteractionManager necessary here? (I'm working on InteracionManager migration and I need to understand the use case)

Thank you in advance!

narefyev91 added 3 commits June 23, 2025 15:59

Add correct name and image to Search card filter

edf7692

Merge branch 'refs/heads/main' into more-plaid-company-card-follow-ups

dab0e2b

fix search based on feed

e739213

fix border for images

52f174f

narefyev91 marked this pull request as ready for review June 25, 2025 13:10

narefyev91 requested review from a team as code owners June 25, 2025 13:10

melvin-bot bot requested a review from dominictb June 25, 2025 13:10

melvin-bot bot removed the request for review from a team June 25, 2025 13:10

Merge branch 'refs/heads/main' into more-plaid-company-card-follow-ups

09ca06e

fix visibility of the very small cards

192b342

add card name in reports

9dae27b

Merge branch 'refs/heads/main' into more-plaid-company-card-follow-ups

46cf2b0

dominictb approved these changes Jul 17, 2025

View reviewed changes

nkuoch approved these changes Jul 17, 2025

View reviewed changes

nkuoch merged commit be6876c into Expensify:main Jul 17, 2025
18 checks passed

github-actions bot mentioned this pull request Jul 18, 2025

Deploy Checklist: New Expensify 2025-07-18 #66687

Closed

72 tasks

melvin-bot bot mentioned this pull request Jul 21, 2025

[$500] [Due for payment 2025-08-11] More Plaid import follow ups #64659

Closed

8 tasks

blazejkustra reviewed Feb 17, 2026

View reviewed changes

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 9] Needs more investigation/remaining usage of InteractionManager #83070

Open

Conversation

narefyev91 commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

narefyev91 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Jun 25, 2025

Uh oh!

dominictb commented Jun 26, 2025

Uh oh!

dominictb commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Jun 26, 2025

Uh oh!

dominictb commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Jun 26, 2025

Uh oh!

narefyev91 commented Jun 26, 2025

Uh oh!

dominictb commented Jun 26, 2025

Uh oh!

joekaufmanexpensify commented Jun 26, 2025

Uh oh!

joekaufmanexpensify commented Jun 26, 2025

Uh oh!

joekaufmanexpensify commented Jun 26, 2025

Uh oh!

shawnborton commented Jun 27, 2025

Uh oh!

joekaufmanexpensify commented Jun 27, 2025

Uh oh!

narefyev91 commented Jun 30, 2025

Uh oh!

narefyev91 commented Jun 30, 2025

Uh oh!

dominictb commented Jun 30, 2025

Uh oh!

joekaufmanexpensify commented Jul 16, 2025

Uh oh!

joekaufmanexpensify commented Jul 16, 2025

Uh oh!

koko57 commented Jul 16, 2025

Uh oh!

joekaufmanexpensify commented Jul 16, 2025

Uh oh!

koko57 commented Jul 16, 2025

Uh oh!

dominictb commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joekaufmanexpensify commented Jul 16, 2025

Uh oh!

koko57 commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

joekaufmanexpensify commented Jul 17, 2025

Uh oh!

narefyev91 commented Jun 23, 2025 •

edited

Loading

narefyev91 commented Jun 25, 2025 •

edited

Loading

dominictb commented Jun 26, 2025 •

edited

Loading

dominictb commented Jun 26, 2025 •

edited

Loading

dominictb commented Jul 16, 2025 •

edited

Loading

koko57 commented Jul 17, 2025 •

edited

Loading

joekaufmanexpensify commented Jul 17, 2025 •

edited

Loading