Fix - Search - The chat filter is reset after clicking the message on the Search page #65026
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
|
Let's update the title to mention what this PR solves. |
FitseTLT
changed the title
|
done |
| fullyMergedSnapshotKeys: [ | ||
| ONYXKEYS.COLLECTION.TRANSACTION, | ||
| ONYXKEYS.COLLECTION.REPORT, | ||
| ONYXKEYS.COLLECTION.POLICY, | ||
| ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS, | ||
| ONYXKEYS.PERSONAL_DETAILS_LIST, | ||
| ], | ||
| }); |
There was a problem hiding this comment.
How did you pick these keys?
There was a problem hiding this comment.
Because in my opinion direct merging of BE response of these keys into the snapshot doesn't have any side effect. But @luacmartins @iwiznia this is the part in this pr that you need to pay attention to when reviewing. 👍
There was a problem hiding this comment.
But ofcourse if you want to check the type of data snapshot holds
App/src/types/onyx/SearchResults.ts
Lines 487 to 495 in 8fa239a
There was a problem hiding this comment.
I need to understand all this better... what this will do is basically set in the snapshot all the data for example of any entry in ONYXKEYS.COLLECTION.TRANSACTION that arrives as an update?
Also can you clarify exactly how you picked the keys? Like why not include for example ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST?
There was a problem hiding this comment.
I need to understand all this better... what this will do is basically set in the snapshot all the data for example of any entry in ONYXKEYS.COLLECTION.TRANSACTION that arrives as an update?
Yup
Also can you clarify exactly how you picked the keys? Like why not include for example ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST?
WORKSPACE_CARDS_LIST are also eligible I didn't add it because it was added to the type recently I have added it now. But basically all the types which hold a single collection member data (not Record of member data) are eligible because directly merging will not add a new record but instead update the specific record with a new props that were not available previously. For instance for TRANSACTION_id a new prop of receipt being added in BE response will update the specific transaction with a new info unavailable before so will fix the orignal bug we were aiming to fix. So the only types that don't fall into this are PERSONAL_DETAILS_LIST and REPORT_ACTIONS which hold records of member data. REPORT_ACTIONS should not be added because it will cause the current filter to be reset in Chat section as the regression we are trying to fix here. But I think it is a good idea to add PERSONAL_DETAILS_LIST into mergeAll because there is no case as REPORT_ACTIONS where we display filtered PERSONAL_DETAILS_LIST but if you guys think there is a case then we can remove it from the list.
There was a problem hiding this comment.
part of mergeAllConfigKeys and if it is we merge the whole some_obj into the specific policy data
Yea, I think this part is what we're concerned about. I know that we discussed the solution before, but maybe a better approach would be to always return the receipt object from Search even if the transaction doesn't have one. That'd mean that if we upload a receipt to a transaction without a receipt, we'd optimistically update it and wouldn't need to merge the entire object
There was a problem hiding this comment.
We are already optimstically updating it and that's why the original bug is not reproducible from the creator side. But, let's say from the admin side while the expense is created by the employee side, we still need this update so that BE update could be merged into the snapshot data.
There was a problem hiding this comment.
Right now we conditionally add the receipt key to SearchTransaction in the BE. What I'm suggesting is that we always include the key, so that any update including the receipt key would be picked up and applied by live updates. So we don't need to merge the entire key.
There was a problem hiding this comment.
Yep that also works 🤷
There was a problem hiding this comment.
Cool, I have a BE PR that'll do that https://github.com/Expensify/Auth/pull/16172
Screenshots🔲 iOS / native29.06.2025_17.31.04_REC.mp4🔲 iOS / Safari29.06.2025_17.32.14_REC.mp4🔲 MacOS / Desktop29.06.2025_17.25.37_REC.mp4🔲 MacOS / Chrome29.06.2025_16.29.16_REC.mp4🔲 Android / Chrome29.06.2025_17.18.40_REC.mp4🔲 Android / native29.06.2025_17.13.12_REC.mp4 |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
The bumping has been done by another pr all we need is to set is the configs. @luacmartins @iwiznia bump on your reviews Thx |
|
We merged a fix on the BE. @FitseTLT can you please retest to make sure the original issue is no longer reproducible? If so, I think we can close this and we should probably undo the changes in onyx too |
Nope not yet fixed 😢 @luacmartins 2025-07-19.00-48-16.mp4 |
|
Oh nvm, we reverted yesterday's deploy today. We need to wait for another deploy until this can be fixed. My bad! |
|
Let's test this again. The latest deploy should have fixed the issue. |
|
Testing on staging and I can still reproduce the main issue. |
|
@luacmartins, it is still not solved on staging. Or do you want me to test somewhere else? |
|
@FitseTLT Can you please test and confirm? |
|
@parasharrajat I think #60116 is fixed on staging, no? Screen.Recording.2025-07-23.at.10.16.18.AM.mov |
|
Still not fixed. @luacmartins please see the steps carefully. We are not dealing with the creator side here. It was already solved by our optimsitic update of the receipt field so it doesn't even need a BE fix for the steps you are showing in the vid. What we need to fix is the receiver's side like the vid below and it is still not fixed on staging. 2025-07-23.19-20-09.mp4 |
|
Ah I see. I also realized that even with the existing BE solution, something like this would be possible: 1. Transaction with receipt is loaded on Search. Snapshot contains transaction_: {receipt: {...}} So even if we initially return the key from Search, we can't guarantee that we won't get an update removing a key by setting it to null. That means any subsequent updates would be missed. So I think the only solution for the snapshot design is to merge the full object 😞 |
|
@FitseTLT we're discussing a proposal to get rid of snapshot data in general. So I think we should pause work on this PR/issue before we go deeper into this hole. I think that's ok since they are small issues. |
|
I think we should close this PR since we're working on a proposal to refactor how snapshots work. |
|
closing based on the above comment |
so @luacmartins what about a revert on the onyx repo? |
|
@FitseTLT yea, let's do that as well |
4 participants
Details
Fixed Issues
$ #60116 #63295
PROPOSAL: #63295 (comment)
Tests
Precondition: The user has sent a message with an attachment or a link
Precondition: a workspace has an employee with an expense without receipt
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-06-26.19-33-28.mp4
Android: mWeb Chrome
2025-06-26.18-57-07.mp4
iOS: Native
2025-06-26.18-53-51.mp4
iOS: mWeb Safari
2025-06-26.18-45-02.mp4
MacOS: Chrome / Safari
2025-06-26.18-42-54.mp4
MacOS: Desktop
2025-06-26.18-49-04.mp4