Skip to content

[No QA] remove redundant comment #65092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Jun 27, 2025
Merged

[No QA] remove redundant comment #65092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489151b
remove redundant code for real this time
getusha Jun 27, 2025
5be3990
remove redundant type
getusha Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/components/SelectionList/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,6 @@ type TransactionListItemType = ListItem &
/** IOUs report */
iouReportID?: string | undefined;

/** Whether the report is policyExpenseChat */
isPolicyExpenseChat?: boolean;

/** Precomputed violations */
violations?: TransactionViolation[];
};
Expand Down
6 changes: 0 additions & 6 deletions src/libs/SearchUIUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
accountID: CONST.REPORT.OWNER_ACCOUNT_ID_FAKE,
avatar: '',
displayName: undefined,
login: undefined,

Check warning on line 156 in src/libs/SearchUIUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
};

type ReportKey = `${typeof ONYXKEYS.COLLECTION.REPORT}${string}`;
Expand Down Expand Up @@ -501,10 +501,7 @@
// Use Map.get() for faster lookups with default values
const from = personalDetailsMap.get(transactionItem.accountID.toString()) ?? emptyPersonalDetails;
const to = transactionItem.managerID && !shouldShowBlankTo ? (personalDetailsMap.get(transactionItem.managerID.toString()) ?? emptyPersonalDetails) : emptyPersonalDetails;
// const isPolicyExpenseChat = !!reports.find((rp) => rp.policyID === transactionItem.policyID && rp.isPolicyExpenseChat);

// console.log({reports})
// console.log({isPolicyExpenseChat});
const {formattedFrom, formattedTo, formattedTotal, formattedMerchant, date} = getTransactionItemCommonFormattedProperties(transactionItem, from, to, policy);

const transactionSection: TransactionListItemType = {
Expand All @@ -525,7 +522,6 @@
isAmountColumnWide: shouldShowAmountInWideColumn,
isTaxAmountColumnWide: shouldShowTaxAmountInWideColumn,
violations: transactionViolations,
// isPolicyExpenseChat,

// Manually copying all the properties from transactionItem
transactionID: transactionItem.transactionID,
Expand Down Expand Up @@ -909,7 +905,6 @@

const from = data.personalDetailsList?.[transactionItem.accountID];
const to = transactionItem.managerID && !shouldShowBlankTo ? (data.personalDetailsList?.[transactionItem.managerID] ?? emptyPersonalDetails) : emptyPersonalDetails;
// const isPolicyExpenseChat = !!reports.find((rp) => rp.policyID === transactionItem.policyID && rp.isPolicyExpenseChat);

const {formattedFrom, formattedTo, formattedTotal, formattedMerchant, date} = getTransactionItemCommonFormattedProperties(transactionItem, from, to, policy);

Expand All @@ -932,7 +927,6 @@
violations: transactionViolations,
isAmountColumnWide: shouldShowAmountInWideColumn,
isTaxAmountColumnWide: shouldShowTaxAmountInWideColumn,
// isPolicyExpenseChat,
};
if (reportIDToTransactions[reportKey]?.transactions) {
reportIDToTransactions[reportKey].transactions.push(transaction);
Expand Down
3 changes: 0 additions & 3 deletions src/types/onyx/SearchResults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,6 @@ type SearchReportAction = {

/** The name of the report */
reportName: string;

/** Whether the report is policyExpenseChat */
isPolicyExpenseChat?: boolean;
};

/** Model of policy search result */
Expand Down
Loading