Removing violations for duplicate transactions. by Tony-MK · Pull Request #65107 · Expensify/App

Tony-MK · 2025-06-27T20:44:48Z

Explanation of Change

Implement a new function called updateDuplicatesTransactionsViolations to update the duplicate transaction violations of the transaction's duplicates when a transaction's amount, currency, and date are changed.

Fixed Issues

$ #63671
PROPOSAL: #63671 (comment)

Tests

Create a workspace.
Create two duplicate expenses without any violations.
Open the report.
Verify duplicate violation message on both expenses.
Change the amount or currency of one expense.
Verify that no violation message appears on both expenses.

Verify that no errors appear in the JS console

Offline tests

Create a workspace.
Create two duplicate expenses without any violations.
Open the report.
Verify duplicate violation message on both expenses.
Go offline.
Change the amount or currency of one expense.
Verify that the violation message disappeared on both expenses.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.-.Native.mov

Android: mWeb Chrome

Android.-.mWeb.copy.mov

iOS: Native

iOS.-.Native.mp4

iOS: mWeb Safari

iOS.-.mWeb.mp4

MacOS: Chrome / Safari

macOS.-.Chrome.mov

MacOS: Desktop

macOS.-.Desktop.mov

…eTransactions

melvin-bot · 2025-06-27T22:17:23Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…eTransactions

hungvu193 · 2025-06-30T10:45:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-30.at.15.18.25.mov

Screen.Recording.2025-06-30.at.15.22.19.mov

MacOS: Desktop

Desktop.mov

src/libs/actions/IOU.ts

iwiznia

Should we be updating the deprecated onyx connect calls in the modified file or how are we handling that migration?

src/libs/actions/IOU.ts

* Refactoring `updateDuplicateTransactionViolation` function. * lint * Restored src/index.js

Tony-MK · 2025-07-03T20:20:48Z

I don't quite get why that line would cause the violation to show when setting it to null, can you clarify?

Well, it's a strange bug. I don't know the exact root cause, and I still need time to find the root cause, but I think it has to do with caching in the onyx module. Since useTransactionViolations still returns the violation when it's already deleted in the onyx. This occurs while offline or online on Android: mWeb Chrome. However, I reproduced, sometimes, on Desktop: Chrome offline.

src/hooks/useDuplicateTransactionsAndViolations.ts

hungvu193

@Tony-MK Sorry for the delay. I left couple of comments

src/hooks/useDuplicateTransactionsAndViolations.ts

src/components/MoneyRequestHeader.tsx

src/hooks/useDuplicateTransactionsAndViolations.ts

src/libs/TransactionUtils/index.ts

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

hungvu193

I did a retest and it was looking good!

Over to you @iwiznia

src/hooks/useDuplicateTransactionsAndViolations.ts

src/libs/TransactionUtils/index.ts

iwiznia · 2025-07-29T14:04:33Z

src/libs/TransactionUtils/index.ts

+        }
+
+        if (duplicateTransactionViolations.length > 1) {
+            Log.warn(`There are ${duplicateTransactionViolations.length} duplicate transaction violations for transactionID: ${duplicateID}. This should not happen.`);


Please move the 2 variables to the 2nd param

Why did you resolve this? I don't see the code was udpated

Sorry about that I updated the code.

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

…eTransactions

OSBotify · 2025-08-01T11:16:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-04T19:58:39Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-06T19:29:35Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

situchan · 2025-12-29T02:57:34Z

src/libs/actions/IOU.ts

+        // If the amount, currency or date have been modified, we remove the duplicate violations since they would be out of date as the transaction has changed
+        const optimisticViolations =
+            hasModifiedAmount || hasModifiedDate || hasModifiedCurrency
+                ? currentTransactionViolations.filter((violation) => violation.name !== CONST.VIOLATIONS.DUPLICATED_TRANSACTION)
+                : currentTransactionViolations;


There was missing case of showing double violations when disabled category is removed.
More details: #75364 (comment)

Tony-MK and others added 8 commits June 24, 2025 21:54

inital testing

1162976

renaming varible

b33699c

Merge branch 'main' of https://github.com/Expensify/App into duplicat…

a383b2c

…eTransactions

using helper function for deleting money request

193740a

prettier

fb801ab

Merge branch 'Expensify:main' into duplicateTransactions

580c098

Merge branch 'Expensify:main' into duplicateTransactions

3afab42

applied fix to updateMoneyRequestDate

c1bfda2

Tony-MK marked this pull request as ready for review June 27, 2025 22:17

Tony-MK requested a review from a team as a code owner June 27, 2025 22:17

melvin-bot bot requested review from hungvu193 and removed request for a team June 27, 2025 22:17

Tony-MK mentioned this pull request Jun 27, 2025

[Due for payment 2025-08-13] [$250] IOU - Red Dot 'Duplicated' Still Visible Under Edited Expense After Amount Modification #63671

Closed

16 tasks

Merge branch 'main' of https://github.com/Expensify/App into duplicat…

f97a346

…eTransactions

hungvu193 reviewed Jun 30, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

hungvu193 approved these changes Jul 1, 2025

View reviewed changes

melvin-bot bot requested a review from iwiznia July 1, 2025 09:12

Tony-MK and others added 3 commits July 3, 2025 02:03

Merge branch 'main' into duplicateTransactions

900bec9

clearing up comments

b8b1bab

prettier

ee7721f

Tony-MK mentioned this pull request Jul 2, 2025

[Due for payment 2025-08-11] Hold Expenses – Bulk Unhold Status Not Reflected in Report Preview Until Page Refresh #63658

Closed

8 tasks

prettier

b2eab4b

iwiznia requested changes Jul 3, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

Tony-MK added 2 commits July 3, 2025 22:38

Merge branch 'Expensify:main' into duplicateTransactions

545f1d7

refactoring function into one (#61)

7f7df39

* Refactoring `updateDuplicateTransactionViolation` function. * lint * Restored src/index.js

Tony-MK and others added 2 commits July 3, 2025 23:28

Merge branch 'Expensify:main' into duplicateTransactions

0c53536

prettier

4fd1419

Resolving conflicts

233da31

hungvu193 reviewed Jul 27, 2025

View reviewed changes

src/hooks/useDuplicateTransactionsAndViolations.ts Outdated Show resolved Hide resolved

Tony-MK and others added 4 commits July 28, 2025 02:29

Merge branch 'main' into duplicateTransactions

3ece8d2

Update useDuplicateTransactionsAndViolations.ts

9480a57

lint

b6a5894

useDuplicateTransactionAndViolation.ts

7c16719

hungvu193 suggested changes Jul 28, 2025

View reviewed changes

Tony-MK added 4 commits July 28, 2025 22:15

moving useDuplicateTransactionsAndViolations

9657362

applied suggestions

9705cf9

applied changes

6e8a9af

lint

cb54fde

hungvu193 approved these changes Jul 29, 2025

View reviewed changes

melvin-bot bot requested a review from iwiznia July 29, 2025 04:15

iwiznia requested changes Jul 29, 2025

View reviewed changes

Tony-MK and others added 5 commits July 30, 2025 00:07

applied suggestions

97ac841

typecheck

496809d

refactoring getValidDuplicateTransactionIDs

2e4ae6e

Merge branch 'main' of https://github.com/Expensify/App into duplicat…

8464f3d

…eTransactions

reverting line

daa8de5

iwiznia approved these changes Aug 1, 2025

View reviewed changes

iwiznia merged commit c0ec500 into Expensify:main Aug 1, 2025
18 checks passed

github-actions bot mentioned this pull request Aug 4, 2025

Deploy Checklist: New Expensify 2025-08-04 #67808

Closed

This was referenced Aug 4, 2025

Expense - App crashes after resolving duplicates #67810

Closed

Expense - Expense which is not selected still persists after resolving duplicates #67832

Closed

situchan reviewed Dec 29, 2025

View reviewed changes

This was referenced Dec 30, 2025

[CLEAN] Synthetic Benchmark PR #65107 - Removing violations for duplicate transactions. qodo-benchmark/App#85

Open

[CORRUPTED] Synthetic Benchmark PR #65107 - Removing violations for duplicate transactions. qodo-benchmark/App#86

Open

Conversation

Tony-MK commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 27, 2025

Uh oh!

hungvu193 commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

iwiznia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tony-MK commented Jul 3, 2025

Uh oh!

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iwiznia Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

iwiznia Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Tony-MK Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

situchan Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Tony-MK commented Jun 27, 2025 •

edited

Loading

hungvu193 commented Jun 30, 2025 •

edited

Loading