Skip to content

[CP staging]Revert "Make getReportDetails a pure function - Recreate"#65348

Merged
puneetlath merged 1 commit intomainfrom
revert-64088-make-getReportDetails-to-pure-func-2
Jul 2, 2025
Merged

[CP staging]Revert "Make getReportDetails a pure function - Recreate"#65348
puneetlath merged 1 commit intomainfrom
revert-64088-make-getReportDetails-to-pure-func-2

Conversation

@techievivek
Copy link
Copy Markdown
Contributor

@techievivek techievivek commented Jul 2, 2025

Reverts #64088

Reverting to fix blockers.

Fixes

$ #65291
$ #65292

@techievivek techievivek self-assigned this Jul 2, 2025
@techievivek techievivek requested a review from a team as a code owner July 2, 2025 14:59
@techievivek techievivek changed the title Revert "Make getReportDetails a pure function - Recreate" [CP staging]Revert "Make getReportDetails a pure function - Recreate" Jul 2, 2025
@techievivek techievivek added the CP Staging marks PRs that have been CP'd to staging label Jul 2, 2025
@melvin-bot melvin-bot bot requested review from mollfpr and removed request for a team July 2, 2025 14:59
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Jul 2, 2025

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@puneetlath puneetlath merged commit 7e64084 into main Jul 2, 2025
20 of 24 checks passed
@puneetlath puneetlath deleted the revert-64088-make-getReportDetails-to-pure-func-2 branch July 2, 2025 15:11
@melvin-bot melvin-bot bot added the Emergency label Jul 2, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Jul 2, 2025

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Copy Markdown
Contributor

Merged since it's a straight revert to fix a deploy blocker.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 2, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jul 2, 2025
…etails-to-pure-func-2

[CP staging]Revert "Make getReportDetails a pure function - Recreate"

(cherry picked from commit 7e64084)

(cherry-picked to staging by puneetlath)
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2025

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.1.74-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 3, 2025

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants