-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Bump react native onyx 2.0.117 #65405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump react native onyx 2.0.117 #65405
Conversation
|
|
|
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-07-04.at.11.23.08.AM.movAndroid: mWeb ChromeScreen.Recording.2025-07-04.at.11.24.51.AM.moviOS: HybridAppScreen.Recording.2025-07-04.at.11.29.00.AM.movScreen.Recording.2025-07-04.at.11.29.51.AM.moviOS: mWeb SafariScreen.Recording.2025-07-04.at.11.30.40.AM.movMacOS: Chrome / SafariScreen.Recording.2025-07-04.at.11.21.30.AM.movMacOS: DesktopScreen.Recording.2025-07-04.at.11.24.19.AM.mov |
| "react-native-nitro-modules": "0.26.2", | ||
| "react-native-nitro-sqlite": "9.1.10", | ||
| "react-native-onyx": "^2.0.113", | ||
| "react-native-onyx": "^2.0.117", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabioh8010 I remember you were against bumping many versions at once, should we stick to updating one version at a time ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine this time. cc @mountiny
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not make it a common thing though, i agree individuals bumps are better
|
@TMisiukiewicz can you please upload platform recordings ? |
|
@allgandalf done ✅ |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.77-1 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.77-2 🚀
|
Explanation of Change
Changelog:
Expensify/react-native-onyx#649
Expensify/react-native-onyx#647
Expensify/react-native-onyx#652
Fixed Issues
$ #64950
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.web.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov