-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Use reanimated modal in Help modal #65409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 19 commits into
Expensify:main
from
software-mansion-labs:feat/use-reanimated-modal-in-help-modal
Jul 17, 2025
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1f0622a
Use reanimated modal in help modal
jmusial 8dfc80e
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
jmusial 2222350
update search router
jmusial 869ab9f
Merge branch 'feat/use-reanimated-modal-in-search-router-modal' into …
jmusial 3392944
update help overlay to use modal utils
jmusial c62bac4
add use Memo
jmusial 99e05c1
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
jmusial 05112dc
add modal slide right animation on web
jmusial be59e60
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
jmusial f72e5b3
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
jmusial e70b66b
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
jmusial 0a3047a
forgotten stashed commit
jmusial b07bf63
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
jmusial e88f641
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
jmusial 35e3492
fix lint issues
jmusial cd57479
shouldUseNarrowLayout not necessary after other PR merge
jmusial 35a5a9f
Remove unnecessary extra animated value
blazejkustra 6100297
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
mhawryluk 7d2ec50
Merge branch 'main' into feat/use-reanimated-modal-in-help-modal
mhawryluk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? Is there any plan to use something that is not restricted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use an animated value obtained from navigation to fix the modals being covered by the help modal. unfortunately, react-navigation uses Animated, instead of Reanimated, under the hood, so we cannot escape it here :/