Skip to content

Migrate Workspaces right-docked modals (1/2) to use Reanimated #65544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 9 commits into from
Jul 18, 2025
Merged

Migrate Workspaces right-docked modals (1/2) to use Reanimated #65544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a34891b
Migrate more right-docked modals to use Reanimated
mhawryluk Jul 7, 2025
ceb8a52
Merge branch 'feat/reanimated-year-picker-modal' into feat/more-right…
mhawryluk Jul 8, 2025
fb45173
Revert changes moved to separate PR
mhawryluk Jul 8, 2025
94faa37
Merge branch 'main' into feat/more-right-docked-reanimated-modals
mhawryluk Jul 16, 2025
737f659
Remove unnecessary prop usage
mhawryluk Jul 17, 2025
2692aa0
Merge branch 'main' into feat/more-right-docked-reanimated-modals
mhawryluk Jul 17, 2025
2c4ef84
Fix unrelated type error
mhawryluk Jul 17, 2025
4966ea7
Merge branch 'main' into feat/more-right-docked-reanimated-modals
mhawryluk Jul 17, 2025
5f5532f
Merge branch 'main' into feat/more-right-docked-reanimated-modals
mhawryluk Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/AmountPicker/AmountSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,8 @@ function AmountSelectorModal({value, description = '', onValueSelected, isVisibl
isVisible={isVisible}
onClose={onClose}
onModalHide={onClose}
hideModalContentWhileAnimating
useNativeDriver
enableEdgeToEdgeBottomSafeAreaPadding
shouldUseReanimatedModal
>
<ScreenWrapper
enableEdgeToEdgeBottomSafeAreaPadding
Expand Down
3 changes: 1 addition & 2 deletions src/components/TextPicker/TextSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,9 @@ function TextSelectorModal({
isVisible={isVisible}
onClose={hide}
onModalHide={hide}
hideModalContentWhileAnimating
useNativeDriver
shouldUseModalPaddingStyle={false}
enableEdgeToEdgeBottomSafeAreaPadding
shouldUseReanimatedModal
>
<ScreenWrapper
enableEdgeToEdgeBottomSafeAreaPadding
Expand Down
3 changes: 1 addition & 2 deletions src/pages/workspace/reportFields/InitialListValueSelector/InitialListValueSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,8 @@ function InitialListValueSelectorModal({isVisible, currentValue, label, subtitle
isVisible={isVisible}
onClose={onClose}
onModalHide={onClose}
hideModalContentWhileAnimating
useNativeDriver
enableEdgeToEdgeBottomSafeAreaPadding
shouldUseReanimatedModal
>
<ScreenWrapper
style={styles.pb0}
Expand Down
3 changes: 1 addition & 2 deletions src/pages/workspace/reportFields/TypeSelector/TypeSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ function TypeSelectorModal({isVisible, currentType, label, subtitle, onTypeSelec
isVisible={isVisible}
onClose={onClose}
onModalHide={onClose}
hideModalContentWhileAnimating
useNativeDriver
enableEdgeToEdgeBottomSafeAreaPadding
shouldUseReanimatedModal
>
<ScreenWrapper
style={styles.pb0}
Expand Down
Loading