Render ChatBubbleCell only if it's needed#65570
Merged
mountiny merged 5 commits intoExpensify:mainfrom Jul 14, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR removes
ChatBubbleCellrendering fromTransactionItemRowcomponent if the providedcolumnsproperty lacksCONST.REPORT.TRANSACTION_LIST.COLUMNS.COMMENTSentry.Fixed Issues
$ #65926
PROPOSAL: #65926
Tests
The modified component is used in two places:
Ensure that testing account has multiple reports and at least one report with multiple transactions
Reports page validation
Regressions
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
The modified component is used in two places:
Ensure that testing account has multiple reports and at least one report with multiple transactions
Reports page validation
Regressions
See
iOS mWeb Safariscreenshots for referencePR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop