Fix/63635 onyx lift money report view by Pujan92 · Pull Request #65644 · Expensify/App

Pujan92 · 2025-07-08T12:24:52Z

Explanation of Change

Part 2 - Improve ReportList performance by avoiding some of the Onyx connections from the MoneyRequestView component.

I think we don't really need to remove all onyx connections from MoneyReportView and MoneyRequestView. Bcoz these are the Views for a specific report and it(View action) will be only rendered once in any of the report. So, a single onyx connection for some of the keys will be fine here.

Fixed Issues

$ #63635
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Create an expense in a workspace chat or direct to user
Open that money request report
Verify it shows the details correctly
Sign in with the other user in diff browser and open same money request report
Try to update the details and verify that it is updated correctly for both users

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

and7.webm

Android: mWeb Chrome

and8.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-07-11.at.16.12.56.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-07-11.at.16.14.39.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-07-10.at.01.01.29.mov

MacOS: Desktop

Screen.Recording.2025-07-11.at.17.45.40.mov

melvin-bot · 2025-07-09T18:53:47Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2025-07-10T06:00:03Z

Money Request Report

=== 📁 Trace File Analysis ===

📄 File: profiling-data.10-07-2025.11-27-13(main2).json
  • Commit count: 58
  • Total render duration: 849.000 ms
  • p50 / p95 / p99 (ms):
    • p50: 0.400 ms
    • p95: 36.200 ms
    • p99: 465.800 ms

📄 File: profiling-data.10-07-2025.11-28-31(PR2).json
  • Commit count: 59
  • Total render duration: 865.400 ms
  • p50 / p95 / p99 (ms):
    • p50: 0.400 ms
    • p95: 37.200 ms
    • p99: 459.700 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.10-07-2025.11-28-31(PR2).json
  🔴 Duration Diff: 16.400 ms
  🔴 Commit Count Diff: 1

Pujan92 · 2025-07-10T06:07:07Z

I think perf will remain the same and won't be improved here as I mentioned in the PR description that this will be a single Created reportAction for the report.

hoangzinh · 2025-07-10T16:19:16Z

src/components/ReportActionItem/MoneyRequestView.tsx

-    const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, {canBeMissing: true});
-    const [transactionReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${updatedTransaction?.reportID}`, {canBeMissing: true});
+    const parentReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${parentReportID}`];
+    const chatReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${parentReport?.parentReportID}`];


Should we only pick reportID and errorFields as previously? To avoid recalcuate/render when unrelated chatReport data is changed.

It will be rerender whenever allReports gets changed. I don't think picking specific fields help here to avoid rerendering.

It will avoid reevalulate the useCallback here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 550 in 56ab1e0

}, [transaction, chatReport, parentReportAction, linkedTransactionID, report?.reportID]);

Do you think it's worth to keep previous logic?

hmm, makes sense. Reverted.

Sorry if it's unclear. I mean we can retrieve chatReport from allReports but should pick reportID and errorFields as previously.

const chatReport = lodashPick(allReports?.[${ONYXKEYS.COLLECTION.REPORT}${parentReportID}], ['reportID', 'errorFields']);

Btw, I think it will always recreate new object. Hmm, can you revert to your original version? I think it's not a big deal in this case.

Btw, I think it will always recreate new object

Yes.

can you revert to your original version? I think it's not a big deal in this case.

Done.

hoangzinh · 2025-07-14T01:58:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-07-14.at.21.10.46.android.mov

Android: mWeb Chrome

Screen.Recording.2025-07-14.at.20.05.01.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-07-14.at.21.19.39.mov

iOS: mWeb Safari

Screen.Recording.2025-07-14.at.21.15.15.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-14.at.20.01.24.web.mov

MacOS: Desktop

Screen.Recording.2025-07-14.at.20.02.54.desktop.mov

luacmartins

LGTM

OSBotify · 2025-07-14T18:50:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-15T03:22:17Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-16T19:53:59Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Pujan92 added 3 commits July 8, 2025 17:53

used allReports prop for MoneyRequestView

049b6d5

added allReports for TransactionDuplicate Confirmation

60658fd

pass policy as prop for MoneyRequestView

dd18aa0

Pujan92 changed the title ~~used allReports prop for MoneyRequestView~~ Fix/63635 onyx lift money report view Jul 9, 2025

Pujan92 added 5 commits July 9, 2025 11:39

added PolicyCategoriesProvider

0589188

Merge branch 'main' into fix/63635-onyx-lift-money-view

d9c63f3

added PolicyTagsProvider

fd61694

Merge branch 'main' into fix/63635-onyx-lift-money-view

eadfacc

Merge branch 'main' into fix/63635-onyx-lift-money-view

de2ed5d

Pujan92 marked this pull request as ready for review July 9, 2025 18:53

Pujan92 requested a review from a team as a code owner July 9, 2025 18:53

melvin-bot bot requested review from hoangzinh and removed request for a team July 9, 2025 18:53

Pujan92 mentioned this pull request Jul 10, 2025

[Due for payment 2025-07-17] Money Request and Transaction list performance optimizations #63635

Closed

hoangzinh reviewed Jul 10, 2025

View reviewed changes

Pujan92 added 7 commits July 11, 2025 14:19

Merge branch 'main' into fix/63635-onyx-lift-money-view

9b52aa0

Merge branch 'main' into fix/63635-onyx-lift-money-view

fea3e94

Merge branch 'main' into fix/63635-onyx-lift-money-view

c73803d

revert chatreport onyx

c3ea933

Merge branch 'main' into fix/63635-onyx-lift-money-view

97980d2

remove useOnyx for chatReport

aa38c85

Merge branch 'main' into fix/63635-onyx-lift-money-view

f2d2da9

hoangzinh approved these changes Jul 14, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins July 14, 2025 14:21

luacmartins assigned Pujan92 Jul 14, 2025

luacmartins approved these changes Jul 14, 2025

View reviewed changes

luacmartins merged commit a91f433 into Expensify:main Jul 14, 2025
18 checks passed

github-actions bot mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-07-15 #66099

Closed

95 tasks

Conversation

Pujan92 commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 9, 2025

Uh oh!

Pujan92 commented Jul 10, 2025

Uh oh!

Pujan92 commented Jul 10, 2025

Uh oh!

hoangzinh Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Pujan92 commented Jul 8, 2025 •

edited

Loading

Pujan92 Jul 11, 2025 •

edited

Loading

hoangzinh commented Jul 14, 2025 •

edited

Loading