perf: Move remaining useOnyx calls up in the Search component tree by OlimpiaZurek · Pull Request #65648 · Expensify/App

OlimpiaZurek · 2025-07-08T12:58:18Z

Explanation of Change

This PR moves the remaining useOnyx subscriptions up in the Search component tree

Fixed Issues

$ #63631
PROPOSAL:

Tests

Sign in to the app
Navigate to Reports by tapping the bottom tab
Verify that a list of Expenses is displayed, each showing the merchant, amount, and date etc.
Open the Search Type Menu:

On small screens, tap the menu button (top-right of the search view) to open the popover
On large screens, click Reports from the Search sidebar

Switch the search type to Reports
Confirm that a list of Reports appears
Open the Search Type Menu again (as in step 4) and switch to Chats
Confirm that a list of Chat is displayed
Clear the text in the search input field using the clear button (X)
Tap into the search input field
Verify that a list of recent searches appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.webm

Android: mWeb Chrome

android_mweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.-.2025-07-09.at.17.18.49.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

Screen.Recording.2025-07-09.at.17.21.22.mov

OlimpiaZurek · 2025-07-09T15:26:38Z

Expenses:

=== 📁 Trace File Analysis ===

📄 File: opening_expenses_before.json
• Commit count: 23
• Total render duration: 3726.372 ms
• p50 / p95 / p99 (ms):
• p50: 72.832 ms
• p95: 611.097 ms
• p99: 699.242 ms

📄 File: opening_expenses_after.json
• Commit count: 22
• Total render duration: 3091.822 ms
• p50 / p95 / p99 (ms):
• p50: 32.506 ms
• p95: 603.741 ms
• p99: 708.507 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ opening_expenses_after.json
🟢 Duration Diff: -634.550 ms
🟢 Commit Count Diff: -1

OlimpiaZurek · 2025-07-09T15:26:55Z

Chats:

=== 📁 Trace File Analysis ===

📄 File: opening_chats_before.json
• Commit count: 14
• Total render duration: 3168.482 ms
• p50 / p95 / p99 (ms):
• p50: 194.220 ms
• p95: 625.045 ms
• p99: 625.045 ms

📄 File: opening_chats_after.json
• Commit count: 14
• Total render duration: 2454.686 ms
• p50 / p95 / p99 (ms):
• p50: 122.036 ms
• p95: 521.652 ms
• p99: 521.652 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ opening_chats_after.json
🟢 Duration Diff: -713.796 ms
⚪️ Commit Count Diff: 0

OlimpiaZurek · 2025-07-09T15:27:16Z

Reports:

=== 📁 Trace File Analysis ===

📄 File: opening_reports_before.json
• Commit count: 16
• Total render duration: 7759.534 ms
• p50 / p95 / p99 (ms):
• p50: 38.467 ms
• p95: 1627.329 ms
• p99: 1627.329 ms

📄 File: opening_reports_after.json
• Commit count: 13
• Total render duration: 6180.622 ms
• p50 / p95 / p99 (ms):
• p50: 369.772 ms
• p95: 1565.958 ms
• p99: 1565.958 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ opening_reports_after.json
🟢 Duration Diff: -1578.912 ms
🟢 Commit Count Diff: -3

OlimpiaZurek · 2025-07-09T15:27:36Z

Search:

=== 📁 Trace File Analysis ===

📄 File: opening_search_before.json
• Commit count: 13
• Total render duration: 2121.719 ms
• p50 / p95 / p99 (ms):
• p50: 105.629 ms
• p95: 431.569 ms
• p99: 431.569 ms

📄 File: opening_search_after.json
• Commit count: 12
• Total render duration: 1370.915 ms
• p50 / p95 / p99 (ms):
• p50: 52.958 ms
• p95: 748.145 ms
• p99: 748.145 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ opening_search_after.json
🟢 Duration Diff: -750.804 ms
🟢 Commit Count Diff: -1

melvin-bot · 2025-07-09T15:28:39Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2025-07-09T18:57:45Z

@OlimpiaZurek Plz resolve conflicts.

Also tagging @hoangzinh for the second review.

src/components/SelectionList/ChatListItem.tsx

src/components/Search/SearchAutocompleteList.tsx

Pujan92 · 2025-07-11T09:03:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

andd1.webm

Android: mWeb Chrome

andd2.webm

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-07-13.at.18.46.38.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-07-13.at.18.45.32.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-07-13.at.18.26.40.mov

MacOS: Desktop

Pujan92 · 2025-07-11T12:26:51Z

src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

    const taxRates = useMemo(() => getAllTaxRates(), []);
    const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: true});
-    const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: true});
+    const [workspaceCardFeeds = getEmptyObject<Record<string, WorkspaceCardsList | undefined>>()] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: true});


Do we really need this assignment here and other places?

You're right, it's not needed here and adds unnecessary complexity. Already changed.

Pujan92

minor type changes

Pujan92 · 2025-07-11T13:48:18Z

src/components/Search/SearchAutocompleteList.tsx

+    reports: OnyxCollection<Report>;
+
+    /** All feeds */
+    allFeeds: Record<string, CardFeeds | undefined>;


Suggested change

allFeeds: Record<string, CardFeeds | undefined>;

allFeeds: Record<string, CardFeeds | undefined> | undefined;

Pujan92 · 2025-07-11T13:48:34Z

src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

+                                personalDetails={personalDetails}
+                                reports={reports}
+                                allCards={allCards}
+                                allFeeds={allFeeds ?? {}}


Suggested change

allFeeds={allFeeds ?? {}}

allFeeds={allFeeds}

src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

src/components/Search/SearchRouter/SearchRouter.tsx

Pujan92

LGTM!

github-actions · 2025-07-15T03:22:20Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-16T19:54:02Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OlimpiaZurek force-pushed the perf/63631-search-list-performance-optimizations branch 4 times, most recently from f54ad4e to 2da42e1 Compare July 9, 2025 14:30

OlimpiaZurek marked this pull request as ready for review July 9, 2025 15:28

OlimpiaZurek requested a review from a team as a code owner July 9, 2025 15:28

melvin-bot bot requested review from Pujan92 and removed request for a team July 9, 2025 15:28

OlimpiaZurek force-pushed the perf/63631-search-list-performance-optimizations branch 5 times, most recently from 04d651a to 5241f77 Compare July 10, 2025 11:40

OlimpiaZurek added 3 commits July 10, 2025 14:11

perf: Move remaining useOnyx calls up in the Search component tree

b6de5dc

fix conflicts

64d75dd

fix conflicts part 2

27fa473

OlimpiaZurek force-pushed the perf/63631-search-list-performance-optimizations branch from 5241f77 to 78b34db Compare July 10, 2025 12:12

fix conflicts part 3

2d83b00

OlimpiaZurek force-pushed the perf/63631-search-list-performance-optimizations branch from 78b34db to 2d83b00 Compare July 10, 2025 12:14

Pujan92 suggested changes Jul 10, 2025

View reviewed changes

src/components/SelectionList/ChatListItem.tsx Show resolved Hide resolved

src/components/Search/SearchAutocompleteList.tsx Show resolved Hide resolved

change after CR

0b03b11

Pujan92 reviewed Jul 11, 2025

View reviewed changes

remove unnecessary getEmptyObject calls

5f6f8ac

Pujan92 suggested changes Jul 11, 2025

View reviewed changes

small fix

65f120b

Pujan92 approved these changes Jul 13, 2025

View reviewed changes

melvin-bot bot requested a review from mjasikowski July 13, 2025 13:19

mjasikowski approved these changes Jul 14, 2025

View reviewed changes

mjasikowski merged commit eb6b77d into Expensify:main Jul 14, 2025
18 checks passed

github-actions bot mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-07-15 #66099

Closed

95 tasks

	allFeeds: Record<string, CardFeeds \| undefined>;
	allFeeds: Record<string, CardFeeds \| undefined> \| undefined;

Conversation

OlimpiaZurek commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

OlimpiaZurek commented Jul 9, 2025

Uh oh!

OlimpiaZurek commented Jul 9, 2025

Uh oh!

OlimpiaZurek commented Jul 9, 2025

Uh oh!

OlimpiaZurek commented Jul 9, 2025

Uh oh!

melvin-bot bot commented Jul 9, 2025

Uh oh!

Pujan92 commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Pujan92 commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurek Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OlimpiaZurek commented Jul 8, 2025 •

edited

Loading

Pujan92 commented Jul 11, 2025 •

edited

Loading