fix: go back when deleting Netsuite custom list by daledah · Pull Request #65670 · Expensify/App

daledah · 2025-07-08T17:02:17Z

Explanation of Change

Fixed Issues

$ #65407
PROPOSAL: #65407 (comment)

Tests

Precondition: Workspace is connected to NetSuite.

Go to workspace settings > Accounting.
Tap Import > Custom lists.
Click Add custom list. If there's already a custom list, go to step 5
Go through the flow to add a custom list.
After adding custom list, click on the added list.
Click Remove.
Click Remove.
Press device back button (swipe back for ios device)
Verify that: App return to Accounting settings.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: Workspace is connected to NetSuite.

Go to workspace settings > Accounting.
Tap Import > Custom lists.
Click Add custom list. If there's already a custom list, go to step 5
Go through the flow to add a custom list.
After adding custom list, click on the added list.
Click Remove.
Click Remove.
Press device back button (swipe back for ios device)
Verify that: App return to Accounting settings.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-07-09.at.01.00.00.mov

iOS: Native

Screen.Recording.2025-07-09.at.01.03.10.mov

iOS: mWeb Safari

Screen.Recording.2025-07-09.at.01.04.54.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-09.at.01.06.28.mov

MacOS: Desktop

Screen.Recording.2025-07-09.at.01.08.14.mov

melvin-bot · 2025-07-08T18:10:59Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2025-07-09T17:28:46Z

src/ROUTES.ts

-            `workspaces/${policyID}/accounting/netsuite/import/custom/${importCustomField as string}` as const,
+        getRoute: (policyID: string | undefined, importCustomField: ValueOf<typeof CONST.NETSUITE_CONFIG.IMPORT_CUSTOM_FIELDS>) => {
+            if (!policyID) {
+                Log.warn('Invalid policyID is used to build the POLICY_ACCOUNTING_NETSUITE_IMPORT_CUSTOM_FIELD_MAPPING route');


Any reason we're changing this to string|undefined and not handling the check when the method is called.

This is a pretty common convention in ROUTES so I just followed it.

mananjadhav · 2025-07-09T17:29:24Z

src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldView.tsx

    },
 }: NetSuiteImportCustomFieldViewProps) {
-    const policyID = policy?.id ?? '-1';
+    const policyID = policy?.id;


Does this have to be fixed on any other page?

This is to fix the lint-changed check, we only need to fix the files included in the PR.

mananjadhav

Minor comments. But I just want us to check if this needs to be fixed at other places.

mananjadhav · 2025-07-11T17:37:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-custom-list-back.mov

Android: mWeb Chrome

mweb-chrome-custom-list-back.mov

iOS: HybridApp

ios-custom-list-back.mov

iOS: mWeb Safari

mweb-safari-custom-list-back.mov

MacOS: Chrome / Safari

web-custom-list-back.mov

MacOS: Desktop

desktop-custom-list-back.mov

mananjadhav

Android screencast from @daledah is missing, but I've tested it on all platforms.

OSBotify · 2025-07-11T19:11:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-15T03:22:26Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-16T19:54:08Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

daledah added 2 commits July 9, 2025 00:02

fix: go back when deleting Netsuite custom list

f052397

fix: lint

018f304

daledah marked this pull request as ready for review July 8, 2025 18:10

daledah requested a review from a team as a code owner July 8, 2025 18:10

melvin-bot bot requested review from mananjadhav and removed request for a team July 8, 2025 18:10

daledah mentioned this pull request Jul 8, 2025

[Due for payment 2025-07-23] [$125] NetSuite - After deleting custom list and swiping back, app opens not here page #65407

Closed

8 tasks

mananjadhav reviewed Jul 9, 2025

View reviewed changes

mananjadhav approved these changes Jul 11, 2025

View reviewed changes

melvin-bot bot requested a review from thienlnam July 11, 2025 18:44

thienlnam approved these changes Jul 11, 2025

View reviewed changes

thienlnam merged commit 909a308 into Expensify:main Jul 11, 2025
20 of 25 checks passed

github-actions bot mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-07-15 #66099

Closed

95 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: go back when deleting Netsuite custom list#65670

fix: go back when deleting Netsuite custom list#65670
thienlnam merged 2 commits intoExpensify:mainfrom
daledah:fix/65407

daledah commented Jul 8, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jul 8, 2025

Uh oh!

mananjadhav Jul 9, 2025

Uh oh!

daledah Jul 10, 2025

Uh oh!

mananjadhav Jul 9, 2025

Uh oh!

daledah Jul 10, 2025

Uh oh!

mananjadhav left a comment

Uh oh!

mananjadhav commented Jul 11, 2025 •

edited

Loading

Uh oh!

mananjadhav left a comment

Uh oh!

Uh oh!

OSBotify commented Jul 11, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

daledah commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 8, 2025

Uh oh!

mananjadhav Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

daledah Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

daledah Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 11, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daledah commented Jul 8, 2025 •

edited

Loading

mananjadhav commented Jul 11, 2025 •

edited

Loading