Some fixes to help directories [No QA]#65686
Merged
inimaga merged 5 commits intoExpensify:maddylewis-patch-1from Jul 9, 2025
Merged
Some fixes to help directories [No QA]#65686inimaga merged 5 commits intoExpensify:maddylewis-patch-1from
inimaga merged 5 commits intoExpensify:maddylewis-patch-1from
Conversation
…lewis-patch-1 # Conflicts: # src/components/SidePanel/HelpContent/helpContentMap.tsx
58 tasks
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
@sumo-slonik please could you complete the PR author's checklist? |
inimaga
requested changes
Jul 9, 2025
77 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.1.79-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Coming from the comment here, this change includes:
Fixed Issues
N/A
PROPOSAL: N/A
Tests
Unnecessary
Offline tests
Unnecessary
QA Steps
Unnecessary
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.