[CP Staging] fix:65728: new chat autofocus is not triggered#65732
[CP Staging] fix:65728: new chat autofocus is not triggered#65732Eskalifer1 wants to merge 1 commit intoExpensify:mainfrom
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Eskalifer1, could you please add the screen recordings for missing platforms? |
|
@eVoloshchak On other platforms, the Composer trigger doesn't happen not because of my PR, but for some other reason (you can also see it on the prod), so I don't know if it makes sense to add them if autofocus doesn't work there |
|
@eVoloshchak Any updates? What should we do in this situation? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@Eskalifer1, it always makes sense to add the screen recordings for all platforms, even it the bug wasn't/isn't present. This is a rule and it allows us to double-check nothing has been broken |
|
@eVoloshchak Added videos |
|
Bug on iOS Safari: composer is not focused if you dismiss a modal instead of selecting an emoji Screen.Recording.2025-07-09.at.17.58.16.mov |
|
@Eskalifer1 @eVoloshchak I don't think the iOS Safari modal dismissal focus issue needs to be tracked/fixed in this PR. What's your ETA for finishing the review? Thanks! |
|
Changes were reverted, we can close this PR, i have opened a new one: #65770 All details left here: #65728 (comment) |
Explanation of Change
Fixed Issues
$#65728
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
65728-android.mp4
Android: mWeb Chrome
65728-android-web.mp4
iOS: Native
65728-ios.mp4
iOS: mWeb Safari
65728-ios.mp4
MacOS: Chrome / Safari
65728-Desktop-web.mp4
MacOS: Desktop
65728-Desktop.mp4