Skip to content

[CP Staging] Revert "Improve native top spacing for bottom docked modals when keyboard shows"#65735

Merged
mountiny merged 1 commit intoExpensify:mainfrom
software-mansion-labs:revert-63970-update-mobile-test-drive-for-better-scroll
Jul 9, 2025
Merged

[CP Staging] Revert "Improve native top spacing for bottom docked modals when keyboard shows"#65735
mountiny merged 1 commit intoExpensify:mainfrom
software-mansion-labs:revert-63970-update-mobile-test-drive-for-better-scroll

Conversation

@jmusial
Copy link
Copy Markdown
Contributor

@jmusial jmusial commented Jul 9, 2025 •
edited
Loading

Reverts #63970

Fixes:
$ #65729
$ #65700

@jmusial jmusial marked this pull request as ready for review July 9, 2025 11:58
@jmusial jmusial requested review from a team as code owners July 9, 2025 11:58
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team July 9, 2025 11:58
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Jul 9, 2025

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "Improve native top spacing for bottom docked modals when keyboard shows" [CP Staging] Revert "Improve native top spacing for bottom docked modals when keyboard shows" Jul 9, 2025
@mountiny
Copy link
Copy Markdown
Contributor

mountiny commented Jul 9, 2025

Straight revert, thanks!

@mountiny mountiny merged commit 93bd881 into Expensify:main Jul 9, 2025
15 of 19 checks passed
@melvin-bot melvin-bot bot added the Emergency label Jul 9, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Jul 9, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Jul 9, 2025
@mountiny
Copy link
Copy Markdown
Contributor

mountiny commented Jul 9, 2025

Straight revert

This was referenced Jul 9, 2025
Closed
Closed
OSBotify pushed a commit that referenced this pull request Jul 9, 2025
@mountiny @OSBotify
Merge pull request #65735 from software-mansion-labs/revert-63970-upd…
6b1ab3c 
…ate-mobile-test-drive-for-better-scroll

[CP Staging] Revert "Improve native top spacing for bottom docked modals when keyboard shows"

(cherry picked from commit 93bd881)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 9, 2025
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 9, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Jul 9, 2025
Closed
59 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 9, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.78-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 10, 2025

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.78-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

This was referenced Jul 10, 2025
Closed
Merged
@Julesssss Julesssss mentioned this pull request Jul 15, 2025
Closed
@jmusial jmusial deleted the revert-63970-update-mobile-test-drive-for-better-scroll branch August 26, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@marcochavezf marcochavezf Awaiting requested review from marcochavezf

Assignees

No one assigned

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmusial @mountiny @OSBotify