Fix: Unable to add unreported expense to IOU report by rayane-d · Pull Request #65802 · Expensify/App

rayane-d · 2025-07-10T01:23:45Z

Explanation of Change

Use convertTrackedExpenseToRequest API instead of changeTransactionsReport for IOU report

Fixed Issues

$ #62179
PROPOSAL:

Tests

Go to self DM.
Track a manual expense.
Open FAB > Create expense > Manual.
Submit a manual expense to any user (not workspace).
In 1:1 DM, click on the expense preview.
Click More.
Click Add expense > Add unreported expense.
Select the track expense from Step 2.
Click Add to report.
Verify that the track expense will be added to IOU without issue.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2025-07-10.at.2.17.36.AM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-07-10T01:23:51Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…se-to-IOU

MariaHCD

The logic looks good to me overall.

For the lint errors about Onyx.connect() is the rule to fix them when noticed on a PR or not?

MariaHCD · 2025-07-11T08:07:38Z

src/libs/actions/IOU.ts

+    }
+
+    const participantAccountIDs = getReportRecipientAccountIDs(iouReport, userAccountID);
+    const payerAccountID = participantAccountIDs.at(0);


Is the first accountID always going to be the payer?

Yes, getReportRecipientAccountIDs always returns a single account ID for IOU reports:

MariaHCD · 2025-07-11T08:14:31Z

Awaiting your review @mananjadhav !

rayane-d · 2025-07-11T09:28:52Z

For the lint errors about Onyx.connect() is the rule to fix them when noticed on a PR or not?

In this case, I think it's unrelated, since these are just warnings and the Changed files ESLint check is passing.

Also, the useOnyx() hook can't be used in lib files.

mananjadhav · 2025-07-11T15:52:18Z

I had reviewed the PR, testing out the changes.

mananjadhav · 2025-07-11T16:05:08Z

@rayane-d The attendees param seems to be showing [object Object].

mananjadhav · 2025-07-11T16:13:37Z

Screenshots/Videos

Android: HybridApp

android-convert-tracked-expense-report.mov

Android: mWeb Chrome

mweb-chrome-convert-tracked-expense-report.mov

iOS: HybridApp

ios-convert-tracked-expense-report.mov

iOS: mWeb Safari

mweb-safari-convert-tracked-expense-report.mov

MacOS: Chrome / Safari

web-convert-tracked-expense-report.mov

MacOS: Desktop

desktop-convert-tracked-expense-report.mov

rayane-d · 2025-07-11T17:18:03Z

@rayane-d The attendees param seems to be showing [object Object].

@mananjadhav yeah, the browser's network tab shows [object Object], but I checked the logs and the parameter value is actually correct:

465384154-86584288-78d4-4b30-8431-5ac63240b9cb

mananjadhav · 2025-07-11T17:24:26Z

eah, the browser's network tab shows [object Object], but I checked the logs and the parameter value is actually correct:

Yes you're right. Sorry about that.

mananjadhav · 2025-07-11T17:24:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mananjadhav

Checklist completed here and screenshots here.

OSBotify · 2025-07-14T08:44:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-15T03:22:44Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-16T19:54:26Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

hoangzinh · 2025-12-22T16:11:44Z

src/libs/actions/IOU.ts

+        const actionableWhisperReportActionID = getTrackExpenseActionableWhisper(transactionID, selfDMReportID)?.reportActionID;
+
+        const commentText = typeof transaction.comment === 'string' ? transaction.comment : (transaction.comment?.comment ?? '');
+        const parsedComment = getParsedComment(commentText);


Coming from #76047 (comment), we need to handle HTML format in commentText here.

Fix: Unable to add unreported expense to IOU report

1008065

rayane-d requested a review from a team as a code owner July 10, 2025 01:23

melvin-bot bot requested review from mananjadhav and removed request for a team July 10, 2025 01:23

rayane-d requested a review from MariaHCD July 10, 2025 01:24

Merge branch 'Expensify:main' into fix-Unable-to-add-unreported-expen…

b9b9d2a

…se-to-IOU

MariaHCD reviewed Jul 11, 2025

View reviewed changes

mananjadhav approved these changes Jul 11, 2025

View reviewed changes

melvin-bot bot requested a review from MariaHCD July 11, 2025 17:25

MariaHCD approved these changes Jul 14, 2025

View reviewed changes

MariaHCD merged commit da0805a into Expensify:main Jul 14, 2025
19 of 22 checks passed

rayane-d deleted the fix-Unable-to-add-unreported-expense-to-IOU branch July 14, 2025 09:15

github-actions bot mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-07-15 #66099

Closed

95 tasks

This was referenced Jul 15, 2025

fix: add unreported expense after dismiss modal #65720

Merged

[Due for payment 2025-07-25] Expense - Unable to add unreported expense to expense report #66107

Closed

rayane-d mentioned this pull request Jul 21, 2025

[Due for payment 2025-07-23] [$175] Expense - Unable to add unreported expense to IOU report #62179

Closed

8 tasks

hoangzinh reviewed Dec 22, 2025

View reviewed changes

Conversation

rayane-d commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 10, 2025

Uh oh!

MariaHCD left a comment

Choose a reason for hiding this comment

Uh oh!

MariaHCD Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

rayane-d Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

MariaHCD commented Jul 11, 2025

Uh oh!

rayane-d commented Jul 11, 2025

Uh oh!

mananjadhav commented Jul 11, 2025

Uh oh!

mananjadhav commented Jul 11, 2025

Uh oh!

mananjadhav commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots/Videos

Uh oh!

rayane-d commented Jul 11, 2025

Uh oh!

mananjadhav commented Jul 11, 2025

Uh oh!

mananjadhav commented Jul 11, 2025

Reviewer Checklist

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

hoangzinh Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rayane-d commented Jul 10, 2025 •

edited

Loading

mananjadhav commented Jul 11, 2025 •

edited

Loading