[No QA] Update Set-Custom-Report-Names.md#65819
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @maddylewis |
|
@MarioExpensify @maddylewis One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://4d848872.helpdot.pages.dev ⚡️ |
|
reviewing! |
MarioExpensify
left a comment
There was a problem hiding this comment.
Awesome, ready to merge! 😄
|
Weird, looks like the checklist automation is off somehow |
|
@MarioExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Not an emergency, checklists were filled! |
|
🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.81-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀
|
Explanation of Change
Updated to add report fields in to help doc itself, and remove reference to custom exports page. Also updated in like with new NewDot article.
Fixed Issues
https://github.com/Expensify/Expensify/issues/505552
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.