[CP Staging] Revert gasture handling for Search Router#65822
Merged
mountiny merged 1 commit intoExpensify:mainfrom Jul 10, 2025
Merged
[CP Staging] Revert gasture handling for Search Router#65822mountiny merged 1 commit intoExpensify:mainfrom
mountiny merged 1 commit intoExpensify:mainfrom
Conversation
|
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@ishpaul777 |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-07-10.11.59.47.movAndroid: mWeb Chrome2025-07-10.12.16.50.moviOS: HybridApp2025-07-10.11.54.27.moviOS: mWeb Safari2025-07-10.11.56.34.movMacOS: Chrome / Safariweb.movMacOS: Desktopweb.mov |
Contributor
|
LGTM ! |
ZhenjaHorbach
approved these changes
Jul 10, 2025
Contributor
|
@mountiny |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
OSBotify
pushed a commit
that referenced
this pull request
Jul 10, 2025
…-issues [CP Staging] Revert gasture handling for Search Router (cherry picked from commit 0b6a65b) (cherry-picked to staging by mountiny)
77 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.79-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀
|
This was referenced Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
RespondertoGestureHandlerchange caused side effects on web & desktop apps. Reverting to the previous version. The gesture handling on IOS will be fixed in #65280. Edit: new implementation of modal seems to be working ok with this, so the gesture works now. The other issue can be closed when this merges.Fixed Issues
$ #65816
$ #65815
$ #65822
PROPOSAL:
N/A
Tests
Search field is not focused after selecting a suggestion via keyboard
Search - Cursor automatically moves to the end after moving the cursor elsewhere
mWeb - Search - Unable to open any chat from search list.
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
0029.search.focus.android.native.mov
Android: mWeb Chrome
0029.search.focus.android.chrome.mov
iOS: Native
0029.search.focus.ios.native.mp4
iOS: mWeb Safari
0029.search.focus.ios.safari.mp4
MacOS: Chrome / Safari
0029.search.focus.desktop.web.mov
MacOS: Desktop
https://github.com/user-attachments/assets/c469dbdc-cf10-4251-814a-7b4e4b6d1046