[CP Staging] Fix mobile selection mode bugs#65859
Merged
grgia merged 2 commits intoExpensify:mainfrom Jul 11, 2025
Merged
Conversation
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-07-11.at.07.05.46.mp4Android: mWeb ChromeScreen.Recording.2025-07-11.at.07.04.00.mp4iOS: HybridAppScreen.Recording.2025-07-11.at.07.00.35.mp4iOS: mWeb SafariScreen.Recording.2025-07-11.at.06.58.56.mp4MacOS: Chrome / SafariScreen.Recording.2025-07-11.at.06.28.10.mp4Screen.Recording.2025-07-11.at.06.46.29.mp4Offline case - remove multiple Screen.Recording.2025-07-11.at.07.45.45.mp4MacOS: DesktopScreen.Recording.2025-07-11.at.06.55.01.mp4 |
suneox
approved these changes
Jul 11, 2025
mountiny
approved these changes
Jul 11, 2025
grgia
approved these changes
Jul 11, 2025
OSBotify
pushed a commit
that referenced
this pull request
Jul 11, 2025
…bile-selection-mode-refactor-blockers [CP Staging] Fix mobile selection mode bugs (cherry picked from commit d8c93a1) (cherry-picked to staging by mountiny)
77 tasks
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.79-11 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #65824
$ #65821
PROPOSAL:
Tests
Go to any chat.
Submit two expenses in the chat.
Go to Reports > Reports.
Select an expense via checkbox.
Click View on the selected expense.
Click More > Delete.
Delete the expense.
Make sure that dropdown is "1 selected" dropdown is not visible.
Navigate to staging.new.expensify.com
Create workspace > more feature > Enable Tag
Add 1 or 2 Tags
Click one of the tags to edit
Make sure that tag detail page is open to edit rather than selection mode
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-07-10.at.15.44.43.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-07-10.at.15.45.53.mov
MacOS: Desktop