-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Optimistic report name computation #65862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
neil-marcellini
merged 65 commits into
Expensify:main
from
callstack-internal:feat/optimistic-report-title
Aug 18, 2025
Merged
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
8cd69d2
Initial implementation of optimistic report name computation
sosek108 08b84d3
Introduce tests for Optimistic Report Names. Add Logging and
sosek108 58b5f65
Add tests for Optimistic Report Names
sosek108 2810b00
Introduce reassure tests
sosek108 7b36cbd
Merge branch 'main' into feat/optimistic-report-title
koko57 0d66c9c
fix: imports
koko57 33b27a1
chore: run prettier
koko57 27b9b41
fix: do not show unsupported fields, add spaces between parts
koko57 86ac06b
fix: minor fix
koko57 d7e912c
fix: add freetext to cspell
koko57 a16b79d
chore: rename CustomFormula to Formula, add missing spaces, adderess …
koko57 04755c6
fix: imports
koko57 03f09be
fix: date formatting
koko57 0b4681f
fix: revert adding spaces
koko57 2711fc6
Merge branch 'main' into feat/optimistic-report-title
sosek108 9ec9e17
Rename beta to match backend value
sosek108 e358534
Add test cases for spaces around free text
sosek108 b3c7c2b
Get valid date for `startdate` formula part
sosek108 4339a7d
More optimal way to get oldest report action
sosek108 6d2a77b
startdate and created date computation. date formats
sosek108 c0dd1f0
Merge branch 'main' into feat/optimistic-report-title
sosek108 4a9391f
format report types
sosek108 a270a9b
Use consts as typeMapping keys
sosek108 9e0a6bd
Centralized connection manager to use onyx values in optimistic report
sosek108 75f85b4
Default startdate
sosek108 3168ff8
Revert unwanted changes
sosek108 1856b71
exclude partial transactions from getOldestTransactionDate
sosek108 fc26fcc
domainName function
sosek108 4076a3a
valid report types check
sosek108 ecc5a1e
Small improvements, beta name correction
sosek108 0285d67
report filtering for policyID
sosek108 18481be
Merge branch 'main' into feat/optimistic-report-title
sosek108 776e7ad
Make single path for old and new reports name computation
sosek108 5c92ef2
filter by __FAKE__ policyId
sosek108 0a68994
Explained usage of Onyx.connectWithoutView in connection mangager
sosek108 2bd87e8
Connection manager is initialized in async manner
sosek108 3ba4506
PR fixes to for testing
sosek108 74e08ba
Merge branch 'main' into feat/optimistic-report-title
sosek108 d3bca5b
Removed dependency on TransactionDetails. Added comment for potentail
sosek108 6aa78f7
Fixed Formula tests
sosek108 4745680
add mock for getCurrencySymbol
sosek108 ddc1bf7
Proper handle of white spaces
sosek108 032270f
Tests fixes
sosek108 a4c7de6
Merge branch 'main' into feat/optimistic-report-title
sosek108 3b8e79b
Linter fixes in test files
sosek108 4c91fe6
Eslint errors
sosek108 b0dd011
spellcheck
sosek108 97a35d5
typecheck errors
sosek108 b67b3f7
lint fixes
sosek108 e346148
Merge branch 'main' into feat/optimistic-report-title
sosek108 cb998e1
comment cleanse
sosek108 ece6b19
Merge branch 'main' into feat/optimistic-report-title
sosek108 739b79d
PR comment fixes
sosek108 f11219f
Merge branch 'main' into feat/optimistic-report-title
sosek108 df844a5
Make OptimisticReportNames logic synchronous in prepareRequest
sosek108 87989c8
eslint fixes
sosek108 71fed6b
Skip optimisitc report name processing for OpenReport
sosek108 3defbcb
remove console.log
sosek108 c327965
chnaged default format to complain with backend
sosek108 64f7122
Remove tracking for transaction updates
sosek108 869b6ad
default date format
sosek108 1dc80ac
Test fixes
sosek108 ec2a1c1
Merge branch 'main' into feat/optimistic-report-title
sosek108 2992150
Merge branch 'main' into feat/optimistic-report-title
sosek108 ad97611
PR comment fixes
sosek108 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -239,6 +239,7 @@ | |
| "formatjs", | ||
| "Français", | ||
| "Frederico", | ||
| "freetext", | ||
| "frontpart", | ||
| "fullstory", | ||
| "FWTV", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.