Skip to content

[CP Staging] fix: Hide review button when there is no violations #65869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 3 commits into from
Jul 10, 2025
Merged

[CP Staging] fix: Hide review button when there is no violations #65869

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70701ef
fix review button when transaction have violations
TMisiukiewicz Jul 10, 2025
29d8bc8
handle transactionViolations updated to undefined
TMisiukiewicz Jul 10, 2025
49066a3
reuse violationKey
TMisiukiewicz Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/libs/actions/OnyxDerived/configs/reportTransactionsAndViolations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import type {OnyxCollection} from 'react-native-onyx';
import createOnyxDerivedValueConfig from '@userActions/OnyxDerived/createOnyxDerivedValueConfig';
import ONYXKEYS from '@src/ONYXKEYS';
import type {Transaction} from '@src/types/onyx';
import type {Transaction, TransactionViolation} from '@src/types/onyx';

let previousTransactions: OnyxCollection<Transaction> = {};
let previousViolations: OnyxCollection<TransactionViolation[]> = {};

export default createOnyxDerivedValueConfig({
key: ONYXKEYS.DERIVED.REPORT_TRANSACTIONS_AND_VIOLATIONS,
Expand Down Expand Up @@ -56,16 +57,25 @@ export default createOnyxDerivedValueConfig({
}

const transactionID = transaction.transactionID;
const transactionViolations = violations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`];
const violationKey = `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`;
const transactionViolations = violations?.[violationKey];
const previousTransactionViolations = previousViolations?.[violationKey];

const violationInSourceValues = transactionViolationsUpdates?.[violationKey];

// If violations exist and have length > 0, add them to the structure
if (transactionViolations && transactionViolations.length > 0) {
reportTransactionsAndViolations[reportID].violations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`] = transactionViolations;
reportTransactionsAndViolations[reportID].violations[violationKey] = transactionViolations;
} else if (violationInSourceValues === undefined || (previousTransactionViolations && previousTransactionViolations.length > 0)) {
// If violations were removed (previous had violations but current doesn't) or explicitly set to undefined, remove them from the structure
delete reportTransactionsAndViolations[reportID].violations[violationKey];
}

reportTransactionsAndViolations[reportID].transactions[transactionKey] = transaction;
}

previousTransactions = transactions;
previousViolations = violations;

return reportTransactionsAndViolations;
},
Expand Down
Loading