Fix: New message marker is not displayed on the first message in expense report by nyomanjyotisa · Pull Request #65918 · Expensify/App

nyomanjyotisa · 2025-07-11T06:55:24Z

Explanation of Change

Fixed Issues

$ #63427
PROPOSAL: #63427 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Navigate to workspace chat
Create two expenses
Click on Expense preview
Send a message in the expense report
Right click on the message > Mark as unread
Verify that the green new message marker displayed on the message
Delete the message
Click More > Download as CSV
Go back to main workspace chat
Open the expense report
Verify that the new message marker appears above "exported to CSV" message
Go back to main workspace chat
Reopen the expense report
Verify that the new message marker disappear after reopening the expense report

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

…nse report

melvin-bot · 2025-07-14T05:32:59Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nyomanjyotisa · 2025-07-14T05:41:26Z

@c3024 Regarding the regression, here's the RCA and the solution implemented in this PR

RCA

When checking for unread actions to determine whether to call readNewestAction(), we explicitly excludes actions from the current user

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Lines 290 to 292 in 15e4323

    
           const hasUnreadReportAction = reportActions.some( 
        
               (reportAction) => newMessageTimeReference && newMessageTimeReference < reportAction.created && reportAction.actorAccountID !== getCurrentUserAccountID(), 
        
           );

And since system-generated messages (like CSV export, approval, etc.) are created with the current user as the actor, this condition excludes them from being considered as "unread actions". As a result, readNewestAction is never called when reopening the expense report, and the new message marker is not removed

Solution

We should update the hasUnreadReportAction condition to include system messages that can be identified by checking if the action is NOT an ADD_COMMENT

c3024 · 2025-07-14T13:22:33Z

The same logic is used in ReportActionsList. But, it works well there.

For example,

Create a workspace
Invite a member
#admins room shows the invited message
Mark this as unread if required
Click on another report from LHN
Go back to the #admins room
The unread marker goes away

But, this does not happen for MoneyRequestReportActionsList for the steps in #65487 even though it is a similar flow.

nyomanjyotisa · 2025-07-17T05:41:28Z

After looking into the issue, I found that the problem actually comes from this condition

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Line 259 in 15e4323

    
           if (isUnread(report, transactionThreadReport) || (lastAction && isCurrentActionUnread(report, lastAction))) {

RCA

isCurrentActionUnread only considers an action as "current unread" if it's the oldest unread action in a sequence.

App/src/libs/ReportActionsUtils.ts

Lines 1884 to 1893 in 15e4323

    
           function isCurrentActionUnread(report: OnyxEntry<Report>, reportAction: ReportAction): boolean { 
        
               const lastReadTime = report?.lastReadTime ?? ''; 
        
               const sortedReportActions = getSortedReportActions(Object.values(getAllReportActions(report?.reportID))); 
        
               const currentActionIndex = sortedReportActions.findIndex((action) => action.reportActionID === reportAction.reportActionID); 
        
               if (currentActionIndex === -1) { 
        
                   return false; 
        
               } 
        
               const prevReportAction = sortedReportActions.at(currentActionIndex - 1); 
        
               return isReportActionUnread(reportAction, lastReadTime) && (currentActionIndex === 0 || !prevReportAction || !isReportActionUnread(prevReportAction, lastReadTime)); 
        
           }

The function returns true only when an action is unread AND either it's the first action OR the previous action is already read.
In the MoneyRequestReportActionsList case, when we add 2 expense to a report and export it as CSV, we have 4 consecutive unread actions: IOU → IOU → BILLABLEUPDATETRANSACTION → EXPORTCSV

When isCurrentActionUnread is called on the EXPORTCSV action (the lastAction), it returns false because the previous action (BILLABLEUPDATETRANSACTION) is also unread. The function only considers the first unread action in a sequence as "current unread"

In contrast, the ReportActionsList case works because there's only one unread action (POLICYCHANGELOG_ADD_EMPLOYEE), making it both the first and last unread action in the sequence, so isCurrentActionUnread returns true

BUT we could get the same issue on ReportActionsList if we have 2 consecutive unread actions as well

Here is how to reproduce it:

Create a workspace
Invite 2 members
Upgrade workspace to Control
#admins room shows the system message
Note that the first thread reply marked as unread
Click on another report from LHN
Go back to the thread on #admins room
The unread marker does not disappear

New-Expensify.mp4

Solution

We should update the condition in MoneyRequestReportActionsList and ReportActionsList to also check if there are any unread actions at all, not just if the current action is the "first" unread action

const hasAnyUnreadActions = reportActions.some(action => isReportActionUnread(action, report?.lastReadTime ?? ''));

if (isUnread(report, transactionThreadReport) || (lastAction && isCurrentActionUnread(report, lastAction)) || hasAnyUnreadActions) {
    ...
}

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Line 259 in 15e4323

    
           if (isUnread(report, transactionThreadReport) || (lastAction && isCurrentActionUnread(report, lastAction))) {

…nse report

c3024 · 2025-07-21T10:03:37Z

Thanks for the digging. Even when there are four unread actions the unread marker shows up only on the exported report action because the other actions are excluded from the visible actions here.

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Lines 169 to 179 in dfa504a

    
           const visibleReportActions = useMemo(() => { 
        
               const filteredActions = reportActions.filter((reportAction) => { 
        
                   const isActionVisibleOnMoneyReport = isActionVisibleOnMoneyRequestReport(reportAction); 
        
                   return ( 
        
                       isActionVisibleOnMoneyReport && 
        
                       (isOffline || isDeletedParentAction(reportAction) || reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || reportAction.errors) && 
        
                       shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canPerformWriteAction) && 
        
                       isIOUActionMatchingTransactionList(reportAction, reportTransactionIDs) 
        
                   ); 
        
               });

So, would it be better to match this unread logic with the unread marker logic with passing the visibleActions to isCurrentActionUnread like

if (isUnread(report, transactionThreadReport) || (lastAction && isCurrentActionUnread(report, lastAction, visibleReportActions)))

here and use it first before finding the sortedReportActions in the isCurrentActionUnread function?

function isCurrentActionUnread(report: OnyxEntry<Report>, reportAction: ReportAction, visibleReportActions?: ReportAction[]): boolean {
    const lastReadTime = report?.lastReadTime ?? '';
    const sortedReportActions = visibleReportActions ?? getSortedReportActions(Object.values(getAllReportActions(report?.reportID)));
   /* remaining code */
}

nyomanjyotisa · 2025-07-22T07:24:19Z

Yeah, I think your approach is better than broadly checking for any unread actions. Thanks for the suggestion! I'll update the PR accordingly

…nse report

c3024 · 2025-07-27T12:51:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

unreadAndroid.mov

Android: mWeb Chrome

unreadAndroidmWeb.mov

iOS: HybridApp

unreadiOS.mov

iOS: mWeb Safari

unreadiOSmWeb.mov

MacOS: Chrome / Safari

unreadChrome1.mov

MacOS: Desktop

unreadDesktop.mov

c3024

LGTM!

OSBotify · 2025-07-29T22:19:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-31T12:16:53Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.1.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

m-natarajan · 2025-08-01T00:56:08Z

PR is failing with #67597 on all the platforms

https://platform.applause.com/services/links/v1/external/7f6815e9859b89019b24113305735ef8a91d5fa2918d66d2fdcc7dbb2ba0d438
https://platform.applause.com/services/links/v1/external/cfff2ca24547bb3315be7f323bdcf31ee96ca1f0a1d36c396d7ce289ea709842
https://platform.applause.com/services/links/v1/external/6ec2243e65ae516f4fb69006775e145f0ecc2506ee5d05bba6d7a3ad50256c3b
https://platform.applause.com/services/links/v1/external/efb20c2ad66eecb508a0713268e1c9fb4f13f05660b00dc1182911f57c340dc0
https://platform.applause.com/services/links/v1/external/b29a0b84fc8b84784e68535b418cf01ce9f6197636b241cb116a9f66b6c36526

nyomanjyotisa · 2025-08-04T05:52:43Z

Seems like when we do this steps:

Add a comment in the report chat
Mark it as unread
Go to another chat
Go back to the report chat
The green new message marker appears
Go to another chat
Go back to the report chat
The green new message marker disappears
Delete the comment
Export the report to CSV
Wait until "exported to CSV" system message appears
Navigate back to the same workspace chat

The EXPORTCSV is marked as read, even when the page that displaying the system message is not focused yet

This behavior does not occur if:

We skip step 1-9 (no comment is added) and start from step 10, or
We navigate to a different chat after the export (e.g., Concierge instead of the same workspace chat)

Scenario 1 (Fail):

MacOS-Chrome.mp4

Scenario 2 (Success):

MacOS-Chrome-2.mp4

Scenario 3 (Success):

MacOS-Chrome-3.mp4

We can fix this by adding early check here to ensures that the report is only marked as read when the user is actually viewing it

        if (!isFocused) {
            return;
        }

cc @c3024

github-actions · 2025-08-04T19:23:48Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix: New message marker is not displayed on the first message in expe…

de66dc5

…nse report

nyomanjyotisa marked this pull request as ready for review July 14, 2025 05:32

nyomanjyotisa requested a review from a team as a code owner July 14, 2025 05:32

melvin-bot bot requested review from c3024 and removed request for a team July 14, 2025 05:32

nyomanjyotisa added 2 commits July 17, 2025 13:53

Fix: New message marker is not displayed on the first message in expe…

4252c2a

…nse report

lint fix

1e110f5

nyomanjyotisa added 2 commits July 22, 2025 15:26

Fix: New message marker is not displayed on the first message in expe…

0f1ae76

…nse report

Merge branch 'main' into issue-63427-2

4b40a1b

This was referenced Jul 24, 2025

Reports - System message after moving expenses, remains with "Unread" status in "Chats" #66994

Closed

[$500] [HOLD on retest] New message marker displayed when revisiting expense report #65645

Closed

c3024 approved these changes Jul 27, 2025

View reviewed changes

melvin-bot bot requested a review from youssef-lr July 27, 2025 12:54

youssef-lr approved these changes Jul 29, 2025

View reviewed changes

youssef-lr merged commit f5add7b into Expensify:main Jul 29, 2025
19 checks passed

github-actions bot mentioned this pull request Jul 31, 2025

Deploy Checklist: New Expensify 2025-07-31 #67499

Closed

90 tasks

lanitochka17 mentioned this pull request Jul 31, 2025

[Due for payment 2025-08-22] [$250] [RCA #65918] Expense - New message marker above "exported to CSV" does not appear after opening report #67597

Closed

16 tasks

melvin-bot bot mentioned this pull request Aug 4, 2025

[C+ Checklist Needs Completion] [$125] Expense report - New message marker is not displayed on the first message in expense report #63427

Closed

8 tasks

c3024 mentioned this pull request Aug 13, 2025

Fix scrolling to bottom list on MoneyRequestReportView #59664

Merged

48 tasks

Conversation

nyomanjyotisa commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 14, 2025

Uh oh!

nyomanjyotisa commented Jul 14, 2025

RCA

Solution

Uh oh!

c3024 commented Jul 14, 2025

Uh oh!

nyomanjyotisa commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

RCA

Solution

Uh oh!

c3024 commented Jul 21, 2025

Uh oh!

nyomanjyotisa commented Jul 22, 2025

Uh oh!

c3024 commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

m-natarajan commented Aug 1, 2025

Uh oh!

nyomanjyotisa commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nyomanjyotisa commented Jul 11, 2025 •

edited

Loading

nyomanjyotisa commented Jul 17, 2025 •

edited

Loading

c3024 commented Jul 27, 2025 •

edited

Loading